diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-07-22 09:54:45 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-07-25 10:04:06 +0200 |
commit | 8a843f7e98dfe6bfb04e91e5b16e3a1df18fbf58 (patch) | |
tree | 521d82ee0690adc18dd51f2124c57ed3efa72adc /svx | |
parent | 0351bec874f7e83c437e485e8d61a41f32718e25 (diff) |
loplugin:moveit
make the plugin more conservative, so we see less false+
(although we also miss some possibilities in the process)
Change-Id: I91b1806271e7f802d7459834ab7bcc569047da3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137342
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
25 files changed, 43 insertions, 43 deletions
diff --git a/svx/source/customshapes/EnhancedCustomShape2d.cxx b/svx/source/customshapes/EnhancedCustomShape2d.cxx index 87c081628993..8ce8c83b07a9 100644 --- a/svx/source/customshapes/EnhancedCustomShape2d.cxx +++ b/svx/source/customshapes/EnhancedCustomShape2d.cxx @@ -2611,7 +2611,7 @@ void EnhancedCustomShape2d::CreateSubPath( SdrPathObjUniquePtr pFill(new SdrPathObj( mrSdrObjCustomShape.getSdrModelFromSdrObject(), SdrObjKind::Polygon, - aClosedPolyPolygon)); + std::move(aClosedPolyPolygon))); SfxItemSet aTempSet(*this); aTempSet.Put(makeSdrShadowItem(false)); aTempSet.Put(XLineStyleItem(drawing::LineStyle_NONE)); diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx b/svx/source/customshapes/EnhancedCustomShape3d.cxx index 04d685c62122..748492aec630 100644 --- a/svx/source/customshapes/EnhancedCustomShape3d.cxx +++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx @@ -535,7 +535,7 @@ SdrObject* EnhancedCustomShape3d::Create3DObject( p3DObj = new E3dExtrudeObj( rSdrObjCustomShape.getSdrModelFromSdrObject(), a3DDefaultAttr, - aPolyPoly, + std::move(aPolyPoly), 0); p3DObj->NbcSetLayer( pShape2d->GetLayer() ); diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx index 7b53511f6cfb..9311763920bb 100644 --- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx @@ -921,7 +921,7 @@ static SdrObject* CreateSdrObjectFromParagraphOutlines( pRet = new SdrPathObj( rSdrObjCustomShape.getSdrModelFromSdrObject(), SdrObjKind::Polygon, - aPolyPoly); + std::move(aPolyPoly)); SfxItemSet aSet(rSdrObjCustomShape.GetMergedItemSet()); aSet.ClearItem( SDRATTR_TEXTDIRECTION ); //SJ: vertical writing is not required, by removing this item no outliner is created diff --git a/svx/source/diagram/IDiagramHelper.cxx b/svx/source/diagram/IDiagramHelper.cxx index c090c88e7dec..672c7485540a 100644 --- a/svx/source/diagram/IDiagramHelper.cxx +++ b/svx/source/diagram/IDiagramHelper.cxx @@ -237,7 +237,7 @@ void OverlayDiagramPrimitive::create2DDecomposition( // top/left, would require alternative creation) rContainer.push_back( new drawinglayer::primitive2d::PolyPolygonStrokePrimitive2D( - aPolyPolygon, + std::move(aPolyPolygon), aLineAttribute)); // top-left line pattern (as grep-here-sign to signal @@ -264,7 +264,7 @@ void OverlayDiagramPrimitive::create2DDecomposition( new drawinglayer::primitive2d::PolygonStrokePrimitive2D( std::move(aPolygonLapDown), aLineAttribute, - aStrokeAttribute)); + std::move(aStrokeAttribute))); // add text last. May use darker text color, go for same color // as accentuation line for now diff --git a/svx/source/dialog/contwnd.cxx b/svx/source/dialog/contwnd.cxx index 48ace0ac7d17..0043f7f0a920 100644 --- a/svx/source/dialog/contwnd.cxx +++ b/svx/source/dialog/contwnd.cxx @@ -62,7 +62,7 @@ void ContourWindow::SetPolyPolygon(const tools::PolyPolygon& rPolyPoly) SdrPathObj* pPathObj = new SdrPathObj( *pModel, SdrObjKind::PathFill, - aPolyPolygon); + std::move(aPolyPolygon)); SfxItemSet aSet(pModel->GetItemPool()); diff --git a/svx/source/engine3d/dragmt3d.cxx b/svx/source/engine3d/dragmt3d.cxx index c27d9559875b..ef5a7b6904b4 100644 --- a/svx/source/engine3d/dragmt3d.cxx +++ b/svx/source/engine3d/dragmt3d.cxx @@ -259,7 +259,7 @@ void E3dDragMethod::CreateOverlayGeometry( { std::unique_ptr<sdr::overlay::OverlayPolyPolygonStripedAndFilled> pNew( new sdr::overlay::OverlayPolyPolygonStripedAndFilled( - aResult)); + std::move(aResult))); insertNewlyCreatedOverlayObjectForSdrDragMethod( std::move(pNew), diff --git a/svx/source/engine3d/extrud3d.cxx b/svx/source/engine3d/extrud3d.cxx index 3675b66a70a4..fadb645d3292 100644 --- a/svx/source/engine3d/extrud3d.cxx +++ b/svx/source/engine3d/extrud3d.cxx @@ -205,7 +205,7 @@ std::unique_ptr<SdrAttrObj,SdrObjectFreeOp> E3dExtrudeObj::GetBreakObj() { // create PathObj basegfx::B2DPolyPolygon aPoly = TransformToScreenCoor(aBackSide); - std::unique_ptr<SdrPathObj,SdrObjectFreeOp> pPathObj(new SdrPathObj(getSdrModelFromSdrObject(), SdrObjKind::PolyLine, aPoly)); + std::unique_ptr<SdrPathObj,SdrObjectFreeOp> pPathObj(new SdrPathObj(getSdrModelFromSdrObject(), SdrObjKind::PolyLine, std::move(aPoly))); SfxItemSet aSet(GetObjectItemSet()); aSet.Put(XLineStyleItem(css::drawing::LineStyle_SOLID)); diff --git a/svx/source/engine3d/lathe3d.cxx b/svx/source/engine3d/lathe3d.cxx index 1d8b4350c156..9e01fa4235a5 100644 --- a/svx/source/engine3d/lathe3d.cxx +++ b/svx/source/engine3d/lathe3d.cxx @@ -186,7 +186,7 @@ std::unique_ptr<SdrAttrObj,SdrObjectFreeOp> E3dLatheObj::GetBreakObj() // create PathObj basegfx::B3DPolyPolygon aLathePoly3D(basegfx::utils::createB3DPolyPolygonFromB2DPolyPolygon(maPolyPoly2D)); basegfx::B2DPolyPolygon aTransPoly(TransformToScreenCoor(aLathePoly3D)); - std::unique_ptr<SdrPathObj,SdrObjectFreeOp> pPathObj(new SdrPathObj(getSdrModelFromSdrObject(), SdrObjKind::PolyLine, aTransPoly)); + std::unique_ptr<SdrPathObj,SdrObjectFreeOp> pPathObj(new SdrPathObj(getSdrModelFromSdrObject(), SdrObjKind::PolyLine, std::move(aTransPoly))); // Set Attribute SfxItemSet aSet(GetObjectItemSet()); diff --git a/svx/source/engine3d/view3d.cxx b/svx/source/engine3d/view3d.cxx index 64a86bc89463..deebb7c27d46 100644 --- a/svx/source/engine3d/view3d.cxx +++ b/svx/source/engine3d/view3d.cxx @@ -189,7 +189,7 @@ void Impl3DMirrorConstructOverlay::SetMirrorAxis(Point aMirrorAxisA, Point aMirr aPolyPolygon.transform(aMatrixTransform); std::unique_ptr<sdr::overlay::OverlayPolyPolygonStripedAndFilled> pNew(new sdr::overlay::OverlayPolyPolygonStripedAndFilled( - aPolyPolygon)); + std::move(aPolyPolygon))); xTargetOverlay->add(*pNew); maObjects.append(std::move(pNew)); } @@ -742,7 +742,7 @@ void E3dView::ImpCreateSingle3DObjectFlat(E3dScene* pScene, SdrObject* pObj, boo aPolyPoly2D.transform(rLatheMat); // ctor E3dLatheObj expects coordinates with y-axis down aPolyPoly2D.transform(aFlipVerticalMat); - p3DObj = new E3dLatheObj(pObj->getSdrModelFromSdrObject(), aDefault, aPolyPoly2D); + p3DObj = new E3dLatheObj(pObj->getSdrModelFromSdrObject(), aDefault, std::move(aPolyPoly2D)); } // Set attribute diff --git a/svx/source/form/fmtextcontrolshell.cxx b/svx/source/form/fmtextcontrolshell.cxx index d97dfeb85d8e..2a7bc58ad89a 100644 --- a/svx/source/form/fmtextcontrolshell.cxx +++ b/svx/source/form/fmtextcontrolshell.cxx @@ -1257,7 +1257,7 @@ namespace svx } Reference< XDispatch > xDispatcher = _rxProvider->queryDispatch( aFeatureURL, OUString(), 0xFF ); if ( xDispatcher.is() ) - return new FmTextControlFeature( xDispatcher, aFeatureURL, _nSlot, this ); + return new FmTextControlFeature( xDispatcher, std::move(aFeatureURL), _nSlot, this ); return nullptr; } diff --git a/svx/source/mnuctrls/smarttagmenu.cxx b/svx/source/mnuctrls/smarttagmenu.cxx index 8d425836c386..3a78b5726bea 100644 --- a/svx/source/mnuctrls/smarttagmenu.cxx +++ b/svx/source/mnuctrls/smarttagmenu.cxx @@ -102,7 +102,7 @@ void SmartTagMenuController::statusChanged( const css::frame::FeatureStateEvent& else if ( aProperty.Name == "RangeText" ) aProperty.Value >>= aRangeText; } - m_pSmartTagItem.reset( new SvxSmartTagItem( TypedWhichId<SvxSmartTagItem>(0), aActionComponents, aActionIndices, aStringKeyMaps, xTextRange, xController, aLocale, aApplicationName, aRangeText ) ); + m_pSmartTagItem.reset( new SvxSmartTagItem( TypedWhichId<SvxSmartTagItem>(0), aActionComponents, aActionIndices, aStringKeyMaps, xTextRange, xController, std::move(aLocale), aApplicationName, aRangeText ) ); FillMenu(); } diff --git a/svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx b/svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx index 2e668b4dd579..daadd83c5942 100644 --- a/svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx +++ b/svx/source/sdr/contact/viewcontactofsdrcaptionobj.cxx @@ -81,7 +81,7 @@ namespace sdr::contact double fCornerRadiusY; drawinglayer::primitive2d::calculateRelativeCornerRadius( rCaptionObj.GetEckenradius(), aObjectRange, fCornerRadiusX, fCornerRadiusY); - const basegfx::B2DPolygon aTail(rCaptionObj.getTailPolygon()); + basegfx::B2DPolygon aTail(rCaptionObj.getTailPolygon()); // create primitive. Always create one (even if invisible) to let the decomposition // of SdrCaptionPrimitive2D create needed invisible elements for HitTest and BoundRect @@ -89,7 +89,7 @@ namespace sdr::contact new drawinglayer::primitive2d::SdrCaptionPrimitive2D( aObjectMatrix, aAttribute, - aTail, + std::move(aTail), fCornerRadiusX, fCornerRadiusY)); diff --git a/svx/source/sdr/contact/viewcontactofsdredgeobj.cxx b/svx/source/sdr/contact/viewcontactofsdredgeobj.cxx index ab95878568f5..a0e26c5bf2d7 100644 --- a/svx/source/sdr/contact/viewcontactofsdredgeobj.cxx +++ b/svx/source/sdr/contact/viewcontactofsdredgeobj.cxx @@ -38,7 +38,7 @@ namespace sdr::contact void ViewContactOfSdrEdgeObj::createViewIndependentPrimitive2DSequence(drawinglayer::primitive2d::Primitive2DDecompositionVisitor& rVisitor) const { - const basegfx::B2DPolygon aEdgeTrack(GetEdgeObj().getEdgeTrack()); + basegfx::B2DPolygon aEdgeTrack(GetEdgeObj().getEdgeTrack()); // what to do when no EdgeTrack is provided (HitTest and selectability) ? OSL_ENSURE(0 != aEdgeTrack.count(), "Connectors with no geometry are not allowed (!)"); @@ -56,7 +56,7 @@ namespace sdr::contact const drawinglayer::primitive2d::Primitive2DReference xReference( new drawinglayer::primitive2d::SdrConnectorPrimitive2D( aAttribute, - aEdgeTrack)); + std::move(aEdgeTrack))); rVisitor.visit(xReference); } diff --git a/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx b/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx index 8798d40fb70b..e2644489d6d1 100644 --- a/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx +++ b/svx/source/sdr/contact/viewcontactofsdrpathobj.cxx @@ -199,8 +199,8 @@ namespace sdr::contact new drawinglayer::primitive2d::SdrPathPrimitive2D( aObjectMatrix, aAttribute, - aUnitPolyPolygon, - aUnitDefinitionPolyPolygon)); + std::move(aUnitPolyPolygon), + std::move(aUnitDefinitionPolyPolygon))); rVisitor.visit(xReference); } diff --git a/svx/source/sdr/overlay/overlaytools.cxx b/svx/source/sdr/overlay/overlaytools.cxx index 6e29d9c0d235..d2f01adaa16c 100644 --- a/svx/source/sdr/overlay/overlaytools.cxx +++ b/svx/source/sdr/overlay/overlaytools.cxx @@ -81,7 +81,7 @@ void OverlayStaticRectanglePrimitive::create2DDecomposition(Primitive2DContainer // create fill primitive const Primitive2DReference aFill( - new PolyPolygonColorPrimitive2D(aPolyPolygon, maFillColor)); + new PolyPolygonColorPrimitive2D(std::move(aPolyPolygon), maFillColor)); aPrimitive2DSequence = Primitive2DContainer(2); aPrimitive2DSequence[0] = aFill; diff --git a/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx b/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx index 511f8ee025a2..1a5459643006 100644 --- a/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx +++ b/svx/source/sdr/primitive2d/sdrdecompositiontools.cxx @@ -515,7 +515,7 @@ sal_uInt32 SlideBackgroundFillPrimitive2D::getPrimitive2DID() const pNew = new SdrContourTextPrimitive2D( &rText.getSdrText(), rText.getOutlinerParaObject(), - aScaledUnitPolyPolygon, + std::move(aScaledUnitPolyPolygon), rObjectTransform); } else @@ -536,7 +536,7 @@ sal_uInt32 SlideBackgroundFillPrimitive2D::getPrimitive2DID() const pNew = new SdrPathTextPrimitive2D( &rText.getSdrText(), rText.getOutlinerParaObject(), - aScaledPolyPolygon, + std::move(aScaledPolyPolygon), rText.getSdrFormTextAttribute()); } else diff --git a/svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx b/svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx index 386800af663d..1d44b8fbf7db 100644 --- a/svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx +++ b/svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx @@ -327,7 +327,7 @@ namespace drawinglayer::primitive2d return new SdrPathTextPrimitive2D( getSdrText(), getOutlinerParaObject(), - aNewPolyPolygon, + std::move(aNewPolyPolygon), getSdrFormTextAttribute()); } diff --git a/svx/source/svdraw/svdcrtv.cxx b/svx/source/svdraw/svdcrtv.cxx index 9791df7ae9f2..e2a7f2e028e5 100644 --- a/svx/source/svdraw/svdcrtv.cxx +++ b/svx/source/svdraw/svdcrtv.cxx @@ -101,7 +101,7 @@ ImplConnectMarkerOverlay::ImplConnectMarkerOverlay(const SdrCreateView& rView, S aTempPolyPoly.append(aTempPoly); std::unique_ptr<sdr::overlay::OverlayPolyPolygonStripedAndFilled> pNew2(new sdr::overlay::OverlayPolyPolygonStripedAndFilled( - aTempPolyPoly)); + std::move(aTempPolyPoly))); xTargetOverlay->add(*pNew2); maObjects.append(std::move(pNew2)); } diff --git a/svx/source/svdraw/svddrgmt.cxx b/svx/source/svdraw/svddrgmt.cxx index 895a3d85bd96..2789f629398a 100644 --- a/svx/source/svdraw/svddrgmt.cxx +++ b/svx/source/svdraw/svddrgmt.cxx @@ -121,7 +121,7 @@ drawinglayer::primitive2d::Primitive2DContainer SdrDragEntryPolyPolygon::createP const double fTransparence(SvtOptionsDrawinglayer::GetTransparentSelectionPercent() * 0.01); aRetval[1] = new drawinglayer::primitive2d::PolyPolygonSelectionPrimitive2D( - aCopy, + std::move(aCopy), aHilightColor, fTransparence, 3.0, @@ -463,7 +463,7 @@ void SdrDragMethod::createSdrDragEntries_PolygonDrag() if(aResult.count()) { - addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(aResult))); + addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(std::move(aResult)))); } } @@ -1220,7 +1220,7 @@ void SdrDragObjOwn::createSdrDragEntries() if(aDragPolyPolygon.count()) { - addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(aDragPolyPolygon))); + addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(std::move(aDragPolyPolygon)))); } } @@ -2881,7 +2881,7 @@ void SdrDragCrook::createSdrDragEntries() if(aDragRaster.count()) { - addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(aDragRaster))); + addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(std::move(aDragRaster)))); } } @@ -3412,7 +3412,7 @@ void SdrDragDistort::createSdrDragEntries() if(aDragRaster.count()) { - addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(aDragRaster))); + addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new SdrDragEntryPolyPolygon(std::move(aDragRaster)))); } } diff --git a/svx/source/svdraw/svdedtv2.cxx b/svx/source/svdraw/svdedtv2.cxx index 50a7940ca752..dd00da880e48 100644 --- a/svx/source/svdraw/svdedtv2.cxx +++ b/svx/source/svdraw/svdedtv2.cxx @@ -1120,7 +1120,7 @@ void SdrEditView::MergeMarkedObjects(SdrMergeMode eMode) // #i73441# check insert list before taking actions if(pInsOL) { - SdrPathObj* pPath = new SdrPathObj(pAttrObj->getSdrModelFromSdrObject(), SdrObjKind::PathFill, aMergePolyPolygonA); + SdrPathObj* pPath = new SdrPathObj(pAttrObj->getSdrModelFromSdrObject(), SdrObjKind::PathFill, std::move(aMergePolyPolygonA)); ImpCopyAttributes(pAttrObj, pPath); pInsOL->InsertObject(pPath, nInsPos); if( bUndo ) @@ -1413,7 +1413,7 @@ void SdrEditView::CombineMarkedObjects(bool bNoPolyPoly) } } - SdrPathObj* pPath = new SdrPathObj(pAttrObj->getSdrModelFromSdrObject(), eKind, aPolyPolygon); + SdrPathObj* pPath = new SdrPathObj(pAttrObj->getSdrModelFromSdrObject(), eKind, std::move(aPolyPolygon)); // attributes of the lowest object ImpCopyAttributes(pAttrObj, pPath); diff --git a/svx/source/svdraw/svdfmtf.cxx b/svx/source/svdraw/svdfmtf.cxx index 659fae0908c9..6756e9626d58 100644 --- a/svx/source/svdraw/svdfmtf.cxx +++ b/svx/source/svdraw/svdfmtf.cxx @@ -991,7 +991,7 @@ void ImpSdrGDIMetaFileImport::DoAction(MetaPolyPolygonAction const & rAct) SdrPathObj* pPath = new SdrPathObj( *mpModel, SdrObjKind::Polygon, - aSource); + std::move(aSource)); SetAttributes(pPath); InsertObj(pPath, false); } @@ -1157,7 +1157,7 @@ void ImpSdrGDIMetaFileImport::DoAction( MetaHatchAction const & rAct ) SdrPathObj* pPath = new SdrPathObj( *mpModel, SdrObjKind::Polygon, - aSource); + std::move(aSource)); // #i125211# Use the ranges from the SdrObject to create a new empty SfxItemSet SfxItemSet aHatchAttr(mpModel->GetItemPool(), pPath->GetMergedItemSet().GetRanges()); css::drawing::HatchStyle eStyle; @@ -1248,7 +1248,7 @@ void ImpSdrGDIMetaFileImport::DoAction( MetaCommentAction const & rAct, GDIMetaF SdrPathObj* pPath = new SdrPathObj( *mpModel, SdrObjKind::Polygon, - aSource); + std::move(aSource)); // #i125211# Use the ranges from the SdrObject to create a new empty SfxItemSet SfxItemSet aGradAttr(mpModel->GetItemPool(), pPath->GetMergedItemSet().GetRanges()); XGradient aXGradient; @@ -1481,7 +1481,7 @@ void ImpSdrGDIMetaFileImport::DoAction(MetaTransparentAction const & rAct) SdrPathObj* pPath = new SdrPathObj( *mpModel, SdrObjKind::Polygon, - aSource); + std::move(aSource)); SetAttributes(pPath); pPath->SetMergedItem(XFillTransparenceItem(rAct.GetTransparence())); InsertObj(pPath, false); @@ -1504,7 +1504,7 @@ void ImpSdrGDIMetaFileImport::DoAction(MetaGradientExAction const & rAct) SdrPathObj* pPath = new SdrPathObj( *mpModel, SdrObjKind::Polygon, - aSource); + std::move(aSource)); // #i125211# Use the ranges from the SdrObject to create a new empty SfxItemSet SfxItemSet aGradientAttr(mpModel->GetItemPool(), pPath->GetMergedItemSet().GetRanges()); const css::awt::GradientStyle aXGradientStyle(getXGradientStyleFromGradientStyle(rGradient.GetStyle())); diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx index 0688688f1303..d503d68009ef 100644 --- a/svx/source/svdraw/svdobj.cxx +++ b/svx/source/svdraw/svdobj.cxx @@ -2454,7 +2454,7 @@ SdrObject* SdrObject::ImpConvertToContourObj(bool bForceLineDash) aLinePolygonPart = new SdrPathObj( getSdrModelFromSdrObject(), SdrObjKind::PathFill, - aMergedLineFillPolyPolygon); + std::move(aMergedLineFillPolyPolygon)); // correct item properties aSet.Put(XLineWidthItem(0)); @@ -2477,7 +2477,7 @@ SdrObject* SdrObject::ImpConvertToContourObj(bool bForceLineDash) aLineHairlinePart = new SdrPathObj( getSdrModelFromSdrObject(), SdrObjKind::PathLine, - aMergedHairlinePolyPolygon); + std::move(aMergedHairlinePolyPolygon)); aSet.Put(XLineWidthItem(0)); aSet.Put(XFillStyleItem(drawing::FillStyle_NONE)); diff --git a/svx/source/svdraw/svdotxtr.cxx b/svx/source/svdraw/svdotxtr.cxx index 7da067468abf..a9b2a6dbf476 100644 --- a/svx/source/svdraw/svdotxtr.cxx +++ b/svx/source/svdraw/svdotxtr.cxx @@ -366,7 +366,7 @@ SdrObjectUniquePtr SdrTextObj::ImpConvertContainedTextToSdrPathObjs(bool bToPoly pPathObj = new SdrPathObj( getSdrModelFromSdrObject(), SdrObjKind::PathLine, - aPolyPolygon); + std::move(aPolyPolygon)); } // copy basic information from original @@ -435,7 +435,7 @@ SdrPathObjUniquePtr SdrTextObj::ImpConvertMakeObj(const basegfx::B2DPolyPolygon& SdrPathObjUniquePtr pPathObj(new SdrPathObj( getSdrModelFromSdrObject(), ePathKind, - aB2DPolyPolygon)); + std::move(aB2DPolyPolygon))); if(bBezier) { diff --git a/svx/source/svdraw/svdpdf.cxx b/svx/source/svdraw/svdpdf.cxx index 9f9cd2c5a8de..13a75fddbb3a 100644 --- a/svx/source/svdraw/svdpdf.cxx +++ b/svx/source/svdraw/svdpdf.cxx @@ -1023,7 +1023,7 @@ void ImpSdrPdfImport::ImportPath(std::unique_ptr<vcl::pdf::PDFiumPageObject> con if (!mbLastObjWasPolyWithoutLine || !CheckLastPolyLineAndFillMerge(aPolyPoly)) { - SdrPathObj* pPath = new SdrPathObj(*mpModel, SdrObjKind::Polygon, aPolyPoly); + SdrPathObj* pPath = new SdrPathObj(*mpModel, SdrObjKind::Polygon, std::move(aPolyPoly)); SetAttributes(pPath); InsertObj(pPath, false); } diff --git a/svx/source/xoutdev/xattr.cxx b/svx/source/xoutdev/xattr.cxx index b85141dd16c5..d5a647d2cab7 100644 --- a/svx/source/xoutdev/xattr.cxx +++ b/svx/source/xoutdev/xattr.cxx @@ -1116,7 +1116,7 @@ std::unique_ptr<XLineStartItem> XLineStartItem::checkForUniqueItem( SdrModel* pM // force a closed polygon basegfx::B2DPolyPolygon aNew(maPolyPolygon); aNew.setClosed(true); - pTempItem.reset(new XLineStartItem( aUniqueName, aNew )); + pTempItem.reset(new XLineStartItem( aUniqueName, std::move(aNew) )); pLineStartItem = pTempItem.get(); } } @@ -1355,7 +1355,7 @@ std::unique_ptr<XLineEndItem> XLineEndItem::checkForUniqueItem( SdrModel* pModel // force a closed polygon basegfx::B2DPolyPolygon aNew(maPolyPolygon); aNew.setClosed(true); - pTempItem.reset(new XLineEndItem( aUniqueName, aNew )); + pTempItem.reset(new XLineEndItem( aUniqueName, std::move(aNew) )); pLineEndItem = pTempItem.get(); } } |