loplugin:checkunusedparams in svx(part4)

Change-Id: I032b49f4e1228ef275d7ff8d87ba969dcef687ab
Reviewed-on: https://gerrit.libreoffice.org/37248
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

26 files changed, 80 insertions, 87 deletions

diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index da6ad1357d8c..da7502ebf99c 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -178,7 +178,7 @@ drawing::Direction3D GetDirection3D( const SdrCustomShapeGeometryItem& rItem, co
 
 }
 
-EnhancedCustomShape3d::Transformation2D::Transformation2D( const SdrObject* pCustomShape, const tools::Rectangle& /*rBoundRect*/, const double *pM )
+EnhancedCustomShape3d::Transformation2D::Transformation2D( const SdrObject* pCustomShape, const double *pM )
     : aCenter( pCustomShape->GetSnapRect().Center() )
     , eProjectionMode( drawing::ProjectionMode_PARALLEL )
     , fSkewAngle(0.0)
@@ -781,7 +781,7 @@ tools::Rectangle EnhancedCustomShape3d::CalculateNewSnapRect( const SdrObject* p
     aMatrix.translate(aRotationCenter.DirectionX, aRotationCenter.DirectionY, aRotationCenter.DirectionZ);
     aBoundVolume.transform(aMatrix);
 
-    Transformation2D aTransformation2D( pCustomShape, rSnapRect, pMap );
+    Transformation2D aTransformation2D( pCustomShape, pMap );
     if ( aTransformation2D.IsParallel() )
         aBoundVolume = aTransformation2D.ApplySkewSettings( aBoundVolume );
 
diff --git a/svx/source/customshapes/EnhancedCustomShape3d.hxx b/svx/source/customshapes/EnhancedCustomShape3d.hxx
index 16b5ccffb2ce..8d774e3edf92 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.hxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.hxx
@@ -50,7 +50,7 @@ class EnhancedCustomShape3d
 
         public:
 
-                        Transformation2D( const SdrObject* pCustomShape, const tools::Rectangle& rBoundRect, const double* pMap );
+                        Transformation2D( const SdrObject* pCustomShape, const double* pMap );
 
             basegfx::B3DPolygon ApplySkewSettings( const basegfx::B3DPolygon& rPolygon3D ) const;
             Point       Transform2D( const basegfx::B3DPoint& rPoint ) const;
diff --git a/svx/source/dialog/SpellDialogChildWindow.cxx b/svx/source/dialog/SpellDialogChildWindow.cxx
index 6fb2e1f6cff5..4e1c4eda1cc8 100644
--- a/svx/source/dialog/SpellDialogChildWindow.cxx
+++ b/svx/source/dialog/SpellDialogChildWindow.cxx
@@ -27,8 +27,7 @@ namespace svx {
 SpellDialogChildWindow::SpellDialogChildWindow (
     vcl::Window* _pParent,
     sal_uInt16 nId,
-    SfxBindings* pBindings,
-    SfxChildWinInfo* /*pInfo*/)
+    SfxBindings* pBindings)
     : SfxChildWindow (_pParent, nId)
 {
     SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create();
diff --git a/svx/source/fmcomp/fmgridcl.cxx b/svx/source/fmcomp/fmgridcl.cxx
index cd52829e1bcb..51744355fa5a 100644
--- a/svx/source/fmcomp/fmgridcl.cxx
+++ b/svx/source/fmcomp/fmgridcl.cxx
@@ -1410,7 +1410,7 @@ void FmGridControl::DeleteSelectedRows()
 }
 
 // XCurrentRecordListener
-void FmGridControl::positioned(const css::lang::EventObject& /*rEvent*/)
+void FmGridControl::positioned()
 {
     SAL_INFO("svx.fmcomp", "FmGridControl::positioned");
     // position on the data source (force it to be done in the main thread)
@@ -1432,7 +1432,7 @@ bool FmGridControl::commit()
     return true;
 }
 
-void FmGridControl::inserted(const css::lang::EventObject& /*rEvent*/)
+void FmGridControl::inserted()
 {
     const DbGridRowRef& xRow = GetCurrentRow();
     if (!xRow.is())
@@ -1574,7 +1574,7 @@ void FmGridControl::ColumnMoved(sal_uInt16 nId)
         xColumns->insertByIndex(GetModelColumnPos(nId), aElement);
         pCol->setModel(xCol);
         // if the column which is shown here is selected ...
-        if ( isColumnSelected(nId,pCol) )
+        if ( isColumnSelected(pCol) )
             markColumn(nId); // ... -> mark it
     }
 
@@ -1745,7 +1745,7 @@ void FmGridControl::HideColumn(sal_uInt16 nId)
         m_nMarkedColumnId = (sal_uInt16)-1;
 }
 
-bool FmGridControl::isColumnSelected(sal_uInt16 /*nId*/,DbGridColumn* _pColumn)
+bool FmGridControl::isColumnSelected(DbGridColumn* _pColumn)
 {
     OSL_ENSURE(_pColumn,"Column can not be null!");
     bool bSelected = false;
@@ -1773,7 +1773,7 @@ void FmGridControl::ShowColumn(sal_uInt16 nId)
         GetPeer()->columnVisible(pColumn);
 
     // if the column which is shown here is selected ...
-    if ( isColumnSelected(nId,pColumn) )
+    if ( isColumnSelected(pColumn) )
         markColumn(nId); // ... -> mark it
 }
 
diff --git a/svx/source/fmcomp/fmgridif.cxx b/svx/source/fmcomp/fmgridif.cxx
index 1b2e19c29059..6f510bc8c9e4 100644
--- a/svx/source/fmcomp/fmgridif.cxx
+++ b/svx/source/fmcomp/fmgridif.cxx
@@ -1517,11 +1517,11 @@ void FmXGridPeer::cursorMoved(const EventObject& _rEvent)
     // we are not interested in move to insert row only in the resetted event
     // which is fired after positioning an the insert row
     if (pGrid && pGrid->IsOpen() && !::comphelper::getBOOL(Reference< XPropertySet > (_rEvent.Source, UNO_QUERY)->getPropertyValue(FM_PROP_ISNEW)))
-        pGrid->positioned(_rEvent);
+        pGrid->positioned();
 }
 
 
-void FmXGridPeer::rowChanged(const EventObject& _rEvent)
+void FmXGridPeer::rowChanged(const EventObject& /*_rEvent*/)
 {
     VclPtr< FmGridControl > pGrid = GetAs< FmGridControl >();
     if (pGrid && pGrid->IsOpen())
@@ -1529,7 +1529,7 @@ void FmXGridPeer::rowChanged(const EventObject& _rEvent)
         if (m_xCursor->rowUpdated() && !pGrid->IsCurrentAppending())
             pGrid->RowModified(pGrid->GetCurrentPos());
         else if (m_xCursor->rowInserted())
-            pGrid->inserted(_rEvent);
+            pGrid->inserted();
     }
 }
 
@@ -2646,7 +2646,7 @@ void FmXGridPeer::resetted(const EventObject& rEvent)
         SolarMutexGuard aGuard;
         VclPtr< FmGridControl > pGrid = GetAs< FmGridControl >();
         if (pGrid && pGrid->IsOpen())
-            pGrid->positioned(rEvent);
+            pGrid->positioned();
     }
 }
 
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 3f56ca90b3b9..f7da0e13f846 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -2960,7 +2960,7 @@ void DbFilterField::SetText(const OUString& rText)
     }
 
     // now force a repaint on the window
-    m_rColumn.GetParent().RowModified(0,m_rColumn.GetId());
+    m_rColumn.GetParent().RowModified(0);
 }
 
 
diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index b71767efeffa..5837920e2a3d 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -166,11 +166,11 @@ GridFieldValueListener::~GridFieldValueListener()
     dispose();
 }
 
-void GridFieldValueListener::_propertyChanged(const PropertyChangeEvent& _evt)
+void GridFieldValueListener::_propertyChanged(const PropertyChangeEvent& /*_evt*/)
 {
     DBG_ASSERT(m_nSuspended>=0, "GridFieldValueListener::_propertyChanged : resume > suspend !");
     if (m_nSuspended <= 0)
-        m_rParent.FieldValueChanged(m_nId, _evt);
+        m_rParent.FieldValueChanged(m_nId);
 }
 
 void GridFieldValueListener::dispose()
@@ -200,7 +200,7 @@ public:
     DisposeListenerGridBridge(  DbGridControl& _rParent, const Reference< XComponent >& _rxObject);
     virtual ~DisposeListenerGridBridge() override;
 
-    virtual void disposing(const EventObject& _rEvent, sal_Int16 _nId) override { m_rParent.disposing(_nId, _rEvent); }
+    virtual void disposing(const EventObject& /*_rEvent*/, sal_Int16 _nId) override { m_rParent.disposing(_nId); }
 };
 
 DisposeListenerGridBridge::DisposeListenerGridBridge(DbGridControl& _rParent, const Reference< XComponent >& _rxObject)
@@ -3082,7 +3082,7 @@ void DbGridControl::resetCurrentRow()
     RowModified(GetCurRow()); // will update the current controller if affected
 }
 
-void DbGridControl::RowModified( long nRow, sal_uInt16 /*nColId*/ )
+void DbGridControl::RowModified( long nRow )
 {
     if (nRow == m_nCurrentPos && IsEditing())
     {
@@ -3573,7 +3573,7 @@ void DbGridControl::DisconnectFromFields()
     m_pFieldListeners = nullptr;
 }
 
-void DbGridControl::FieldValueChanged(sal_uInt16 _nId, const PropertyChangeEvent& /*_evt*/)
+void DbGridControl::FieldValueChanged(sal_uInt16 _nId)
 {
     osl::MutexGuard aPreventDestruction(m_aDestructionSafety);
     // needed as this may run in a thread other than the main one
@@ -3598,7 +3598,7 @@ void DbGridControl::FieldValueChanged(sal_uInt16 _nId, const PropertyChangeEvent
 
         // and finally do the update ...
         pColumn->UpdateFromField(m_xCurrentRow.get(), m_xFormatter);
-        RowModified(GetCurRow(), _nId);
+        RowModified(GetCurRow());
     }
 }
 
@@ -3623,7 +3623,7 @@ void DbGridControl::FieldListenerDisposing(sal_uInt16 _nId)
     pListeners->erase(aPos);
 }
 
-void DbGridControl::disposing(sal_uInt16 _nId, const EventObject& /*_rEvt*/)
+void DbGridControl::disposing(sal_uInt16 _nId)
 {
     if (_nId == 0)
     {   // the seek cursor is being disposed
diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx
index 039be85edc82..ce711538b8df 100644
--- a/svx/source/form/fmshimp.cxx
+++ b/svx/source/form/fmshimp.cxx
@@ -2785,7 +2785,7 @@ void FmXFormShell::SetDesignMode(bool bDesign)
     m_pShell->m_bDesignMode = bDesign;
     UpdateForms( false );
 
-    m_pTextShell->designModeChanged( m_pShell->m_bDesignMode );
+    m_pTextShell->designModeChanged();
 
     if (bDesign)
     {
diff --git a/svx/source/form/fmtextcontrolshell.cxx b/svx/source/form/fmtextcontrolshell.cxx
index 724a831188b8..466f25003ce0 100644
--- a/svx/source/form/fmtextcontrolshell.cxx
+++ b/svx/source/form/fmtextcontrolshell.cxx
@@ -1029,7 +1029,7 @@ namespace svx
     }
 
 
-    void FmTextControlShell::designModeChanged( bool /*_bNewDesignMode*/ )
+    void FmTextControlShell::designModeChanged()
     {
         m_rBindings.Invalidate( pTextControlSlots );
     }
diff --git a/svx/source/inc/fmtextcontrolshell.hxx b/svx/source/inc/fmtextcontrolshell.hxx
index 76c87c64f468..7ae1a8f0bb2d 100644
--- a/svx/source/inc/fmtextcontrolshell.hxx
+++ b/svx/source/inc/fmtextcontrolshell.hxx
@@ -133,7 +133,7 @@ namespace svx
 
         /** notifies the instance that the design mode has changed
         */
-        void    designModeChanged( bool _bNewDesignMode );
+        void    designModeChanged();
 
         void    Invalidate( SfxSlotId _nSlot );
 
diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
index 7e19f32dfac4..90140dfdb894 100644
--- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
+++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
@@ -1370,8 +1370,7 @@ IMPL_LINK_NOARG(AreaPropertyPanelBase, ChangeTrgrTypeHdl_Impl, ListBox&, void)
             break;
     }
 
-    SfxItemPool* pPool = nullptr;
-    const XFillFloatTransparenceItem aGradientItem(pPool, aTmpGradient, bGradient);
+    const XFillFloatTransparenceItem aGradientItem(aTmpGradient, bGradient);
     setFillFloatTransparence(aGradientItem);
 }
 
diff --git a/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx b/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx
index f05087ec039f..ca5e5139aa1a 100644
--- a/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx
+++ b/svx/source/sidebar/area/AreaTransparencyGradientPopup.cxx
@@ -135,9 +135,8 @@ void AreaTransparencyGradientPopup::ExecuteValueModify(sal_uInt8 nStartCol, sal_
 
     mrAreaPropertyPanel.SetGradient(aTmpGradient);
 
-    SfxItemPool* pPool = nullptr;
     bool bEnable = true;
-    XFillFloatTransparenceItem aGradientItem(pPool, aTmpGradient, bEnable );
+    XFillFloatTransparenceItem aGradientItem(aTmpGradient, bEnable );
 
     mrAreaPropertyPanel.setFillFloatTransparence(aGradientItem);
 }
diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx
index 5ec8863f837d..ef308e354797 100644
--- a/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx
+++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.cxx
@@ -81,7 +81,7 @@ void ParaPropertyPanel::HandleContextChange (
             mpTBxVertAlign->Show();
             mpTBxBackColor->Hide();
             mpTBxNumBullet->Hide();
-            ReSize(false);
+            ReSize();
             break;
 
         case CombinedEnumContext(Application::DrawImpress, Context::Draw):
@@ -92,7 +92,7 @@ void ParaPropertyPanel::HandleContextChange (
             mpTBxVertAlign->Show();
             mpTBxBackColor->Hide();
             mpTBxNumBullet->Show();
-            ReSize(true);
+            ReSize();
             break;
 
         case CombinedEnumContext(Application::WriterVariants, Context::Default):
@@ -100,21 +100,21 @@ void ParaPropertyPanel::HandleContextChange (
             mpTBxVertAlign->Hide();
             mpTBxBackColor->Show();
             mpTBxNumBullet->Show();
-            ReSize(true);
+            ReSize();
             break;
 
         case CombinedEnumContext(Application::WriterVariants, Context::Table):
             mpTBxVertAlign->Show();
             mpTBxBackColor->Show();
             mpTBxNumBullet->Show();
-            ReSize(true);
+            ReSize();
             break;
 
         case CombinedEnumContext(Application::WriterVariants, Context::Annotation):
             mpTBxVertAlign->Hide();
             mpTBxBackColor->Hide();
             mpTBxNumBullet->Hide();
-            ReSize(false);
+            ReSize();
             break;
 
         case CombinedEnumContext(Application::Calc, Context::EditCell):
@@ -136,7 +136,7 @@ void ParaPropertyPanel::DataChanged (const DataChangedEvent& rEvent)
     (void)rEvent;
 }
 
-void ParaPropertyPanel::ReSize(bool /* bSize */)
+void ParaPropertyPanel::ReSize()
 {
     if (mxSidebar.is())
         mxSidebar->requestLayout();
@@ -220,16 +220,16 @@ void ParaPropertyPanel::NotifyItemUpdate(
         break;
 
     case SID_ATTR_PARA_LRSPACE:
-        StateChangedIndentImpl( nSID, eState, pState );
+        StateChangedIndentImpl( eState, pState );
         break;
 
     case SID_ATTR_PARA_ULSPACE:
-        StateChangedULImpl( nSID, eState, pState );
+        StateChangedULImpl( eState, pState );
         break;
     }
 }
 
-void ParaPropertyPanel::StateChangedIndentImpl( sal_uInt16 /*nSID*/, SfxItemState eState, const SfxPoolItem* pState )
+void ParaPropertyPanel::StateChangedIndentImpl( SfxItemState eState, const SfxPoolItem* pState )
 {
     switch (maContext.GetCombinedContext_DI())
     {
@@ -333,7 +333,7 @@ void ParaPropertyPanel::StateChangedIndentImpl( sal_uInt16 /*nSID*/, SfxItemStat
     }
 }
 
-void ParaPropertyPanel::StateChangedULImpl( sal_uInt16 /*nSID*/, SfxItemState eState, const SfxPoolItem* pState )
+void ParaPropertyPanel::StateChangedULImpl( SfxItemState eState, const SfxPoolItem* pState )
 {
     mpTopDist->SetMax( mpTopDist->Normalize( MAX_DURCH ), MapToFieldUnit(m_eULSpaceUnit) );
     mpBottomDist->SetMax( mpBottomDist->Normalize( MAX_DURCH ), MapToFieldUnit(m_eULSpaceUnit) );
diff --git a/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx b/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
index 98ce983c4ed7..915ec39f1d14 100644
--- a/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
+++ b/svx/source/sidebar/paragraph/ParaPropertyPanel.hxx
@@ -108,11 +108,11 @@ private:
     DECL_LINK(ModifyIndentHdl_Impl, Edit&, void);
     DECL_LINK(ULSpaceHdl_Impl, Edit&, void);
 
-    void StateChangedIndentImpl( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState );
-    void StateChangedULImpl( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState );
+    void StateChangedIndentImpl( SfxItemState eState, const SfxPoolItem* pState );
+    void StateChangedULImpl( SfxItemState eState, const SfxPoolItem* pState );
 
     void initial();
-    void ReSize(bool bSize);
+    void ReSize();
     void InitToolBoxIndent();
     void InitToolBoxSpacing();
 };
diff --git a/svx/source/svdraw/svddrgv.cxx b/svx/source/svdraw/svddrgv.cxx
index 7feb11c33959..2c4d78762e03 100644
--- a/svx/source/svdraw/svddrgv.cxx
+++ b/svx/source/svdraw/svddrgv.cxx
@@ -627,7 +627,7 @@ bool SdrDragView::IsInsObjPointPossible() const
     return mpMarkedObj!=nullptr && mpMarkedObj->IsPolyObj();
 }
 
-bool SdrDragView::ImpBegInsObjPoint(bool bIdxZwang, sal_uInt32 /*nIdx*/, const Point& rPnt, bool bNewObj, OutputDevice* pOut)
+bool SdrDragView::ImpBegInsObjPoint(bool bIdxZwang, const Point& rPnt, bool bNewObj, OutputDevice* pOut)
 {
     bool bRet(false);
 
@@ -694,13 +694,12 @@ bool SdrDragView::EndInsObjPoint(SdrCreateCmd eCmd)
 {
     if(IsInsObjPoint())
     {
-        sal_uInt32 nNextPnt(mnInsPointNum);
         Point aPnt(maDragStat.GetNow());
         bool bOk=EndDragObj();
         if (bOk && eCmd!=SdrCreateCmd::ForceEnd)
         {
             // Ret=True means: Action is over.
-            bOk=!(ImpBegInsObjPoint(true, nNextPnt, aPnt, eCmd == SdrCreateCmd::NextObject, mpDragWin));
+            bOk = ! ImpBegInsObjPoint(true, aPnt, eCmd == SdrCreateCmd::NextObject, mpDragWin);
         }
 
         return bOk;
diff --git a/svx/source/svdraw/svdfmtf.cxx b/svx/source/svdraw/svdfmtf.cxx
index d0d6be8d9dd5..104e0bb47892 100644
--- a/svx/source/svdraw/svdfmtf.cxx
+++ b/svx/source/svdraw/svdfmtf.cxx
@@ -1150,7 +1150,7 @@ void ImpSdrGDIMetaFileImport::DoAction( MetaHatchAction& rAct )
 
             SetAttributes(pPath);
             aHatchAttr.Put(XFillStyleItem(drawing::FillStyle_HATCH));
-            aHatchAttr.Put(XFillHatchItem(&mpModel->GetItemPool(), XHatch(rHatch.GetColor(), eStyle, rHatch.GetDistance(), rHatch.GetAngle())));
+            aHatchAttr.Put(XFillHatchItem(XHatch(rHatch.GetColor(), eStyle, rHatch.GetDistance(), rHatch.GetAngle())));
             pPath->SetMergedItemSet(aHatchAttr);
 
             InsertObj(pPath, false);
diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 0925ee583a62..f612e2e6304c 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -337,7 +337,7 @@ SdrObject* ImpCreateShadowObjectClone(const SdrObject& rOriginal, const SfxItemS
         {
             XHatch aHatch(static_cast<const XFillHatchItem&>(rOriginalSet.Get(XATTR_FILLHATCH)).GetHatchValue());
             aHatch.SetColor(aShadowColor);
-            aTempSet.Put(XFillHatchItem(aTempSet.GetPool(), aHatch));
+            aTempSet.Put(XFillHatchItem(aHatch));
             aTempSet.Put(XFillTransparenceItem(nShadowTransparence));
         }
 
@@ -395,7 +395,7 @@ SdrObject* ImpCreateShadowObjectClone(const SdrObject& rOriginal, const SfxItemS
                 }
             }
 
-            aTempSet.Put(XFillBitmapItem(aTempSet.GetPool(), aGraphicObject));
+            aTempSet.Put(XFillBitmapItem(aGraphicObject));
             aTempSet.Put(XFillTransparenceItem(nShadowTransparence));
         }
 
diff --git a/svx/source/svdraw/svdotxln.cxx b/svx/source/svdraw/svdotxln.cxx
index 5568347090a5..cff5b03aae4c 100644
--- a/svx/source/svdraw/svdotxln.cxx
+++ b/svx/source/svdraw/svdotxln.cxx
@@ -186,7 +186,7 @@ bool SdrTextObj::ReloadLinkedText( bool bForceLoad)
 
             if( bLoad )
             {
-                bRet = LoadText( pData->aFileName, pData->aFilterName, pData->eCharSet );
+                bRet = LoadText( pData->aFileName, pData->eCharSet );
             }
 
             pData->aFileDate0 = aFileDT;
@@ -196,7 +196,7 @@ bool SdrTextObj::ReloadLinkedText( bool bForceLoad)
     return bRet;
 }
 
-bool SdrTextObj::LoadText(const OUString& rFileName, const OUString& /*rFilterName*/, rtl_TextEncoding eCharSet)
+bool SdrTextObj::LoadText(const OUString& rFileName, rtl_TextEncoding eCharSet)
 {
     INetURLObject   aFileURL( rFileName );
     bool            bRet = false;
diff --git a/svx/source/svdraw/svdpntv.cxx b/svx/source/svdraw/svdpntv.cxx
index 85f5c4648ebf..b24b96f7222b 100644
--- a/svx/source/svdraw/svdpntv.cxx
+++ b/svx/source/svdraw/svdpntv.cxx
@@ -978,7 +978,7 @@ bool SdrPaintView::IsGroupEntered() const
     return false;
 }
 
-void SdrPaintView::SetNotPersistDefaultAttr(const SfxItemSet& rAttr, bool /*bReplaceAll*/)
+void SdrPaintView::SetNotPersistDefaultAttr(const SfxItemSet& rAttr)
 {
     // bReplaceAll has no effect here at all.
     bool bMeasure= dynamic_cast<const SdrView*>(this) != nullptr && static_cast<SdrView*>(this)->IsMeasureTool();
@@ -997,7 +997,7 @@ void SdrPaintView::SetNotPersistDefaultAttr(const SfxItemSet& rAttr, bool /*bRep
     }
 }
 
-void SdrPaintView::MergeNotPersistDefaultAttr(SfxItemSet& rAttr, bool /*bOnlyHardAttr*/) const
+void SdrPaintView::MergeNotPersistDefaultAttr(SfxItemSet& rAttr) const
 {
     // bOnlyHardAttr has no effect here at all.
     bool bMeasure= dynamic_cast<const SdrView*>(this) != nullptr && static_cast<const SdrView*>(this)->IsMeasureTool();
@@ -1033,7 +1033,7 @@ void SdrPaintView::SetDefaultAttr(const SfxItemSet& rAttr, bool bReplaceAll)
 #endif
     if (bReplaceAll) maDefaultAttr.Set(rAttr);
     else maDefaultAttr.Put(rAttr,false); // if FALSE, regard InvalidItems as "holes," not as Default
-    SetNotPersistDefaultAttr(rAttr,bReplaceAll);
+    SetNotPersistDefaultAttr(rAttr);
 #ifdef DBG_UTIL
     if (mpItemBrowser!=nullptr) mpItemBrowser->SetDirty();
 #endif
@@ -1074,7 +1074,7 @@ bool SdrPaintView::GetAttributes(SfxItemSet& rTargetSet, bool bOnlyHardAttr) con
         rTargetSet.Put(mpDefaultStyleSheet->GetItemSet(), false);
         rTargetSet.Put(maDefaultAttr, false);
     }
-    MergeNotPersistDefaultAttr(rTargetSet, bOnlyHardAttr);
+    MergeNotPersistDefaultAttr(rTargetSet);
     return true;
 }
 
@@ -1217,20 +1217,17 @@ void SdrPaintView::VisAreaChanged(const OutputDevice* pOut)
 
             if(pWindow)
             {
-                VisAreaChanged(*pWindow);
+                VisAreaChanged();
             }
         }
         else
         {
-            for(sal_uInt32 a(0L); a < mpPageView->PageWindowCount(); a++)
-            {
-                VisAreaChanged(*mpPageView->GetPageWindow(a));
-            }
+            VisAreaChanged();
         }
     }
 }
 
-void SdrPaintView::VisAreaChanged(const SdrPageWindow& /*rWindow*/)
+void SdrPaintView::VisAreaChanged()
 {
     // notify SfxListener
     Broadcast(SvxViewChangedHint());
diff --git a/svx/source/table/svdotable.cxx b/svx/source/table/svdotable.cxx
index 1e44e1f23e09..4c51d4149465 100644
--- a/svx/source/table/svdotable.cxx
+++ b/svx/source/table/svdotable.cxx
@@ -201,7 +201,7 @@ public:
     std::vector<std::unique_ptr<SdrUndoAction>> maUndos;
     bool mbSkipChangeLayout;
 
-    void SetModel(SdrModel* pOldModel, SdrModel* pNewModel);
+    void SetModel(SdrModel* pNewModel);
 
     CellRef getCell( const CellPos& rPos ) const;
     void LayoutTable( tools::Rectangle& rArea, bool bFitWidth, bool bFitHeight );
@@ -323,7 +323,7 @@ SdrTableObjImpl& SdrTableObjImpl::operator=( const SdrTableObjImpl& rSource )
 }
 
 
-void SdrTableObjImpl::SetModel(SdrModel* /*pOldModel*/, SdrModel* pNewModel)
+void SdrTableObjImpl::SetModel(SdrModel* pNewModel)
 {
     // try to find new table style
     disconnectTableStyle();
@@ -1369,7 +1369,7 @@ void SdrTableObj::SetModel(SdrModel* pNewModel)
 
         if( mpImpl.is() )
         {
-            mpImpl->SetModel( pOldModel, pNewModel );
+            mpImpl->SetModel( pNewModel );
 
             if( !maLogicRect.IsEmpty() )
             {
@@ -1381,14 +1381,14 @@ void SdrTableObj::SetModel(SdrModel* pNewModel)
 }
 
 
-void SdrTableObj::TakeTextRect( SdrOutliner& rOutliner, tools::Rectangle& rTextRect, bool bNoEditText, tools::Rectangle* pAnchorRect, bool bLineWidth ) const
+void SdrTableObj::TakeTextRect( SdrOutliner& rOutliner, tools::Rectangle& rTextRect, bool bNoEditText, tools::Rectangle* pAnchorRect, bool /*bLineWidth*/ ) const
 {
     if( mpImpl.is() )
-        TakeTextRect( mpImpl->maEditPos, rOutliner, rTextRect, bNoEditText, pAnchorRect, bLineWidth );
+        TakeTextRect( mpImpl->maEditPos, rOutliner, rTextRect, bNoEditText, pAnchorRect );
 }
 
 
-void SdrTableObj::TakeTextRect( const CellPos& rPos, SdrOutliner& rOutliner, tools::Rectangle& rTextRect, bool bNoEditText, tools::Rectangle* pAnchorRect, bool /*bLineWidth*/ ) const
+void SdrTableObj::TakeTextRect( const CellPos& rPos, SdrOutliner& rOutliner, tools::Rectangle& rTextRect, bool bNoEditText, tools::Rectangle* pAnchorRect ) const
 {
     if( !mpImpl.is())
         return;
diff --git a/svx/source/table/tablecontroller.cxx b/svx/source/table/tablecontroller.cxx
index c21432de3cb8..47ca6dbcd5ad 100644
--- a/svx/source/table/tablecontroller.cxx
+++ b/svx/source/table/tablecontroller.cxx
@@ -237,7 +237,7 @@ bool SvxTableController::onKeyInput(const KeyEvent& rKEvt, vcl::Window* pWindow
         }
     }
 
-    TblAction nAction = getKeyboardAction(rKEvt, pWindow);
+    TblAction nAction = getKeyboardAction(rKEvt);
 
     return executeAction( nAction, rKEvt.GetKeyCode().IsShift(), pWindow );
 }
@@ -1447,7 +1447,7 @@ bool SvxTableController::checkTableObject()
 }
 
 
-SvxTableController::TblAction SvxTableController::getKeyboardAction(const KeyEvent& rKEvt, vcl::Window* /*pWindow*/)
+SvxTableController::TblAction SvxTableController::getKeyboardAction(const KeyEvent& rKEvt)
 {
     const bool bMod1 = rKEvt.GetKeyCode().IsMod1(); // ctrl
     const bool bMod2 = rKEvt.GetKeyCode().IsMod2(); // Alt
diff --git a/svx/source/tbxctrls/fontworkgallery.cxx b/svx/source/tbxctrls/fontworkgallery.cxx
index ec20d84df027..3c9d23c959c4 100644
--- a/svx/source/tbxctrls/fontworkgallery.cxx
+++ b/svx/source/tbxctrls/fontworkgallery.cxx
@@ -68,7 +68,7 @@ namespace svx
 const int nColCount = 4;
 const int nLineCount = 4;
 
-FontWorkGalleryDialog::FontWorkGalleryDialog( SdrView* pSdrView, vcl::Window* pParent, sal_uInt16 /*nSID*/ ) :
+FontWorkGalleryDialog::FontWorkGalleryDialog( SdrView* pSdrView, vcl::Window* pParent ) :
         ModalDialog(pParent, "FontworkGalleryDialog", "svx/ui/fontworkgallerydialog.ui" ),
         mnThemeId           ( 0xffff ),
         mpSdrView           ( pSdrView ),
@@ -422,7 +422,7 @@ private:
     DECL_LINK( SelectHdl, ToolbarMenu*, void );
 
     void    implSetCharacterSpacing( sal_Int32 nCharacterSpacing, bool bEnabled );
-    void    implSetKernCharacterPairs( bool bKernOnOff, bool bEnabled );
+    void    implSetKernCharacterPairs( bool bEnabled );
 
 };
 
@@ -474,7 +474,7 @@ void FontworkCharacterSpacingWindow::implSetCharacterSpacing( sal_Int32 nCharact
 }
 
 
-void FontworkCharacterSpacingWindow::implSetKernCharacterPairs( bool, bool bEnabled )
+void FontworkCharacterSpacingWindow::implSetKernCharacterPairs( bool bEnabled )
 {
     enableEntry( 6, bEnabled );
     checkEntry( 6, bEnabled );
@@ -500,13 +500,13 @@ void FontworkCharacterSpacingWindow::statusChanged( const css::frame::FeatureSta
     {
         if( !Event.IsEnabled )
         {
-            implSetKernCharacterPairs( false, false );
+            implSetKernCharacterPairs( false );
         }
         else
         {
             bool bValue = false;
             if( Event.State >>= bValue )
-                implSetKernCharacterPairs( bValue, true );
+                implSetKernCharacterPairs( true );
         }
     }
 }
@@ -544,7 +544,7 @@ IMPL_LINK_NOARG(FontworkCharacterSpacingWindow, SelectHdl,ToolbarMenu*, void)
 
         mrController.dispatchCommand( msFontworkKernCharacterPairs, aArgs );
 
-        implSetKernCharacterPairs( true, true );
+        implSetKernCharacterPairs( true );
     }
     else if( nSelection >= 0 )
     {
diff --git a/svx/source/toolbars/fontworkbar.cxx b/svx/source/toolbars/fontworkbar.cxx
index fbcd1003de73..ec473f4b5e9e 100644
--- a/svx/source/toolbars/fontworkbar.cxx
+++ b/svx/source/toolbars/fontworkbar.cxx
@@ -424,7 +424,7 @@ void FontworkBar::execute( SdrView* pSdrView, SfxRequest& rReq, SfxBindings& rBi
     {
         case SID_FONTWORK_GALLERY_FLOATER:
         {
-            ScopedVclPtrInstance< FontWorkGalleryDialog > aDlg( pSdrView, ImpGetViewWin(pSdrView), nSID );
+            ScopedVclPtrInstance< FontWorkGalleryDialog > aDlg( pSdrView, ImpGetViewWin(pSdrView) );
             aDlg->Execute();
         }
         break;
diff --git a/svx/source/xoutdev/xattr.cxx b/svx/source/xoutdev/xattr.cxx
index 2b9126ca8746..eb8afb7d5532 100644
--- a/svx/source/xoutdev/xattr.cxx
+++ b/svx/source/xoutdev/xattr.cxx
@@ -680,7 +680,7 @@ XLineDashItem::XLineDashItem(SvStream& rIn) :
     }
 }
 
-XLineDashItem::XLineDashItem(SfxItemPool* /*pPool*/, const XDash& rTheDash)
+XLineDashItem::XLineDashItem(const XDash& rTheDash)
 :   NameOrIndex( XATTR_LINEDASH, -1 ),
     aDash(rTheDash)
 {
@@ -1249,7 +1249,7 @@ XLineStartItem::XLineStartItem(SvStream& rIn) :
     }
 }
 
-XLineStartItem::XLineStartItem(SfxItemPool* /*pPool*/, const basegfx::B2DPolyPolygon& rPolyPolygon)
+XLineStartItem::XLineStartItem(const basegfx::B2DPolyPolygon& rPolyPolygon)
 :   NameOrIndex( XATTR_LINESTART, -1 ),
     maPolyPolygon(rPolyPolygon)
 {
@@ -1592,7 +1592,7 @@ XLineEndItem::XLineEndItem(SvStream& rIn) :
     }
 }
 
-XLineEndItem::XLineEndItem(SfxItemPool* /*pPool*/, const basegfx::B2DPolyPolygon& rPolyPolygon)
+XLineEndItem::XLineEndItem(const basegfx::B2DPolyPolygon& rPolyPolygon)
 :   NameOrIndex( XATTR_LINEEND, -1 ),
     maPolyPolygon(rPolyPolygon)
 {
@@ -2768,7 +2768,7 @@ XFillFloatTransparenceItem::XFillFloatTransparenceItem( const XFillFloatTranspar
     SetWhich( XATTR_FILLFLOATTRANSPARENCE );
 }
 
-XFillFloatTransparenceItem::XFillFloatTransparenceItem(SfxItemPool* /*pPool*/, const XGradient& rTheGradient, bool bEnable )
+XFillFloatTransparenceItem::XFillFloatTransparenceItem(const XGradient& rTheGradient, bool bEnable )
 :   XFillGradientItem   ( -1, rTheGradient ),
     bEnabled            ( bEnable )
 {
@@ -2910,7 +2910,7 @@ XFillHatchItem::XFillHatchItem(SvStream& rIn) :
     }
 }
 
-XFillHatchItem::XFillHatchItem(SfxItemPool* /*pPool*/, const XHatch& rTheHatch)
+XFillHatchItem::XFillHatchItem(const XHatch& rTheHatch)
 :   NameOrIndex( XATTR_FILLHATCH, -1 ),
     aHatch(rTheHatch)
 {
diff --git a/svx/source/xoutdev/xattrbmp.cxx b/svx/source/xoutdev/xattrbmp.cxx
index 519a10a40963..a1dc1b56685c 100644
--- a/svx/source/xoutdev/xattrbmp.cxx
+++ b/svx/source/xoutdev/xattrbmp.cxx
@@ -271,7 +271,7 @@ XFillBitmapItem::XFillBitmapItem(SvStream& rIn, sal_uInt16 nVer)
     }
 }
 
-XFillBitmapItem::XFillBitmapItem(SfxItemPool* /*pPool*/, const GraphicObject& rGraphicObject)
+XFillBitmapItem::XFillBitmapItem(const GraphicObject& rGraphicObject)
 :   NameOrIndex( XATTR_FILLBITMAP, -1),
     maGraphicObject(rGraphicObject)
 {
diff --git a/svx/source/xoutdev/xpool.cxx b/svx/source/xoutdev/xpool.cxx
index d1dc85aed859..ff064151105b 100644
--- a/svx/source/xoutdev/xpool.cxx
+++ b/svx/source/xoutdev/xpool.cxx
@@ -60,11 +60,11 @@ XOutdevItemPool::XOutdevItemPool(SfxItemPool* _pMaster, bool bLoadRefCounts)
     // prepare PoolDefaults
     std::vector<SfxPoolItem*>& rPoolDefaults = *mpLocalPoolDefaults;
     rPoolDefaults[XATTR_LINESTYLE          -XATTR_START] = new XLineStyleItem;
-    rPoolDefaults[XATTR_LINEDASH           -XATTR_START] = new XLineDashItem(this,aNullDash);
+    rPoolDefaults[XATTR_LINEDASH           -XATTR_START] = new XLineDashItem(aNullDash);
     rPoolDefaults[XATTR_LINEWIDTH          -XATTR_START] = new XLineWidthItem;
     rPoolDefaults[XATTR_LINECOLOR          -XATTR_START] = new XLineColorItem(aNullStr,aNullLineCol);
-    rPoolDefaults[XATTR_LINESTART          -XATTR_START] = new XLineStartItem(this,aNullPol);
-    rPoolDefaults[XATTR_LINEEND            -XATTR_START] = new XLineEndItem  (this,aNullPol);
+    rPoolDefaults[XATTR_LINESTART          -XATTR_START] = new XLineStartItem(aNullPol);
+    rPoolDefaults[XATTR_LINEEND            -XATTR_START] = new XLineEndItem  (aNullPol);
     rPoolDefaults[XATTR_LINESTARTWIDTH     -XATTR_START] = new XLineStartWidthItem;
     rPoolDefaults[XATTR_LINEENDWIDTH       -XATTR_START] = new XLineEndWidthItem;
     rPoolDefaults[XATTR_LINESTARTCENTER    -XATTR_START] = new XLineStartCenterItem;
@@ -75,8 +75,8 @@ XOutdevItemPool::XOutdevItemPool(SfxItemPool* _pMaster, bool bLoadRefCounts)
     rPoolDefaults[XATTR_FILLSTYLE                -XATTR_START] = new XFillStyleItem;
     rPoolDefaults[XATTR_FILLCOLOR                -XATTR_START] = new XFillColorItem   (aNullStr,aNullFillCol);
     rPoolDefaults[XATTR_FILLGRADIENT         -XATTR_START] = new XFillGradientItem(aNullGrad);
-    rPoolDefaults[XATTR_FILLHATCH                -XATTR_START] = new XFillHatchItem   (this,aNullHatch);
-    rPoolDefaults[XATTR_FILLBITMAP               -XATTR_START] = new XFillBitmapItem  (this, aNullGraphic);
+    rPoolDefaults[XATTR_FILLHATCH                -XATTR_START] = new XFillHatchItem   (aNullHatch);
+    rPoolDefaults[XATTR_FILLBITMAP               -XATTR_START] = new XFillBitmapItem  (aNullGraphic);
     rPoolDefaults[XATTR_FILLTRANSPARENCE     -XATTR_START] = new XFillTransparenceItem;
     rPoolDefaults[XATTR_GRADIENTSTEPCOUNT        -XATTR_START] = new XGradientStepCountItem;
     rPoolDefaults[XATTR_FILLBMP_TILE         -XATTR_START] = new XFillBmpTileItem;
@@ -89,7 +89,7 @@ XOutdevItemPool::XOutdevItemPool(SfxItemPool* _pMaster, bool bLoadRefCounts)
     rPoolDefaults[XATTR_FILLBMP_STRETCH      -XATTR_START] = new XFillBmpStretchItem;
     rPoolDefaults[XATTR_FILLBMP_POSOFFSETX       -XATTR_START] = new XFillBmpPosOffsetXItem;
     rPoolDefaults[XATTR_FILLBMP_POSOFFSETY       -XATTR_START] = new XFillBmpPosOffsetYItem;
-    rPoolDefaults[XATTR_FILLFLOATTRANSPARENCE    -XATTR_START] = new XFillFloatTransparenceItem( this, aNullGrad, false );
+    rPoolDefaults[XATTR_FILLFLOATTRANSPARENCE    -XATTR_START] = new XFillFloatTransparenceItem( aNullGrad, false );
     rPoolDefaults[XATTR_SECONDARYFILLCOLOR       -XATTR_START] = new XSecondaryFillColorItem(aNullStr, aNullFillCol);
     rPoolDefaults[XATTR_FILLBACKGROUND           -XATTR_START] = new XFillBackgroundItem;
     rPoolDefaults[XATTR_FORMTXTSTYLE       -XATTR_START] = new XFormTextStyleItem;