summaryrefslogtreecommitdiff
path: root/svx
diff options
context:
space:
mode:
authorMichael Stahl <mstahl@redhat.com>2015-01-19 12:31:03 +0100
committerMichael Stahl <mstahl@redhat.com>2015-01-19 12:32:04 +0100
commitc8ae30a720474db8efed3db31348f8ae52c149c3 (patch)
tree41545b4a4af535fd4ed56bf618f4999519c5a5a5 /svx
parente437b13008f458bde2977e754214babdfd210558 (diff)
svx: ExternalToolEdit: check that temp file is actually created
Change-Id: I03e49493c549561b4dc806f1e191a73d06733cff
Diffstat (limited to 'svx')
-rw-r--r--svx/source/core/extedit.cxx16
1 files changed, 14 insertions, 2 deletions
diff --git a/svx/source/core/extedit.cxx b/svx/source/core/extedit.cxx
index 7cc8b5f70211..b49125332b29 100644
--- a/svx/source/core/extedit.cxx
+++ b/svx/source/core/extedit.cxx
@@ -106,11 +106,23 @@ void ExternalToolEdit::Edit(GraphicObject const*const pGraphicObject)
OUString aTempFileName;
oslFileHandle pHandle;
- osl::FileBase::createTempFile(0, &pHandle, &aTempFileBase);
+ osl::FileBase::RC rc =
+ osl::FileBase::createTempFile(0, &pHandle, &aTempFileBase);
+ if (osl::FileBase::E_None != rc)
+ {
+ SAL_WARN("svx", "ExternalToolEdit::Edit: cannot create temp file");
+ return;
+ }
// Move it to a file name with image extension properly set
aTempFileName = aTempFileBase + "." + OUString(fExtension);
- osl::File::move(aTempFileBase, aTempFileName);
+ // FIXME: this is pretty stupid, need a better osl temp file API
+ rc = osl::File::move(aTempFileBase, aTempFileName);
+ if (osl::FileBase::E_None != rc)
+ {
+ SAL_WARN("svx", "ExternalToolEdit::Edit: cannot move temp file");
+ return;
+ }
//Write Graphic to the Temp File
GraphicFilter& rGraphicFilter = GraphicFilter::GetGraphicFilter();