diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2021-11-07 18:00:11 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-11-07 19:20:37 +0100 |
| commit | 4f6f70d9f418593fd64788bb204e6f6f36674fce (patch) | |
| tree | 5e15348d421b5a3f7ab3691f97b0386cc0cf5f07 /svx | |
| parent | a0e0575dcf4fede5c6e20636c63042d8c62ecf77 (diff) | |
add more comment
Change-Id: I4b19e7f62a70d795071c3a45e3f1c148f509bc53
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124823
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/svdraw/svdobj.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx index 4c8b9d142197..35aaebc13f09 100644 --- a/svx/source/svdraw/svdobj.cxx +++ b/svx/source/svdraw/svdobj.cxx @@ -2896,6 +2896,12 @@ css::uno::Reference< css::drawing::XShape > SdrObject::getUnoShape() // At that Model extended functionality for that factory (or overloads and implementations) // should be placed. But to be realistic, migrating the factories to Model now is too much // work - maybe over time when melting SdrObject/SvxObject one day... + // + // More Note (added by noel grandin) + // Except that sd/ is being naughty and doing all kinds of magic during CreateShape that + // requires knowing which page the object is being created for. Fixing that would require + // moving a bunch of nasty logic from object creation time, to the point in time when + // it is actually added to a page. if(nullptr == pPageCandidate) { // If not inserted, alternatively access a SdrPage using the SdrModel. There is |