diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2021-12-18 22:01:39 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-12-20 08:33:19 +0100 |
| commit | 279487b53ac876bb8ece9e5c2ec2882ca077bf13 (patch) | |
| tree | 60111854a99cf9040ecca4d1016459a030068245 /svx | |
| parent | 858c4cd07f22ad0f7dfbb31e55619bcc7d8b1051 (diff) | |
use cppu::BaseMutex in SvXMLGraphicHelper
because passing a ref of a local member to a parent class
means passing uninitialised data
Change-Id: I1171c3e5f5df148c7e63dad451bf54dff23fe2aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127119
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/xml/xmlgrhlp.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/svx/source/xml/xmlgrhlp.cxx b/svx/source/xml/xmlgrhlp.cxx index 43195d1db82c..35d3a247c56a 100644 --- a/svx/source/xml/xmlgrhlp.cxx +++ b/svx/source/xml/xmlgrhlp.cxx @@ -369,7 +369,7 @@ const GraphicObject& SvXMLGraphicOutputStream::GetGraphicObject() SvXMLGraphicHelper::SvXMLGraphicHelper(SvXMLGraphicHelperMode eCreateMode) : cppu::WeakComponentImplHelper<document::XGraphicObjectResolver, document::XGraphicStorageHandler, - document::XBinaryStreamResolver>(maMutex) + document::XBinaryStreamResolver>(m_aMutex) { Init( nullptr, eCreateMode ); } @@ -377,7 +377,7 @@ SvXMLGraphicHelper::SvXMLGraphicHelper(SvXMLGraphicHelperMode eCreateMode) SvXMLGraphicHelper::SvXMLGraphicHelper() : cppu::WeakComponentImplHelper<document::XGraphicObjectResolver, document::XGraphicStorageHandler, - document::XBinaryStreamResolver>(maMutex) + document::XBinaryStreamResolver>(m_aMutex) , meCreateMode(SvXMLGraphicHelperMode::Read) { } @@ -580,7 +580,7 @@ OUString SAL_CALL SvXMLGraphicHelper::resolveGraphicObjectURL( const OUString& / // XGraphicStorageHandler uno::Reference<graphic::XGraphic> SAL_CALL SvXMLGraphicHelper::loadGraphic(OUString const & rURL) { - osl::MutexGuard aGuard(maMutex); + osl::MutexGuard aGuard(m_aMutex); uno::Reference<graphic::XGraphic> xGraphic; @@ -612,7 +612,7 @@ uno::Reference<graphic::XGraphic> SAL_CALL SvXMLGraphicHelper::loadGraphic(OUStr uno::Reference<graphic::XGraphic> SAL_CALL SvXMLGraphicHelper::loadGraphicFromOutputStream(uno::Reference<io::XOutputStream> const & rxOutputStream) { - osl::MutexGuard aGuard(maMutex); + osl::MutexGuard aGuard(m_aMutex); uno::Reference<graphic::XGraphic> xGraphic; |