diff options
| author | Jan-Marek Glogowski <glogow@fbihome.de> | 2021-12-15 15:37:58 +0100 |
|---|---|---|
| committer | Jan-Marek Glogowski <glogow@fbihome.de> | 2021-12-21 00:20:07 +0100 |
| commit | 379b685730ca7adb3b8d1905c73a2c3df1d31799 (patch) | |
| tree | 85a4d96a22b7e367e7eefd737623f951917cd5ca /sw/Library_sw.mk | |
| parent | 50f553cacad76da22166d058db98f28d5ce6d65d (diff) | |
Filter optional component implementations by name
Instead of trying to make up BUILD_TYPE items to match complex
build conditions and then patch the component file with it, filter
the component files based on the unique implementation name and
an <optional/> tag. Currently these optional implementations are
grouped in external files with an identifier.
Originally the optional implementations were automatically iden-
tified by adding them to any external file, but this behavior is
too easy to get wrong. Even better: if need arrises, one can now
easily implement a feature to add implementation names directly
using gbuild calls, instead of grouped files.
The basic mechanism is to collect all optional implementations,
remove the needed ones from that list and then filter-out all
implementations not needed (AKA the rest of the list).
It's no problem to have the same optional implementations
selected in multiple files. This is especially used by the
vcl.common component in a later patch.
For gbuild this adds gb_Library_add_componentimpl. The component
parameter for the call is explicitly omitted, so you must call
gb_Library_set_componentfile before selecting any optional
implementations. The strict naming is also enforced by appending
the identifier to the component file name.
This replaces commit 65c0887bca2909b2046eb5aa4aaace0cc320c3f2
("Allow for conditional parts of component files").
Change-Id: I0261cadce8bdfebb6b3ec96669ec378a5c1d9699
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126891
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Diffstat (limited to 'sw/Library_sw.mk')
| -rw-r--r-- | sw/Library_sw.mk | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 58639859bb0e..fd418f7064bd 100644 --- a/sw/Library_sw.mk +++ b/sw/Library_sw.mk @@ -796,6 +796,8 @@ $(eval $(call gb_Library_add_exception_objects,sw,\ sw/source/uibase/dbui/dbtree \ sw/source/uibase/dbui/mailmergetoolbarcontrols \ )) + +$(eval $(call gb_Library_add_componentimpl,sw,mailmerge)) endif $(eval $(call gb_SdiTarget_SdiTarget,sw/sdi/swslots,sw/sdi/swriter)) |