diff options
| author | Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> | 2021-01-23 01:09:49 +0100 |
|---|---|---|
| committer | Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> | 2021-01-29 23:10:59 +0100 |
| commit | d77552970af7ffb9d06bcd57315979f317e94e2f (patch) | |
| tree | 9ba78f893f57efc2ab0f8d542abb70032c240ee3 /sw/Library_sw.mk | |
| parent | c6ff20f1c101372be46a2583ec0c83ff021690a9 (diff) | |
remove SwCache bookkeeping from SwModify
- only very few classes (SwNode, SwFormat) are the "owners"
of SwBorderAttrs in the SwCache
- this bookkeeping should not be in such a fundamental class of writer
- also: encapsulate most of the interaction with the cache in the new
sw::BorderCacheOwner. This is mostly to protect the innocent user:
* As interacting with the SwCache directly is very errorprone, because
its glorious idea of using void* of the "owners" as keys to the
entries.
* In C++, reinterpret_cast<void*>(this) might be different along the
class heirachy. This might easily slip under the radar of a casual
user.
Change-Id: I0da774b47885abf52f63aab8d93ebbf41dcf8040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110112
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
Diffstat (limited to 'sw/Library_sw.mk')
| -rw-r--r-- | sw/Library_sw.mk | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 65f4154bf12e..85fd37e2b150 100644 --- a/sw/Library_sw.mk +++ b/sw/Library_sw.mk @@ -124,6 +124,7 @@ $(eval $(call gb_Library_add_exception_objects,sw,\ sw/source/core/access/acctextframe \ sw/source/core/access/parachangetrackinginfo \ sw/source/core/access/textmarkuphelper \ + sw/source/core/attr/BorderCacheOwner \ sw/source/core/attr/calbck \ sw/source/core/attr/cellatr \ sw/source/core/attr/fmtfollowtextflow \ |