loplugin:stringloop in sw

Change-Id: Ie316aee8d1e4f772dc25725b46e130c6717458c2
Reviewed-on: https://gerrit.libreoffice.org/58331
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 6 insertions, 5 deletions

diff --git a/sw/inc/dbgoutsw.hxx b/sw/inc/dbgoutsw.hxx
index 44dc0b2ab6ce..bc1d93f6c159 100644
--- a/sw/inc/dbgoutsw.hxx
+++ b/sw/inc/dbgoutsw.hxx
@@ -22,6 +22,7 @@
 #ifdef DBG_UTIL
 
 #include <rtl/ustring.hxx>
+#include <rtl/ustrbuf.hxx>
 #include "tox.hxx"
 #include <cstdio>
 #include <unordered_map>
@@ -78,25 +79,25 @@ SW_DLLPUBLIC const char * dbg_out(const SwNodeRange & rRange);
 template<typename tKey, typename tMember, typename fHashFunction>
 OUString lcl_dbg_out(const std::unordered_map<tKey, tMember, fHashFunction> & rMap)
 {
-    OUString aResult("[");
+    OUStringBuffer aResult("[");
 
     typename std::unordered_map<tKey, tMember, fHashFunction>::const_iterator aIt;
 
     for (aIt = rMap.begin(); aIt != rMap.end(); ++aIt)
     {
         if (aIt != rMap.begin())
-            aResult += ", ";
+            aResult.append(", ");
 
         aResult += aIt->first;
 
         char sBuffer[256];
         sprintf(sBuffer, "(%p)", aIt->second);
-        aResult += OUString(sBuffer, strlen(sBuffer), RTL_TEXTENCODING_ASCII_US);
+        aResult.appendAscii(sBuffer);
     }
 
-    aResult += "]";
+    aResult.append("]");
 
-    return aResult;
+    return aResult.makeStringAndClear();
 }
 
 template<typename tKey, typename tMember, typename fHashFunction>