Revert "reduce symbol visibility in sw"

This reverts commit 1a6711276f0c8abeb0028a47cc345a7453374a38.

After some discussion and experiments, it turned out this rather
fundamentally breaks clang's PCH build. Conclusion was: this change is
not significant enough to warrant making life harder for developers.

Excerpt of errors (affected were vbaswobj, msword & swui libs):

- ld.lld: error: undefined symbol: SwFormat::~SwFormat()
>>> referenced by fmtcol.hxx:37 (sw/inc/fmtcol.hxx:37)
>>>               core/workdir/CxxObject/sw/inc/pch/precompiled_vbaswobj.o:(SwFormatColl::~SwFormatColl())
- ld.lld: error: undefined symbol: SwFrameFormat::SetPositionLayoutDir(short)
>>> referenced by precompiled_msword.cxx
>>>               core/workdir/CxxObject/sw/inc/pch/precompiled_msword.o:(vtable for sw::SpzFrameFormat)
- ld.lld: error: undefined symbol: SwFrameFormat::SetLayoutDir(SwFrameFormat::tLayoutDir)
>>> referenced by precompiled_swui.cxx
>>>               core/workdir/CxxObject/sw/inc/pch/precompiled_swui.o:(vtable for sw::SpzFrameFormat)

Change-Id: I1dcf115cc191b1ebf1f8d5023c0c5015f891287a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167549
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

1 files changed, 63 insertions, 63 deletions

diff --git a/sw/inc/unotxdoc.hxx b/sw/inc/unotxdoc.hxx
index 4bc4296633c2..d938773d17dd 100644
--- a/sw/inc/unotxdoc.hxx
+++ b/sw/inc/unotxdoc.hxx
@@ -167,7 +167,7 @@ typedef cppu::ImplInheritanceHelper
 >
 SwXTextDocumentBaseClass;
 
-class SAL_DLLPUBLIC_RTTI SwXTextDocument final : public SwXTextDocumentBaseClass,
+class SW_DLLPUBLIC SwXTextDocument final : public SwXTextDocumentBaseClass,
     public SvxFmMSFactory,
     public vcl::ITiledRenderable,
     public css::tiledrendering::XTiledRenderable
@@ -251,19 +251,19 @@ public:
 
     void NotifyRefreshListeners();
     virtual     css::uno::Any SAL_CALL queryInterface( const css::uno::Type& aType ) override;
-    SW_DLLPUBLIC virtual void SAL_CALL acquire(  ) noexcept override;
-    SW_DLLPUBLIC virtual void SAL_CALL release(  ) noexcept override;
+    virtual void SAL_CALL acquire(  ) noexcept override;
+    virtual void SAL_CALL release(  ) noexcept override;
 
     //XWeak
     virtual css::uno::Sequence< css::uno::Type > SAL_CALL getTypes(  ) override;
 
-    SW_DLLPUBLIC static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId();
+    static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId();
 
     //XUnoTunnel
     virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override;
 
     //XTextDocument
-    SW_DLLPUBLIC virtual css::uno::Reference< css::text::XText >  SAL_CALL getText() override;
+    virtual css::uno::Reference< css::text::XText >  SAL_CALL getText() override;
     rtl::Reference< SwXBodyText > getBodyText();
     virtual void SAL_CALL reformat() override;
 
@@ -279,12 +279,12 @@ public:
     virtual void SAL_CALL lockControllers(  ) override;
     virtual void SAL_CALL unlockControllers(  ) override;
     virtual sal_Bool SAL_CALL hasControllersLocked(  ) override;
-    SW_DLLPUBLIC virtual css::uno::Reference< css::frame::XController > SAL_CALL getCurrentController(  ) override;
+    virtual css::uno::Reference< css::frame::XController > SAL_CALL getCurrentController(  ) override;
     virtual void SAL_CALL setCurrentController( const css::uno::Reference< css::frame::XController >& xController ) override;
     virtual css::uno::Reference< css::uno::XInterface > SAL_CALL getCurrentSelection(  ) override;
 
     //XComponent
-    SW_DLLPUBLIC virtual void SAL_CALL dispose() override;
+    virtual void SAL_CALL dispose() override;
     virtual void SAL_CALL addEventListener(const css::uno::Reference< css::lang::XEventListener > & aListener) override;
     virtual void SAL_CALL removeEventListener(const css::uno::Reference< css::lang::XEventListener > & aListener) override;
 
@@ -292,24 +292,24 @@ public:
     virtual void SAL_CALL close( sal_Bool bDeliverOwnership ) override;
 
     //XLineNumberingProperties
-    SW_DLLPUBLIC virtual css::uno::Reference< css::beans::XPropertySet > SAL_CALL getLineNumberingProperties() override;
+    virtual css::uno::Reference< css::beans::XPropertySet > SAL_CALL getLineNumberingProperties() override;
 
     //XChapterNumberingSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XIndexReplace >  SAL_CALL getChapterNumberingRules() override;
+    virtual css::uno::Reference< css::container::XIndexReplace >  SAL_CALL getChapterNumberingRules() override;
 
     //XNumberingRulesSupplier
     virtual css::uno::Reference< css::container::XIndexAccess > SAL_CALL getNumberingRules() override;
 
     //XFootnotesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getFootnotes() override;
-    SW_DLLPUBLIC virtual css::uno::Reference< css::beans::XPropertySet >  SAL_CALL getFootnoteSettings() override;
+    virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getFootnotes() override;
+    virtual css::uno::Reference< css::beans::XPropertySet >  SAL_CALL getFootnoteSettings() override;
 
     //XEndnotesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getEndnotes() override;
-    SW_DLLPUBLIC virtual css::uno::Reference< css::beans::XPropertySet >  SAL_CALL getEndnoteSettings() override;
+    virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getEndnotes() override;
+    virtual css::uno::Reference< css::beans::XPropertySet >  SAL_CALL getEndnoteSettings() override;
 
     // XContentControlsSupplier
-    SW_DLLPUBLIC css::uno::Reference<css::container::XIndexAccess> SAL_CALL getContentControls() override;
+    css::uno::Reference<css::container::XIndexAccess> SAL_CALL getContentControls() override;
 
     //XReplaceable
     virtual css::uno::Reference< css::util::XReplaceDescriptor >  SAL_CALL createReplaceDescriptor() override;
@@ -330,8 +330,8 @@ public:
     virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getReferenceMarks() override;
 
     // css::text::XTextFieldsSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XEnumerationAccess >  SAL_CALL getTextFields() override;
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextFieldMasters() override;
+    virtual css::uno::Reference< css::container::XEnumerationAccess >  SAL_CALL getTextFields() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextFieldMasters() override;
 
     // css::text::XTextEmbeddedObjectsSupplier
     virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getEmbeddedObjects() override;
@@ -340,25 +340,25 @@ public:
     virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getBookmarks() override;
 
     // css::text::XTextSectionsSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextSections() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextSections() override;
 
     // css::text::XTextTablesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextTables() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextTables() override;
 
     // css::text::XTextGraphicObjectsSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getGraphicObjects() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getGraphicObjects() override;
 
     // css::text::XTextFramesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextFrames() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getTextFrames() override;
 
     //XStyleFamiliesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getStyleFamilies() override;
+    virtual css::uno::Reference< css::container::XNameAccess >  SAL_CALL getStyleFamilies() override;
 
     //XAutoStylesSupplier
     virtual css::uno::Reference< css::style::XAutoStyles > SAL_CALL getAutoStyles(  ) override;
 
     //XMultiServiceFactory
-    SW_DLLPUBLIC virtual css::uno::Reference< css::uno::XInterface >  SAL_CALL createInstance(const OUString& ServiceSpecifier) override;
+    virtual css::uno::Reference< css::uno::XInterface >  SAL_CALL createInstance(const OUString& ServiceSpecifier) override;
     virtual css::uno::Reference< css::uno::XInterface >  SAL_CALL createInstanceWithArguments(const OUString& ServiceSpecifier,
                 const css::uno::Sequence< css::uno::Any >& Arguments) override;
     virtual css::uno::Sequence< OUString > SAL_CALL getAvailableServiceNames() override;
@@ -369,18 +369,18 @@ public:
     virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() override;
 
     // css::drawing::XDrawPageSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::drawing::XDrawPage >  SAL_CALL getDrawPage() override;
+    virtual css::uno::Reference< css::drawing::XDrawPage >  SAL_CALL getDrawPage() override;
 
     // css::drawing::XDrawPagesSupplier
     virtual css::uno::Reference< css::drawing::XDrawPages > SAL_CALL getDrawPages() override;
 
     // css::text::XDocumentIndexesSupplier
-    SW_DLLPUBLIC virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getDocumentIndexes() override;
+    virtual css::uno::Reference< css::container::XIndexAccess >  SAL_CALL getDocumentIndexes() override;
 
     //XPropertySet
     virtual css::uno::Reference< css::beans::XPropertySetInfo > SAL_CALL getPropertySetInfo(  ) override;
-    SW_DLLPUBLIC virtual void SAL_CALL setPropertyValue( const OUString& aPropertyName, const css::uno::Any& aValue ) override;
-    SW_DLLPUBLIC virtual css::uno::Any SAL_CALL getPropertyValue( const OUString& PropertyName ) override;
+    virtual void SAL_CALL setPropertyValue( const OUString& aPropertyName, const css::uno::Any& aValue ) override;
+    virtual css::uno::Any SAL_CALL getPropertyValue( const OUString& PropertyName ) override;
     virtual void SAL_CALL addPropertyChangeListener( const OUString& aPropertyName, const css::uno::Reference< css::beans::XPropertyChangeListener >& xListener ) override;
     virtual void SAL_CALL removePropertyChangeListener( const OUString& aPropertyName, const css::uno::Reference< css::beans::XPropertyChangeListener >& aListener ) override;
     virtual void SAL_CALL addVetoableChangeListener( const OUString& PropertyName, const css::uno::Reference< css::beans::XVetoableChangeListener >& aListener ) override;
@@ -430,7 +430,7 @@ public:
         const ::css::uno::Reference<::css::text::XPasteListener>& xListener) override;
 
     /// @see vcl::ITiledRenderable::paintTile().
-    SW_DLLPUBLIC virtual void paintTile( VirtualDevice &rDevice,
+    virtual void paintTile( VirtualDevice &rDevice,
                             int nOutputWidth,
                             int nOutputHeight,
                             int nTilePosX,
@@ -438,33 +438,33 @@ public:
                             tools::Long nTileWidth,
                             tools::Long nTileHeight ) override;
     /// @see vcl::ITiledRenderable::getDocumentSize().
-    SW_DLLPUBLIC virtual Size getDocumentSize() override;
+    virtual Size getDocumentSize() override;
     /// @see vcl::ITiledRenderable::setPart().
     virtual void setPart(int nPart, bool bAllowChangeFocus = true) override;
     /// @see vcl::ITiledRenderable::getParts().
-    SW_DLLPUBLIC virtual int getParts() override;
+    virtual int getParts() override;
     /// @see vcl::ITiledRenderable::getPart().
     virtual int getPart() override;
     /// @see vcl::ITiledRenderable::getPartName().
     virtual OUString getPartName(int nPart) override;
     /// @see vcl::ITiledRenderable::getPartHash().
-    SW_DLLPUBLIC virtual OUString getPartHash(int nPart) override;
+    virtual OUString getPartHash(int nPart) override;
     /// @see vcl::ITiledRenderable::getDocWindow().
-    SW_DLLPUBLIC virtual VclPtr<vcl::Window> getDocWindow() override;
+    virtual VclPtr<vcl::Window> getDocWindow() override;
     /// @see vcl::ITiledRenderable::initializeForTiledRendering().
-    SW_DLLPUBLIC virtual void initializeForTiledRendering(const css::uno::Sequence<css::beans::PropertyValue>& rArguments) override;
+    virtual void initializeForTiledRendering(const css::uno::Sequence<css::beans::PropertyValue>& rArguments) override;
     /// @see vcl::ITiledRenderable::postKeyEvent().
-    SW_DLLPUBLIC virtual void postKeyEvent(int nType, int nCharCode, int nKeyCode) override;
+    virtual void postKeyEvent(int nType, int nCharCode, int nKeyCode) override;
     /// @see vcl::ITiledRenderable::postMouseEvent().
-    SW_DLLPUBLIC virtual void postMouseEvent(int nType, int nX, int nY, int nCount, int nButtons, int nModifier) override;
+    virtual void postMouseEvent(int nType, int nX, int nY, int nCount, int nButtons, int nModifier) override;
     /// @see vcl::ITiledRenderable::setTextSelection().
-    SW_DLLPUBLIC virtual void setTextSelection(int nType, int nX, int nY) override;
+    virtual void setTextSelection(int nType, int nX, int nY) override;
     /// @see vcl::ITiledRenderable::getSelection().
-    SW_DLLPUBLIC virtual css::uno::Reference<css::datatransfer::XTransferable> getSelection() override;
+    virtual css::uno::Reference<css::datatransfer::XTransferable> getSelection() override;
     /// @see vcl::ITiledRenderable::setGraphicSelection().
-    SW_DLLPUBLIC virtual void setGraphicSelection(int nType, int nX, int nY) override;
+    virtual void setGraphicSelection(int nType, int nX, int nY) override;
     /// @see vcl::ITiledRenderable::resetSelection().
-    SW_DLLPUBLIC virtual void resetSelection() override;
+    virtual void resetSelection() override;
     /// @see vcl::ITiledRenderable::getPartPageRectangles().
     virtual OUString getPartPageRectangles() override;
     /// @see vcl::ITiledRenderable::setClipboard().
@@ -472,7 +472,7 @@ public:
     /// @see vcl::ITiledRenderable::isMimeTypeSupported().
     virtual bool isMimeTypeSupported() override;
     /// @see vcl::ITiledRenderable::setClientVisibleArea().
-    SW_DLLPUBLIC virtual void setClientVisibleArea(const tools::Rectangle& rRectangle) override;
+    virtual void setClientVisibleArea(const tools::Rectangle& rRectangle) override;
     /// @see vcl::ITiledRenderable::setClientZoom.
     virtual void setClientZoom(int nTilePixelWidth_, int nTilePixelHeight_, int nTileTwipWidth_, int nTileTwipHeight_) override;
     /// @see vcl::ITiledRenderable::getPointer().
@@ -480,14 +480,14 @@ public:
     /// @see vcl::ITiledRenderable::getTrackedChanges().
     void getTrackedChanges(tools::JsonWriter&) override;
     /// @see vcl::ITiledRenderable::getTrackedChangeAuthors().
-    SW_DLLPUBLIC void getTrackedChangeAuthors(tools::JsonWriter& rJsonWriter) override;
+    void getTrackedChangeAuthors(tools::JsonWriter& rJsonWriter) override;
 
     void getRulerState(tools::JsonWriter& rJsonWriter) override;
     /// @see vcl::ITiledRenderable::getPostIts().
-    SW_DLLPUBLIC void getPostIts(tools::JsonWriter& rJsonWriter) override;
+    void getPostIts(tools::JsonWriter& rJsonWriter) override;
 
     /// @see vcl::ITiledRenderable::executeFromFieldEvent().
-    SW_DLLPUBLIC virtual void executeFromFieldEvent(const StringMap& aArguments) override;
+    virtual void executeFromFieldEvent(const StringMap& aArguments) override;
 
     /// @see vcl::ITiledRenderable::getSearchResultRectangles().
     std::vector<basegfx::B2DRange> getSearchResultRectangles(const char* pPayload) override;
@@ -496,13 +496,13 @@ public:
     virtual void SAL_CALL paintTile( const ::css::uno::Any& Parent, ::sal_Int32 nOutputWidth, ::sal_Int32 nOutputHeight, ::sal_Int32 nTilePosX, ::sal_Int32 nTilePosY, ::sal_Int32 nTileWidth, ::sal_Int32 nTileHeight ) override;
 
     /// @see vcl::ITiledRenderable::executeContentControlEvent().
-    SW_DLLPUBLIC void executeContentControlEvent(const StringMap& aArguments) override;
+    void executeContentControlEvent(const StringMap& aArguments) override;
 
     /// @see vcl::ITiledRenderable::getCommandValues().
-    SW_DLLPUBLIC void getCommandValues(tools::JsonWriter& rJsonWriter, std::string_view rCommand) override;
+    void getCommandValues(tools::JsonWriter& rJsonWriter, std::string_view rCommand) override;
 
     /// @see vcl::ITiledRenderable::getViewRenderState().
-    SW_DLLPUBLIC OString getViewRenderState(SfxViewShell* pViewShell = nullptr) override;
+    OString getViewRenderState(SfxViewShell* pViewShell = nullptr) override;
 
     /// @see vcl::ITiledRenderable::supportsCommand().
     bool supportsCommand(std::u16string_view rCommand) override;
@@ -521,24 +521,24 @@ public:
 
     SwDocShell*                 GetDocShell() {return m_pDocShell;}
 
-    SW_DLLPUBLIC rtl::Reference<SwXDocumentSettings> createDocumentSettings();
-    SW_DLLPUBLIC rtl::Reference<SwXTextDefaults> createTextDefaults();
-    SW_DLLPUBLIC rtl::Reference<SwXBookmark> createBookmark();
-    SW_DLLPUBLIC rtl::Reference<SwXBookmark> createFieldmark();
-    SW_DLLPUBLIC rtl::Reference<SwXTextSection> createTextSection();
-    SW_DLLPUBLIC rtl::Reference<SwXTextField> createFieldAnnotation();
-    SW_DLLPUBLIC rtl::Reference<SwXLineBreak> createLineBreak();
-    SW_DLLPUBLIC rtl::Reference<SwXTextFrame> createTextFrame();
-    SW_DLLPUBLIC rtl::Reference<SwXTextGraphicObject> createTextGraphicObject();
-    SW_DLLPUBLIC rtl::Reference<SwXStyle> createNumberingStyle();
-    SW_DLLPUBLIC rtl::Reference<SwXStyle> createCharacterStyle();
-    SW_DLLPUBLIC rtl::Reference<SwXStyle> createParagraphStyle();
-    SW_DLLPUBLIC rtl::Reference<SwXPageStyle> createPageStyle();
-    SW_DLLPUBLIC rtl::Reference<SwXContentControl> createContentControl();
-    SW_DLLPUBLIC rtl::Reference<SwXFootnote> createFootnote();
-    SW_DLLPUBLIC rtl::Reference<SwXFootnote> createEndnote();
-    SW_DLLPUBLIC rtl::Reference<SwXTextEmbeddedObject> createTextEmbeddedObject();
-    SW_DLLPUBLIC rtl::Reference<SvXMLEmbeddedObjectHelper> createEmbeddedObjectResolver();
+    rtl::Reference<SwXDocumentSettings> createDocumentSettings();
+    rtl::Reference<SwXTextDefaults> createTextDefaults();
+    rtl::Reference<SwXBookmark> createBookmark();
+    rtl::Reference<SwXBookmark> createFieldmark();
+    rtl::Reference<SwXTextSection> createTextSection();
+    rtl::Reference<SwXTextField> createFieldAnnotation();
+    rtl::Reference<SwXLineBreak> createLineBreak();
+    rtl::Reference<SwXTextFrame> createTextFrame();
+    rtl::Reference<SwXTextGraphicObject> createTextGraphicObject();
+    rtl::Reference<SwXStyle> createNumberingStyle();
+    rtl::Reference<SwXStyle> createCharacterStyle();
+    rtl::Reference<SwXStyle> createParagraphStyle();
+    rtl::Reference<SwXPageStyle> createPageStyle();
+    rtl::Reference<SwXContentControl> createContentControl();
+    rtl::Reference<SwXFootnote> createFootnote();
+    rtl::Reference<SwXFootnote> createEndnote();
+    rtl::Reference<SwXTextEmbeddedObject> createTextEmbeddedObject();
+    rtl::Reference<SvXMLEmbeddedObjectHelper> createEmbeddedObjectResolver();
 };
 
 class SwXLinkTargetSupplier final : public cppu::WeakImplHelper