loplugin:constantparam in sw

Change-Id: Ic49d1c3c7b57fb213964ddc21b0f774c762aad94

19 files changed, 30 insertions, 40 deletions

diff --git a/sw/inc/IDocumentContentOperations.hxx b/sw/inc/IDocumentContentOperations.hxx
index 1572e218288e..0a1087ee4884 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -175,7 +175,7 @@ public:
         const SfxItemSet* pGrfAttrSet, SwFrameFormat*) = 0;
 
     virtual SwFlyFrameFormat* InsertOLE(const SwPaM &rRg, const OUString& rObjName, sal_Int64 nAspect, const SfxItemSet* pFlyAttrSet,
-                           const SfxItemSet* pGrfAttrSet, SwFrameFormat*) = 0;
+                           const SfxItemSet* pGrfAttrSet) = 0;
 
     /** Split a node at rPos (implemented only for TextNode).
     */
diff --git a/sw/inc/IDocumentFieldsAccess.hxx b/sw/inc/IDocumentFieldsAccess.hxx
index f9b116b716c2..f73e51c81d8e 100644
--- a/sw/inc/IDocumentFieldsAccess.hxx
+++ b/sw/inc/IDocumentFieldsAccess.hxx
@@ -88,7 +88,7 @@ namespace com { namespace sun { namespace star { namespace uno { class Any; } }
     */
     virtual bool UpdateField(SwTextField * rDstFormatField, SwField & rSrcField, SwMsgPoolItem * pMsgHint, bool bUpdateTableFields) = 0;
 
-    virtual void UpdateRefFields(SfxPoolItem* pHt) = 0;
+    virtual void UpdateRefFields() = 0;
 
     virtual void UpdateTableFields(SfxPoolItem* pHt) = 0;
 
diff --git a/sw/inc/SwAppletImpl.hxx b/sw/inc/SwAppletImpl.hxx
index 9fbeb45c8ab2..0d6d7d62fd0f 100644
--- a/sw/inc/SwAppletImpl.hxx
+++ b/sw/inc/SwAppletImpl.hxx
@@ -50,7 +50,7 @@ class SwApplet_Impl
 
 public:
     static SwHtmlOptType GetOptionType( const OUString& rName, bool bApplet );
-    SwApplet_Impl( SfxItemPool& rPool, sal_uInt16 nWhich1, sal_uInt16 nWhich2 );
+    SwApplet_Impl( SfxItemPool& rPool );
     SwApplet_Impl( SfxItemSet& rSet ): aItemSet ( rSet) {}
     ~SwApplet_Impl();
     void CreateApplet( const OUString& rCode, const OUString& rName,
diff --git a/sw/inc/SwUndoField.hxx b/sw/inc/SwUndoField.hxx
index 541cb54e70b9..66ad76e992d4 100644
--- a/sw/inc/SwUndoField.hxx
+++ b/sw/inc/SwUndoField.hxx
@@ -52,8 +52,7 @@ class SwUndoFieldFromDoc : public SwUndoField
 public:
     SwUndoFieldFromDoc(const SwPosition & rPos, const SwField & aOldField,
                        const SwField & aNewField,
-                       SwMsgPoolItem * pHint, bool bUpdate,
-                       SwUndoId nId = UNDO_FIELD );
+                       SwMsgPoolItem * pHint, bool bUpdate);
 
     virtual ~SwUndoFieldFromDoc();
 
diff --git a/sw/inc/fesh.hxx b/sw/inc/fesh.hxx
index 20eb7c903e77..550f1aafd0de 100644
--- a/sw/inc/fesh.hxx
+++ b/sw/inc/fesh.hxx
@@ -625,7 +625,6 @@ public:
 
     SwFlyFrameFormat* InsertObject( const svt::EmbeddedObjectRef&,
                 const SfxItemSet* pFlyAttrSet,
-                const SfxItemSet* pGrfAttrSet = nullptr,
                 SwFrameFormat* = nullptr );
     bool    FinishOLEObj(); ///< Shutdown server.
 
diff --git a/sw/inc/ftninfo.hxx b/sw/inc/ftninfo.hxx
index 76bdff5aa1e0..585130cdcd19 100644
--- a/sw/inc/ftninfo.hxx
+++ b/sw/inc/ftninfo.hxx
@@ -100,7 +100,7 @@ public:
 
     bool operator==( const SwFootnoteInfo &rInf ) const;
 
-    SwFootnoteInfo(SwTextFormatColl* pTextColl = nullptr);
+    SwFootnoteInfo();
     SwFootnoteInfo(const SwFootnoteInfo&);
 };
 
diff --git a/sw/inc/grfatr.hxx b/sw/inc/grfatr.hxx
index 90838c359647..f4a4ad137062 100644
--- a/sw/inc/grfatr.hxx
+++ b/sw/inc/grfatr.hxx
@@ -94,8 +94,8 @@ class SwRotationGrf : public SfxUInt16Item
 {
     Size aUnrotatedSize;
 public:
-    SwRotationGrf( sal_Int16 nVal = 0 )
-        : SfxUInt16Item( RES_GRFATR_ROTATION, nVal )
+    SwRotationGrf()
+        : SfxUInt16Item( RES_GRFATR_ROTATION, 0 )
     {}
     SwRotationGrf( sal_Int16 nVal, const Size& rSz )
         : SfxUInt16Item( RES_GRFATR_ROTATION, nVal ), aUnrotatedSize( rSz )
diff --git a/sw/inc/ndgrf.hxx b/sw/inc/ndgrf.hxx
index 6394db3a5290..2734d19a1ea2 100644
--- a/sw/inc/ndgrf.hxx
+++ b/sw/inc/ndgrf.hxx
@@ -126,7 +126,8 @@ public:
     void SetGraphic(const Graphic& rGraphic, const OUString& rLink);
 
     /// wrappers for non-const calls at GraphicObject
-    void StartGraphicAnimation(OutputDevice* pOut, const Point& rPt, const Size& rSz, long nExtraData, const GraphicAttr* pAttr = nullptr, GraphicManagerDrawFlags nFlags = GraphicManagerDrawFlags::STANDARD, OutputDevice* pFirstFrameOutDev = nullptr) { maGrfObj.StartAnimation(pOut, rPt, rSz, nExtraData, pAttr, nFlags, pFirstFrameOutDev); }
+    void StartGraphicAnimation(OutputDevice* pOut, const Point& rPt, const Size& rSz, long nExtraData, OutputDevice* pFirstFrameOutDev = nullptr)
+    { maGrfObj.StartAnimation(pOut, rPt, rSz, nExtraData, nullptr, GraphicManagerDrawFlags::STANDARD, pFirstFrameOutDev); }
     void StopGraphicAnimation(OutputDevice* pOut, long nExtraData = 0) { maGrfObj.StopAnimation(pOut, nExtraData); }
 
     virtual Size GetTwipSize() const override;
diff --git a/sw/inc/postithelper.hxx b/sw/inc/postithelper.hxx
index e4bf2bf5a3c5..9642a7e0dffa 100644
--- a/sw/inc/postithelper.hxx
+++ b/sw/inc/postithelper.hxx
@@ -114,7 +114,6 @@ public:
     virtual const SwFormatField& GetFormatField() const = 0;
     virtual const SfxBroadcaster* GetBroadCaster() const = 0;
     virtual VclPtr<sw::sidebarwindows::SwSidebarWin> GetSidebarWindow( SwEditWin& rEditWin,
-                                                                WinBits nBits,
                                                                 SwPostItMgr& aMgr) = 0;
 };
 
@@ -145,7 +144,6 @@ public:
     }
     virtual VclPtr<sw::sidebarwindows::SwSidebarWin> GetSidebarWindow(
         SwEditWin& rEditWin,
-        WinBits nBits,
         SwPostItMgr& aMgr ) override;
 
 private:
diff --git a/sw/inc/redline.hxx b/sw/inc/redline.hxx
index d1dbd528c4d8..8a9a1f0433c6 100644
--- a/sw/inc/redline.hxx
+++ b/sw/inc/redline.hxx
@@ -119,8 +119,7 @@ public:
 
     // For sw3io: pNext/pExtraData are taken over.
     SwRedlineData( RedlineType_t eT, sal_uInt16 nAut, const DateTime& rDT,
-                   const OUString& rCmnt, SwRedlineData* pNxt,
-                    SwRedlineExtraData* pExtraData = nullptr );
+                   const OUString& rCmnt, SwRedlineData* pNxt );
 
     ~SwRedlineData();
 
@@ -166,7 +165,7 @@ public:
         }
 
     // ExtraData gets copied, the pointer is therefore not taken over by
-    // the RedlilneObject
+    // the RedlineObject
     void SetExtraData( const SwRedlineExtraData* pData );
     const SwRedlineExtraData* GetExtraData() const { return pExtraData; }
 
diff --git a/sw/inc/splargs.hxx b/sw/inc/splargs.hxx
index e601d71f5586..85ae6b45c2b1 100644
--- a/sw/inc/splargs.hxx
+++ b/sw/inc/splargs.hxx
@@ -121,13 +121,12 @@ public:
     sal_Int32 nWordStart;
     sal_Int32 nWordLen;
 
-    SwInterHyphInfo( const Point &rCursorPos, sal_Int32 nStartPos = 0,
-        sal_Int32 nLength = SAL_MAX_INT32 )
+    SwInterHyphInfo( const Point &rCursorPos )
         : aCursorPos(rCursorPos)
         , bNoLang(false)
         , bCheck(false)
-        , nStart(nStartPos)
-        , nEnd(nLength == SAL_MAX_INT32 ? SAL_MAX_INT32 : nStartPos + nLength)
+        , nStart(0)
+        , nEnd(SAL_MAX_INT32)
         , nWordStart(0), nWordLen(0)
     {
     }
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index f392f3293a00..a42b520adc76 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -333,14 +333,14 @@ public:
     virtual AbstractSwInsertAbstractDlg * CreateSwInsertAbstractDlg() = 0;
     virtual AbstractSwAsciiFilterDlg*  CreateSwAsciiFilterDlg ( SwDocShell& rDocSh,
                                                                 SvStream* pStream ) = 0;
-    virtual VclAbstractDialog * CreateSwInsertBookmarkDlg( vcl::Window *pParent, SwWrtShell &rSh, SfxRequest& rReq, int nResId ) = 0;
+    virtual VclAbstractDialog * CreateSwInsertBookmarkDlg( vcl::Window *pParent, SwWrtShell &rSh, SfxRequest& rReq ) = 0;
 
     virtual AbstractSwBreakDlg * CreateSwBreakDlg(vcl::Window *pParent, SwWrtShell &rSh) = 0;
     virtual VclAbstractDialog   * CreateSwChangeDBDlg(SwView& rVw) = 0;
     virtual SfxAbstractTabDialog *  CreateSwCharDlg(vcl::Window* pParent, SwView& pVw, const SfxItemSet& rCoreSet,
         SwCharDlgMode nDialogMode, const OUString* pFormatStr = nullptr) = 0;
     virtual AbstractSwConvertTableDlg* CreateSwConvertTableDlg(SwView& rView, bool bToTable) = 0;
-    virtual VclAbstractDialog * CreateSwCaptionDialog ( vcl::Window *pParent, SwView &rV,int nResId) = 0;
+    virtual VclAbstractDialog * CreateSwCaptionDialog ( vcl::Window *pParent, SwView &rV) = 0;
 
     virtual AbstractSwInsertDBColAutoPilot* CreateSwInsertDBColAutoPilot(SwView& rView,
         css::uno::Reference< css::sdbc::XDataSource> rxSource,
@@ -360,7 +360,6 @@ public:
     virtual SfxAbstractTabDialog* CreateSwParaDlg ( vcl::Window *pParent,
                                                     SwView& rVw,
                                                     const SfxItemSet& rCoreSet,
-                                                    const OUString *pCollName,
                                                     bool bDraw,
                                                     const OString& sDefPage = OString() ) = 0;
 
@@ -372,15 +371,15 @@ public:
     virtual AbstractSwAutoFormatDlg * CreateSwAutoFormatDlg( vcl::Window* pParent, SwWrtShell* pShell,
                                                             bool bSetAutoFormat = true,
                                                             const SwTableAutoFormat* pSelFormat = nullptr ) = 0;
-    virtual SfxAbstractDialog * CreateSwBorderDlg ( vcl::Window* pParent, SfxItemSet& rSet, SwBorderModes nType, int nResId ) = 0;
-    virtual SfxAbstractDialog * CreateSwWrapDlg ( vcl::Window* pParent, SfxItemSet& rSet, SwWrtShell* pSh, int nResId ) = 0;
+    virtual SfxAbstractDialog * CreateSwBorderDlg ( vcl::Window* pParent, SfxItemSet& rSet, SwBorderModes nType ) = 0;
+    virtual SfxAbstractDialog * CreateSwWrapDlg ( vcl::Window* pParent, SfxItemSet& rSet, SwWrtShell* pSh ) = 0;
 
     virtual VclAbstractDialog * CreateSwTableWidthDlg(vcl::Window *pParent, SwTableFUNC &rFnc) = 0;
     virtual SfxAbstractTabDialog* CreateSwTableTabDlg(vcl::Window* pParent, SfxItemPool& Pool,
         const SfxItemSet* pItemSet, SwWrtShell* pSh) = 0;
 
     virtual AbstractSwFieldDlg * CreateSwFieldDlg(SfxBindings* pB, SwChildWinWrapper* pCW, vcl::Window *pParent) = 0;
-    virtual SfxAbstractDialog*   CreateSwFieldEditDlg ( SwView& rVw, int nResId ) = 0;
+    virtual SfxAbstractDialog*   CreateSwFieldEditDlg ( SwView& rVw ) = 0;
     virtual AbstractSwRenameXNamedDlg * CreateSwRenameXNamedDlg(vcl::Window* pParent,
         css::uno::Reference< css::container::XNamed > & xNamed,
         css::uno::Reference< css::container::XNameAccess > & xNameAccess) = 0;
@@ -391,8 +390,7 @@ public:
                                                 SfxViewFrame *pFrame, vcl::Window *pParent,
                                                 const SfxItemSet& rCoreSet,
                                                 bool bNewFrame = true,
-                                                const OString& sDefPage = OString(),
-                                                const OUString* pFormatStr = nullptr) = 0;
+                                                const OString& sDefPage = OString()) = 0;
     /// @param nSlot
     /// Identifies optional Slot by which the creation of the Template (Style) dialog is triggered.
     /// Currently used, if nRegion == SfxStyleFamily::Page in order to activate certain dialog pane
@@ -414,7 +412,7 @@ public:
     virtual AbstractInsTableDlg*        CreateInsTableDlg(SwView& rView) = 0;
     virtual AbstractJavaEditDialog*     CreateJavaEditDialog(vcl::Window* pParent,
         SwWrtShell* pWrtSh) = 0;
-    virtual AbstractMailMergeDlg*       CreateMailMergeDlg( int nResId,
+    virtual AbstractMailMergeDlg*       CreateMailMergeDlg(
                                                 vcl::Window* pParent, SwWrtShell& rSh,
                                                 const OUString& rSourceName,
                                                 const OUString& rTableName,
@@ -430,7 +428,7 @@ public:
     virtual AbstractMultiTOXTabDialog*      CreateMultiTOXTabDialog(
                                                 vcl::Window* pParent, const SfxItemSet& rSet,
                                                 SwWrtShell &rShell,
-                                                SwTOXBase* pCurTOX, sal_uInt16 nToxType,
+                                                SwTOXBase* pCurTOX,
                                                 bool bGlobal) = 0;
     virtual AbstractEditRegionDlg*      CreateEditRegionDlg(vcl::Window* pParent, SwWrtShell& rWrtSh) = 0;
     virtual AbstractInsertSectionTabDialog*     CreateInsertSectionTabDialog(
diff --git a/sw/inc/swcrsr.hxx b/sw/inc/swcrsr.hxx
index 0e9d7d351be8..b8c269a2ddc9 100644
--- a/sw/inc/swcrsr.hxx
+++ b/sw/inc/swcrsr.hxx
@@ -271,7 +271,7 @@ protected:
     virtual bool IsSelOvrCheck(int eFlags) override;
 
 public:
-    SwTableCursor( const SwPosition &rPos, SwPaM* pRing = nullptr );
+    SwTableCursor( const SwPosition &rPos );
     SwTableCursor( SwTableCursor& );
     virtual ~SwTableCursor();
 
diff --git a/sw/inc/swtable.hxx b/sw/inc/swtable.hxx
index 303b1dc18354..619bd8f08920 100644
--- a/sw/inc/swtable.hxx
+++ b/sw/inc/swtable.hxx
@@ -128,8 +128,7 @@ public:
     };
 
 
-    // single argument ctors shall be explicit.
-    explicit SwTable( SwTableFormat* );
+    explicit SwTable();
     virtual ~SwTable();
 
     // @@@ public copy ctor, but no copy assignment?
diff --git a/sw/inc/txatritr.hxx b/sw/inc/txatritr.hxx
index 471c668fe348..665df194f29d 100644
--- a/sw/inc/txatritr.hxx
+++ b/sw/inc/txatritr.hxx
@@ -74,9 +74,8 @@ public:
 class SwLanguageIterator : public SwTextAttrIterator
 {
 public:
-    SwLanguageIterator( const SwTextNode& rTextNode, sal_Int32 nStart = 0,
-                        sal_uInt16 nWhich = RES_CHRATR_LANGUAGE )
-        : SwTextAttrIterator( rTextNode, nWhich, nStart )
+    SwLanguageIterator( const SwTextNode& rTextNode, sal_Int32 nStart = 0 )
+        : SwTextAttrIterator( rTextNode, RES_CHRATR_LANGUAGE, nStart )
     {}
 
     sal_uInt16 GetLanguage() const
diff --git a/sw/inc/unocrsr.hxx b/sw/inc/unocrsr.hxx
index 9ee9261de581..a06fd71bdf77 100644
--- a/sw/inc/unocrsr.hxx
+++ b/sw/inc/unocrsr.hxx
@@ -39,7 +39,7 @@ private:
     bool m_bSkipOverProtectSections : 1;
 
 public:
-    SwUnoCursor( const SwPosition &rPos, SwPaM* pRing = nullptr );
+    SwUnoCursor( const SwPosition &rPos );
     virtual ~SwUnoCursor();
 
 protected:
diff --git a/sw/inc/unosett.hxx b/sw/inc/unosett.hxx
index dff4f1f8aee0..ad80037d3797 100644
--- a/sw/inc/unosett.hxx
+++ b/sw/inc/unosett.hxx
@@ -263,7 +263,7 @@ class SwXTextColumns : public cppu::WeakAggImplHelper4
 protected:
     virtual ~SwXTextColumns();
 public:
-    SwXTextColumns(sal_uInt16 nColCount);
+    SwXTextColumns();
     SwXTextColumns(const SwFormatCol& rFormatCol);
 
     static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId();
diff --git a/sw/inc/view.hxx b/sw/inc/view.hxx
index 76d1a341c6ec..636e917ef922 100644
--- a/sw/inc/view.hxx
+++ b/sw/inc/view.hxx
@@ -621,8 +621,7 @@ public:
 
     //public fuer D&D
     int     InsertGraphic( const OUString &rPath, const OUString &rFilter,
-                            bool bLink, GraphicFilter *pFlt,
-                            Graphic* pPreviewGrf = nullptr );
+                            bool bLink, GraphicFilter *pFlt );
 
     void ExecuteScan( SfxRequest& rReq );
 
diff --git a/sw/inc/wdocsh.hxx b/sw/inc/wdocsh.hxx
index 286c16ddade0..3e0cf53aecea 100644
--- a/sw/inc/wdocsh.hxx
+++ b/sw/inc/wdocsh.hxx
@@ -35,7 +35,7 @@ private:
     static void InitInterface_Impl();
 
 public:
-    SwWebDocShell(SfxObjectCreateMode eMode = SfxObjectCreateMode::EMBEDDED);
+    SwWebDocShell();
     virtual ~SwWebDocShell();
 
     virtual void        FillClass( SvGlobalName * pClassName,