improve the returnbyref loplugin

Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

9 files changed, 45 insertions, 45 deletions

diff --git a/sw/inc/SidebarWin.hxx b/sw/inc/SidebarWin.hxx
index e438ed0a76a7..21d7dc754d7d 100644
--- a/sw/inc/SidebarWin.hxx
+++ b/sw/inc/SidebarWin.hxx
@@ -80,7 +80,7 @@ class SwSidebarWin : public vcl::Window
         void CheckMetaText();
 
         inline Point GetAnchorPos() { return mAnchorRect.Pos(); }
-        SwEditWin* EditWin();
+        SwEditWin& EditWin();
 
         inline OutlinerView* GetOutlinerView() { return mpOutlinerView;}
         bool HasScrollbar() const;
diff --git a/sw/inc/docsh.hxx b/sw/inc/docsh.hxx
index d76c0cc26664..963b8b917962 100644
--- a/sw/inc/docsh.hxx
+++ b/sw/inc/docsh.hxx
@@ -204,9 +204,9 @@ public:
     /// returns Doc. But be careful!
     inline SwDoc*                   GetDoc() { return m_pDoc; }
     inline const SwDoc*             GetDoc() const { return m_pDoc; }
-    IDocumentDeviceAccess*          getIDocumentDeviceAccess();
-    const IDocumentSettingAccess*   getIDocumentSettingAccess() const;
-    IDocumentChartDataProviderAccess*       getIDocumentChartDataProviderAccess();
+    IDocumentDeviceAccess&          getIDocumentDeviceAccess();
+    const IDocumentSettingAccess&   getIDocumentSettingAccess() const;
+    IDocumentChartDataProviderAccess& getIDocumentChartDataProviderAccess();
 
     void                    UpdateFontList();
     void                    UpdateChildWindows();
diff --git a/sw/inc/format.hxx b/sw/inc/format.hxx
index 83bdf16b8932..68a01bd1e281 100644
--- a/sw/inc/format.hxx
+++ b/sw/inc/format.hxx
@@ -126,24 +126,24 @@ public:
           SwDoc *GetDoc()               { return m_aSet.GetDoc(); }
 
     /// Provides access to the document settings interface.
-    const IDocumentSettingAccess* getIDocumentSettingAccess() const;
+    const IDocumentSettingAccess& getIDocumentSettingAccess() const;
 
     /// Provides access to the document draw model interface.
-    const IDocumentDrawModelAccess* getIDocumentDrawModelAccess() const;
-          IDocumentDrawModelAccess* getIDocumentDrawModelAccess();
+    const IDocumentDrawModelAccess& getIDocumentDrawModelAccess() const;
+          IDocumentDrawModelAccess& getIDocumentDrawModelAccess();
 
     /// Provides access to the document layout interface.
-    const IDocumentLayoutAccess* getIDocumentLayoutAccess() const;
-          IDocumentLayoutAccess* getIDocumentLayoutAccess();
+    const IDocumentLayoutAccess& getIDocumentLayoutAccess() const;
+          IDocumentLayoutAccess& getIDocumentLayoutAccess();
 
      /// Provides access to the document idle timer interface.
-     IDocumentTimerAccess* getIDocumentTimerAccess();
+     IDocumentTimerAccess& getIDocumentTimerAccess();
 
      /// Provides access to the document idle timer interface.
-    IDocumentFieldsAccess* getIDocumentFieldsAccess();
+    IDocumentFieldsAccess& getIDocumentFieldsAccess();
 
      /// Gives access to the chart data-provider.
-    IDocumentChartDataProviderAccess* getIDocumentChartDataProviderAccess();
+    IDocumentChartDataProviderAccess& getIDocumentChartDataProviderAccess();
 
     /// Get and set Pool style IDs.
     sal_uInt16 GetPoolFormatId() const { return m_nPoolFormatId; }
diff --git a/sw/inc/node.hxx b/sw/inc/node.hxx
index bc8f8d090a31..415483558a8d 100644
--- a/sw/inc/node.hxx
+++ b/sw/inc/node.hxx
@@ -210,7 +210,7 @@ public:
 
     /** Provides access to the document device interface
      */
-    const IDocumentDeviceAccess* getIDocumentDeviceAccess() const;
+    const IDocumentDeviceAccess& getIDocumentDeviceAccess() const;
 
     /** Provides access to the document bookmark interface
      */
@@ -218,34 +218,34 @@ public:
 
     /** Provides access to the document redline interface
      */
-    const IDocumentRedlineAccess* getIDocumentRedlineAccess() const;
+    const IDocumentRedlineAccess& getIDocumentRedlineAccess() const;
 
     /** Provides access to the document style pool interface
      */
-    const IDocumentStylePoolAccess* getIDocumentStylePoolAccess() const;
+    const IDocumentStylePoolAccess& getIDocumentStylePoolAccess() const;
 
     /** Provides access to the document draw model interface
      */
-    const IDocumentDrawModelAccess* getIDocumentDrawModelAccess() const;
+    const IDocumentDrawModelAccess& getIDocumentDrawModelAccess() const;
 
     /** Provides access to the document layout interface
      */
-    const IDocumentLayoutAccess* getIDocumentLayoutAccess() const;
-          IDocumentLayoutAccess* getIDocumentLayoutAccess();
+    const IDocumentLayoutAccess& getIDocumentLayoutAccess() const;
+          IDocumentLayoutAccess& getIDocumentLayoutAccess();
 
     /** Provides access to the document links administration interface
      */
-    const IDocumentLinksAdministration* getIDocumentLinksAdministration() const;
-          IDocumentLinksAdministration* getIDocumentLinksAdministration();
+    const IDocumentLinksAdministration& getIDocumentLinksAdministration() const;
+          IDocumentLinksAdministration& getIDocumentLinksAdministration();
 
     /** Provides access to the document fields administration interface
      */
-    const IDocumentFieldsAccess* getIDocumentFieldsAccess() const;
-          IDocumentFieldsAccess* getIDocumentFieldsAccess();
+    const IDocumentFieldsAccess& getIDocumentFieldsAccess() const;
+          IDocumentFieldsAccess& getIDocumentFieldsAccess();
 
     /** Provides access to the document content operations interface
      */
-          IDocumentContentOperations* getIDocumentContentOperations();
+          IDocumentContentOperations& getIDocumentContentOperations();
 
     /** Provides access to the document automatic styles interface
      */
diff --git a/sw/inc/shellio.hxx b/sw/inc/shellio.hxx
index da2622d60241..d267b95a6698 100644
--- a/sw/inc/shellio.hxx
+++ b/sw/inc/shellio.hxx
@@ -387,11 +387,11 @@ protected:
     virtual sal_uLong WriteStream() = 0;
     void                SetBaseURL( const OUString& rURL ) { sBaseURL = rURL; }
 
-    IDocumentSettingAccess* getIDocumentSettingAccess();
-    const IDocumentSettingAccess* getIDocumentSettingAccess() const;
+    IDocumentSettingAccess& getIDocumentSettingAccess();
+    const IDocumentSettingAccess& getIDocumentSettingAccess() const;
 
-    IDocumentStylePoolAccess* getIDocumentStylePoolAccess();
-    const IDocumentStylePoolAccess* getIDocumentStylePoolAccess() const;
+    IDocumentStylePoolAccess& getIDocumentStylePoolAccess();
+    const IDocumentStylePoolAccess& getIDocumentStylePoolAccess() const;
 
 public:
     SwDoc* pDoc;
diff --git a/sw/inc/unotbl.hxx b/sw/inc/unotbl.hxx
index 810be4dce8a1..8b600dc9270a 100644
--- a/sw/inc/unotbl.hxx
+++ b/sw/inc/unotbl.hxx
@@ -273,8 +273,8 @@ public:
     virtual const SwDoc*        GetDoc() const SAL_OVERRIDE;
     virtual SwDoc*              GetDoc() SAL_OVERRIDE;
 
-    const SwUnoCrsr*            GetCrsr() const;
-    SwUnoCrsr*                  GetCrsr();
+    const SwUnoCrsr&            GetCrsr() const;
+    SwUnoCrsr&                  GetCrsr();
     sw::UnoCursorPointer m_pUnoCrsr;
     SwFrameFormat*       GetFrameFormat() const { return const_cast<SwFrameFormat*>(static_cast<const SwFrameFormat*>(GetRegisteredIn())); }
     virtual ~SwXTextTableCursor() { };
diff --git a/sw/inc/unotextcursor.hxx b/sw/inc/unotextcursor.hxx
index b54bca4cecd4..ef20abd046c6 100644
--- a/sw/inc/unotextcursor.hxx
+++ b/sw/inc/unotextcursor.hxx
@@ -91,7 +91,7 @@ public:
             SwPaM const& rSourceCursor,
             const enum CursorType eType = CURSOR_ALL);
 
-    SwUnoCrsr* GetCursor();
+    SwUnoCrsr& GetCursor();
     bool IsAtEndOfMeta() const;
 
     void DeleteAndInsert(OUString const& rText,
diff --git a/sw/inc/unotextrange.hxx b/sw/inc/unotextrange.hxx
index 19f6ae3beeb7..552ac6b14806 100644
--- a/sw/inc/unotextrange.hxx
+++ b/sw/inc/unotextrange.hxx
@@ -116,8 +116,8 @@ public:
     // only for RANGE_IS_TABLE
     SwXTextRange(SwFrameFormat& rTableFormat);
 
-    const SwDoc* GetDoc() const;
-          SwDoc* GetDoc();
+    const SwDoc& GetDoc() const;
+          SwDoc& GetDoc();
     bool GetPositions(SwPaM & rToFill) const;
 
     static ::com::sun::star::uno::Reference<
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index 9e77272d5a0e..b17c3a9fd685 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -294,13 +294,13 @@ public:
 
     /** Provides access to the document setting interface
      */
-    const IDocumentSettingAccess* getIDocumentSettingAccess() const;
-          IDocumentSettingAccess* getIDocumentSettingAccess();
+    const IDocumentSettingAccess& getIDocumentSettingAccess() const;
+          IDocumentSettingAccess& getIDocumentSettingAccess();
 
     /** Provides access to the document device interface
      */
-    const IDocumentDeviceAccess* getIDocumentDeviceAccess() const;
-          IDocumentDeviceAccess* getIDocumentDeviceAccess();
+    const IDocumentDeviceAccess& getIDocumentDeviceAccess() const;
+          IDocumentDeviceAccess& getIDocumentDeviceAccess();
 
     /** Provides access to the document bookmark interface
      */
@@ -309,30 +309,30 @@ public:
 
     /** Provides access to the document draw model interface
      */
-    const IDocumentDrawModelAccess* getIDocumentDrawModelAccess() const;
-          IDocumentDrawModelAccess* getIDocumentDrawModelAccess();
+    const IDocumentDrawModelAccess& getIDocumentDrawModelAccess() const;
+          IDocumentDrawModelAccess& getIDocumentDrawModelAccess();
 
     /** Provides access to the document redline interface
      */
-    const IDocumentRedlineAccess* getIDocumentRedlineAccess() const;
-          IDocumentRedlineAccess* getIDocumentRedlineAccess();
+    const IDocumentRedlineAccess& getIDocumentRedlineAccess() const;
+          IDocumentRedlineAccess& getIDocumentRedlineAccess();
 
     /** Provides access to the document layout interface
      */
-    const IDocumentLayoutAccess* getIDocumentLayoutAccess() const;
-          IDocumentLayoutAccess* getIDocumentLayoutAccess();
+    const IDocumentLayoutAccess& getIDocumentLayoutAccess() const;
+          IDocumentLayoutAccess& getIDocumentLayoutAccess();
 
     /** Provides access to the content operations interface
      */
-    IDocumentContentOperations* getIDocumentContentOperations();
+    IDocumentContentOperations& getIDocumentContentOperations();
 
     /** Provides access to the document style pool interface
      */
-    IDocumentStylePoolAccess* getIDocumentStylePoolAccess();
+    IDocumentStylePoolAccess& getIDocumentStylePoolAccess();
 
     /** Provides access to the document statistics interface
      */
-    const IDocumentStatistics* getIDocumentStatistics() const;
+    const IDocumentStatistics& getIDocumentStatistics() const;
 
     /** Provides access to the document undo/redo interface
      */