diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-14 17:14:18 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-11 11:38:15 +0200 |
| commit | 1f08bff31238d5818c54a0b86570689644dff087 (patch) | |
| tree | d4d6f4b62a3c48ddeb85ba89818247c17f2578c8 /sw/inc | |
| parent | ff130af9661a57d290dbf89b54a4c0ce8d0f71ea (diff) | |
new loplugin:shouldreturnbool
look for methods returning only 1 and/or 0, which (most of the time)
should be returning bool.
Off by default, because some of this is a matter of taste
Change-Id: Ib17782e629888255196e89d4a178618a9612a0de
Reviewed-on: https://gerrit.libreoffice.org/54379
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/inc')
| -rw-r--r-- | sw/inc/editsh.hxx | 2 | ||||
| -rw-r--r-- | sw/inc/view.hxx | 16 |
2 files changed, 9 insertions, 9 deletions
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx index 42a542ff3502..07308fa4db3d 100644 --- a/sw/inc/editsh.hxx +++ b/sw/inc/editsh.hxx @@ -202,7 +202,7 @@ public: Copy all selections to the document. */ bool CopySelToDoc( SwDoc* pInsDoc ); - long SplitNode( bool bAutoFormat = false, bool bCheckTableStart = true ); + void SplitNode( bool bAutoFormat = false, bool bCheckTableStart = true ); bool AppendTextNode(); void AutoFormatBySplitNode(); diff --git a/sw/inc/view.hxx b/sw/inc/view.hxx index a3eddaedf991..cb32b2180a32 100644 --- a/sw/inc/view.hxx +++ b/sw/inc/view.hxx @@ -279,12 +279,12 @@ class SW_DLLPUBLIC SwView: public SfxViewShell SAL_DLLPRIVATE bool GetPageScrollDownOffset(SwTwips& rOff) const; // scrollbar movements - SAL_DLLPRIVATE long PageUp(); - SAL_DLLPRIVATE long PageDown(); + SAL_DLLPRIVATE bool PageUp(); + SAL_DLLPRIVATE bool PageDown(); SAL_DLLPRIVATE bool PageUpCursor(bool bSelect); SAL_DLLPRIVATE bool PageDownCursor(bool bSelect); - SAL_DLLPRIVATE long PhyPageUp(); - SAL_DLLPRIVATE long PhyPageDown(); + SAL_DLLPRIVATE void PhyPageUp(); + SAL_DLLPRIVATE void PhyPageDown(); SAL_DLLPRIVATE void CreateScrollbar( bool bHori ); DECL_DLLPRIVATE_LINK( ScrollHdl, ScrollBar*, void ); @@ -472,10 +472,10 @@ public: void EnableHScrollbar(bool bEnable); void EnableVScrollbar(bool bEnable); - int CreateVRuler(); - int KillVRuler(); - int CreateTab(); - int KillTab(); + void CreateVRuler(); + void KillVRuler(); + void CreateTab(); + void KillTab(); bool StatVRuler() const { return m_pVRuler->IsVisible(); } void ChangeVRulerMetric(FieldUnit eUnit); |