diff options
author | Maxim Monastirsky <momonasmon@gmail.com> | 2018-04-15 22:28:32 +0300 |
---|---|---|
committer | Andras Timar <andras.timar@collabora.com> | 2018-05-15 10:15:06 +0200 |
commit | 9d45a4bc2eb75dacf192dd5208c1b335dc144552 (patch) | |
tree | 1be7994a7f06a43f779afaa2d143ca4c86b22208 /sw/qa/extras/ooxmlexport/ooxmlexport11.cxx | |
parent | 44b4313d9f73f48f42dd3a443081a573b818d185 (diff) |
tdf#117017 Make modifier keys not trigger the InputChanged handler
(cherry picked from commit a860c94f0da22065074cc36e8ddda73261641533)
sc: Fix menubar auto-accelerator behavior under gtk2
... when the focus is in the input field of the formula bar.
Regression of commit d90dcf3554a84b5600800ee6deb3cde879c62b8d
("tdf#113894 release ctrl of ctrl+v in input line should strip
formatting").
(cherry picked from commit baddcc38dee7b286cc73c1eaeb6f78d10b911a8e)
tdf#117017 Pasting into the formula bar shouldn't retain formatting
This is (kind of) regression from the previous commit
a860c94f0da22065074cc36e8ddda73261641533 ("tdf#117017 Make modifier
keys not trigger the InputChanged handler").
Reset of formatting when pasting into the formula bar via a keyboard
shortcut, was actually a side effect of the gtk auto-accelerator
work. In particual, bibisect (of the 5.2 cycle) points to commit
8d53d01f38b856f177aca3ed4d3cba3db10f24a5 ("tdf#96739: Send Ctrl-Left/
RightShift events to correct window"). The behavior was later changed
back with commit 0321dbb9be72f92c02919457cdc3c4e76cfbd11d
("Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with
alt"), but introduced again upon request of tdf#113894, with commit
d90dcf3554a84b5600800ee6deb3cde879c62b8d ("tdf#113894 release ctrl of
ctrl+v in input line should strip formatting"). Now it's broken again
with the previous commit of this bug.
However, even if not retaining formatting is the desired behavior,
triggering it on a modifier key release isn't a good idea. So keep
the previous commit, and implement tdf#113894 differently. In
addition, make sure to get identical behavior regardless of the
pasting method, be it via a keyboard shortcut, a toolbar button or a
menu/context menu command. And users can still override this behavior
with the usual paste special dialog, or the toolbar dropdown.
(cherry picked from commit 632bc11ce8fab1c4046ab24810b90a7ce9ac5914)
Change-Id: Ib05883688ef4143c0b53871c4336920dde6f91cc
Reviewed-on: https://gerrit.libreoffice.org/53144
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 599ab0f82ebcb29a5205d77daed72b842e839800)
Diffstat (limited to 'sw/qa/extras/ooxmlexport/ooxmlexport11.cxx')
0 files changed, 0 insertions, 0 deletions