diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2022-08-24 21:03:01 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-08-25 07:57:57 +0200 |
| commit | 3369a24c48781fd5b8afe9bb707f92588825f6c3 (patch) | |
| tree | 2de3c836288eed0bc6debd1b9722a663b4e0442a /sw/qa/extras/ww8import | |
| parent | f7e170eb084cd4e92818de966b287330184749a8 (diff) | |
Use SwNode instead of SwNodeIndex in SwPosFlyFrame
part of hiding the internals of SwPosition.
Also
(*) Just define the whole class in the header, it is a
dead simple data carrier.
Then the virtual destructor and the SAL_DLLPUBLIC_RTTI
becomes unnecessary.
(*) No need to use shared_ptr, these are never
shared, the call sites read the data and then discard
them.
Change-Id: I7fb64fd2bfa3469a7dfa4a325bb508457ca759a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138776
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/qa/extras/ww8import')
| -rw-r--r-- | sw/qa/extras/ww8import/ww8import.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sw/qa/extras/ww8import/ww8import.cxx b/sw/qa/extras/ww8import/ww8import.cxx index ab35fa9d7346..c41b86d2f8e2 100644 --- a/sw/qa/extras/ww8import/ww8import.cxx +++ b/sw/qa/extras/ww8import/ww8import.cxx @@ -156,9 +156,9 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf121734) SwPosFlyFrames aPosFlyFrames = pDoc->GetAllFlyFormats(nullptr, false); // There is only one fly frame in the document: the one with the imported floating table CPPUNIT_ASSERT_EQUAL(size_t(1), aPosFlyFrames.size()); - for (const auto& rPosFlyFrame : aPosFlyFrames) + for (const SwPosFlyFrame& rPosFlyFrame : aPosFlyFrames) { - const SwFrameFormat& rFormat = rPosFlyFrame->GetFormat(); + const SwFrameFormat& rFormat = rPosFlyFrame.GetFormat(); const SfxPoolItem* pItem = nullptr; // The LR and UL spacings and borders must all be set explicitly; @@ -225,9 +225,9 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf122425_1) SwPosFlyFrames aPosFlyFrames = pDoc->GetAllFlyFormats(nullptr, false); // There are two fly frames in the document: for first page's header, and for other pages' CPPUNIT_ASSERT_EQUAL(size_t(2), aPosFlyFrames.size()); - for (const auto& rPosFlyFrame : aPosFlyFrames) + for (const SwPosFlyFrame& rPosFlyFrame : aPosFlyFrames) { - const SwFrameFormat& rFormat = rPosFlyFrame->GetFormat(); + const SwFrameFormat& rFormat = rPosFlyFrame.GetFormat(); const SfxPoolItem* pItem = nullptr; // The LR and UL spacings and borders must all be set explicitly; |