diff options
| author | Justin Luth <jluth@mail.com> | 2022-07-21 13:56:30 -0400 |
|---|---|---|
| committer | Justin Luth <jluth@mail.com> | 2022-12-19 17:57:10 +0000 |
| commit | be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928 (patch) | |
| tree | 54d4c4eafeffc090c9726007fde307e103421c0d /sw/sdi/swriter.sdi | |
| parent | 97e93861dd5ed52d742355f043e9cd628c1bc8f8 (diff) | |
[API CHANGE] tdf#85592: deprecate .uno:BackColor, use .uno:CharBackColor
EditEngine stuff uses CharBackColor, while SW used BackColor.
Deprecate the SW-only SID.
What does this do?
It allows the toolbar "Character Highlighting Color"
to work with both body text (previously BackColor)
and comment text(CharBackColor).
Otherwise, the toolbar item was disabled when moving into
a comment. (Shapes/Textboxes got their own formatting toolbar,
so those are unaffected.)
AFAIK, after this commit, SID_ATTR_CHAR_COLOR_BACKGROUND
should still work fine for API calls, or for customized toolbars.
That's why I didn't try to remove it completely - just deprecate.
Do I know what I am doing here?
No, although I'm fairly confident nontheless,
and I've had some good help from reviewers.
Change-Id: I0afcbdb1b91c872f6d47f3c82c573f3b9fea6dfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137334
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Diffstat (limited to 'sw/sdi/swriter.sdi')
| -rw-r--r-- | sw/sdi/swriter.sdi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi index 8cff1d26be35..55678973acd1 100644 --- a/sw/sdi/swriter.sdi +++ b/sw/sdi/swriter.sdi @@ -377,7 +377,7 @@ SfxVoidItem AutoSum FN_TABLE_AUTOSUM GroupId = SfxGroupId::Table; ] -SvxColorItem BackColor SID_ATTR_CHAR_COLOR_BACKGROUND +SvxColorItem BackColor SID_ATTR_CHAR_COLOR_BACKGROUND // deprecated - use CHAR_BACK_COLOR (SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem BackColor SID_ATTR_CHAR_COLOR_BACKGROUND) [ |