diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2023-10-20 14:35:51 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2023-10-20 19:05:55 +0200 |
| commit | 113c4566933b798e3de4daf9e276ce24cdb8e773 (patch) | |
| tree | 44bf1d332cc003d61991aef2928b44fadadde857 /sw/source/core | |
| parent | b60b3b5bbcc8db61bb24d3866b48cb4c63eb4f30 (diff) | |
Avoid double notifications for deletion case
Follow-up to commit 34ac12dca3f5af50fddfb7c77e2943897980b815
When old redline is own Insert, and the new one is Delete, it means
that it was already handled in DocumentRedlineManager::DeleteRedline.
This also reverts the unit test change done in the mentioned commit.
Change-Id: I77e59dceb1c880fc6ec10ad98867be3bf5282f70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158253
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sw/source/core')
| -rw-r--r-- | sw/source/core/doc/DocumentRedlineManager.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sw/source/core/doc/DocumentRedlineManager.cxx b/sw/source/core/doc/DocumentRedlineManager.cxx index 7a9af1ee8891..5ac574b54858 100644 --- a/sw/source/core/doc/DocumentRedlineManager.cxx +++ b/sw/source/core/doc/DocumentRedlineManager.cxx @@ -1842,8 +1842,8 @@ DocumentRedlineManager::AppendRedline(SwRangeRedline* pNewRedl, bool const bCall delete pNewRedl; pNewRedl = nullptr; - if (!bDec) - MaybeNotifyRedlineModification(*pRedl, m_rDoc); + // No need to call MaybeNotifyRedlineModification, because a notification + // was already sent in DocumentRedlineManager::DeleteRedline break; case SwComparePosition::Outside: |