diff options
author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /sw/source/filter/html | |
parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/source/filter/html')
-rw-r--r-- | sw/source/filter/html/swhtml.hxx | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sw/source/filter/html/swhtml.hxx b/sw/source/filter/html/swhtml.hxx index 9fb7dbfce7b5..7fc910600d75 100644 --- a/sw/source/filter/html/swhtml.hxx +++ b/sw/source/filter/html/swhtml.hxx @@ -759,8 +759,8 @@ private: void NewStyle(); void EndStyle(); - static inline bool HasStyleOptions( const OUString &rStyle, const OUString &rId, - const OUString &rClass, const OUString *pLang=nullptr, + static inline bool HasStyleOptions( std::u16string_view rStyle, std::u16string_view rId, + std::u16string_view rClass, const OUString *pLang=nullptr, const OUString *pDir=nullptr ); bool ParseStyleOptions( const OUString &rStyle, const OUString &rId, const OUString &rClass, SfxItemSet &rItemSet, @@ -1008,13 +1008,13 @@ inline void HTMLAttrContext::GetULSpace( sal_uInt16& rUpper, } } -inline bool SwHTMLParser::HasStyleOptions( const OUString &rStyle, - const OUString &rId, - const OUString &rClass, +inline bool SwHTMLParser::HasStyleOptions( std::u16string_view rStyle, + std::u16string_view rId, + std::u16string_view rClass, const OUString *pLang, const OUString *pDir ) { - return !rStyle.isEmpty() || !rId.isEmpty() || !rClass.isEmpty() || + return !rStyle.empty() || !rId.empty() || !rClass.empty() || (pLang && !pLang->isEmpty()) || (pDir && !pDir->isEmpty()); } |