summaryrefslogtreecommitdiff
path: root/sw/source/filter/xml
diff options
context:
space:
mode:
authorBjoern Michaelsen <bjoern.michaelsen@libreoffice.org>2021-01-09 21:49:51 +0100
committerBjoern Michaelsen <bjoern.michaelsen@libreoffice.org>2021-01-13 18:20:09 +0100
commitfcb6e076d9004ef907a2616d04bf9c39908e6e8a (patch)
tree28f691da69e537efb1162bec2d1183ddc82154e8 /sw/source/filter/xml
parent6ce3e7b615193f610add5428d2157f31600dec52 (diff)
SfxPoolItem: introduce StaticWhichCast and DynamicWhichCast
- at least in Writer it is a common pattern to switch case on a Which and then static_cast the SfxPoolItem to the assumed "right" type - instead, it would much less errorprone to use the TypedWhichId to be sure to cast to the right, matching type for an id - also, this allow to assert the dynamic_cast in debug build to highlight type confusion - finally, there is some example use added in sw showing how it gets rid of explicit manual lookup of the type to cast to - likely, many of the static_cast<TypedWhichId>(SfxPoolItem*) can be found and replaced with a compiler plugin. This is left as an exercise to the reader. - alternatively, this might be a nice easy EasyHack to start .... Change-Id: I00110c0fe25626bc89d835e3c4e7ff75839756b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109042 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
Diffstat (limited to 'sw/source/filter/xml')
0 files changed, 0 insertions, 0 deletions