Revert "loplugin:constfields in sw"

This reverts commit 4969f4c0d3e2581aaa8a5b5a5769840fa6b6f8ea.

Change-Id: I527e9366b05e8a20633720e334395b285991c524
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90473
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

22 files changed, 32 insertions, 32 deletions

diff --git a/sw/source/ui/vba/vbaaddin.hxx b/sw/source/ui/vba/vbaaddin.hxx
index f74e77fcb2bd..7b66b6ba6218 100644
--- a/sw/source/ui/vba/vbaaddin.hxx
+++ b/sw/source/ui/vba/vbaaddin.hxx
@@ -27,7 +27,7 @@ typedef InheritedHelperInterfaceWeakImpl< ooo::vba::word::XAddin > SwVbaAddin_BA
 class SwVbaAddin : public SwVbaAddin_BASE
 {
 private:
-    OUString const msFileURL;
+    OUString msFileURL;
     bool mbInstalled;
 
 public:
diff --git a/sw/source/ui/vba/vbabookmark.hxx b/sw/source/ui/vba/vbabookmark.hxx
index e6130fc5158d..6333354262c9 100644
--- a/sw/source/ui/vba/vbabookmark.hxx
+++ b/sw/source/ui/vba/vbabookmark.hxx
@@ -30,7 +30,7 @@ class SwVbaBookmark : public SwVbaBookmark_BASE
 private:
     css::uno::Reference< css::frame::XModel > mxModel;
     css::uno::Reference< css::text::XTextContent > mxBookmark;
-    OUString const maBookmarkName;
+    OUString maBookmarkName;
     bool mbValid;
 
 private:
diff --git a/sw/source/ui/vba/vbaborders.cxx b/sw/source/ui/vba/vbaborders.cxx
index 687a32594154..5561bbfcbc76 100644
--- a/sw/source/ui/vba/vbaborders.cxx
+++ b/sw/source/ui/vba/vbaborders.cxx
@@ -45,7 +45,7 @@ class SwVbaBorder : public SwVbaBorder_Base
 {
 private:
     uno::Reference< beans::XPropertySet > m_xProps;
-    sal_Int32 const m_LineType;
+    sal_Int32 m_LineType;
     void setBorderLine( table::BorderLine const & rBorderLine )
     {
         table::TableBorder aTableBorder;
@@ -229,7 +229,7 @@ class RangeBorders : public RangeBorders_Base
 private:
     uno::Reference< table::XCellRange > m_xRange;
     uno::Reference< uno::XComponentContext > m_xContext;
-    VbaPalette const m_Palette;
+    VbaPalette m_Palette;
     sal_Int32 getTableIndex( sal_Int32 nConst )
     {
         // okay return position of the index in the table
diff --git a/sw/source/ui/vba/vbacell.hxx b/sw/source/ui/vba/vbacell.hxx
index 5d5b99476346..9c9e7524e43f 100644
--- a/sw/source/ui/vba/vbacell.hxx
+++ b/sw/source/ui/vba/vbacell.hxx
@@ -29,8 +29,8 @@ class SwVbaCell : public SwVbaCell_BASE
 {
 private:
     css::uno::Reference< css::text::XTextTable > mxTextTable;
-    sal_Int32 const mnColumn;
-    sal_Int32 const mnRow;
+    sal_Int32 mnColumn;
+    sal_Int32 mnRow;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbacells.cxx b/sw/source/ui/vba/vbacells.cxx
index 9bb2a145aa72..72daf252cb69 100644
--- a/sw/source/ui/vba/vbacells.cxx
+++ b/sw/source/ui/vba/vbacells.cxx
@@ -57,10 +57,10 @@ private:
     uno::Reference< XHelperInterface > mxParent;
     uno::Reference< uno::XComponentContext > mxContext;
     uno::Reference< css::text::XTextTable > mxTextTable;
-    sal_Int32 const mnLeft;
-    sal_Int32 const mnTop;
-    sal_Int32 const mnRight;
-    sal_Int32 const mnBottom;
+    sal_Int32 mnLeft;
+    sal_Int32 mnTop;
+    sal_Int32 mnRight;
+    sal_Int32 mnBottom;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbacells.hxx b/sw/source/ui/vba/vbacells.hxx
index 7438117479b5..e9de9f532f53 100644
--- a/sw/source/ui/vba/vbacells.hxx
+++ b/sw/source/ui/vba/vbacells.hxx
@@ -29,8 +29,8 @@ class SwVbaCells : public SwVbaCells_BASE
 {
 private:
     css::uno::Reference< css::text::XTextTable > mxTextTable;
-    sal_Int32 const mnTop;
-    sal_Int32 const mnBottom;
+    sal_Int32 mnTop;
+    sal_Int32 mnBottom;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbacolumn.hxx b/sw/source/ui/vba/vbacolumn.hxx
index 3e865d60808f..2c05f3b0e97d 100644
--- a/sw/source/ui/vba/vbacolumn.hxx
+++ b/sw/source/ui/vba/vbacolumn.hxx
@@ -29,7 +29,7 @@ class SwVbaColumn : public SwVbaColumn_BASE
 {
 private:
     css::uno::Reference< css::text::XTextTable > mxTextTable;
-    sal_Int32 const mnIndex;
+    sal_Int32 mnIndex;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbadialog.cxx b/sw/source/ui/vba/vbadialog.cxx
index 4eab159b6a90..c161b5d7c239 100644
--- a/sw/source/ui/vba/vbadialog.cxx
+++ b/sw/source/ui/vba/vbadialog.cxx
@@ -26,7 +26,7 @@ namespace {
 
 struct WordDialogTable
 {
-    sal_Int32 const wdDialog;
+    sal_Int32 wdDialog;
     const char* ooDialog;
 };
 
diff --git a/sw/source/ui/vba/vbadocuments.cxx b/sw/source/ui/vba/vbadocuments.cxx
index 5274a614c7b8..5c8dea110a85 100644
--- a/sw/source/ui/vba/vbadocuments.cxx
+++ b/sw/source/ui/vba/vbadocuments.cxx
@@ -45,7 +45,7 @@ namespace {
 
 class DocumentEnumImpl : public EnumerationHelperImpl
 {
-    uno::Any const m_aApplication;
+    uno::Any m_aApplication;
 public:
     /// @throws uno::RuntimeException
     DocumentEnumImpl( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< container::XEnumeration >& xEnumeration, const uno::Any& aApplication ) : EnumerationHelperImpl( xParent, xContext, xEnumeration ), m_aApplication( aApplication ) {}
diff --git a/sw/source/ui/vba/vbafield.cxx b/sw/source/ui/vba/vbafield.cxx
index 056d7cee42ae..6e3aef2f32b7 100644
--- a/sw/source/ui/vba/vbafield.cxx
+++ b/sw/source/ui/vba/vbafield.cxx
@@ -72,7 +72,7 @@ namespace {
 class SwVbaReadFieldParams
 {
 private:
-    OUString const aData;
+    OUString aData;
     sal_Int32 nLen, nFnd, nNext, nSavPtr;
     OUString aFieldName;
 public:
diff --git a/sw/source/ui/vba/vbaheaderfooter.hxx b/sw/source/ui/vba/vbaheaderfooter.hxx
index d652231d5e9d..fd3a3dea462b 100644
--- a/sw/source/ui/vba/vbaheaderfooter.hxx
+++ b/sw/source/ui/vba/vbaheaderfooter.hxx
@@ -30,8 +30,8 @@ class SwVbaHeaderFooter : public SwVbaHeaderFooter_BASE
 private:
     css::uno::Reference< css::frame::XModel > mxModel;
     css::uno::Reference< css::beans::XPropertySet > mxPageStyleProps;
-    bool const mbHeader;
-    sal_Int32 const mnIndex;
+    bool mbHeader;
+    sal_Int32 mnIndex;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbaheadersfooters.cxx b/sw/source/ui/vba/vbaheadersfooters.cxx
index 246b408ac6e2..03a997d3ff39 100644
--- a/sw/source/ui/vba/vbaheadersfooters.cxx
+++ b/sw/source/ui/vba/vbaheadersfooters.cxx
@@ -33,7 +33,7 @@ private:
     uno::Reference< uno::XComponentContext > mxContext;
     uno::Reference< frame::XModel > mxModel;
     uno::Reference< beans::XPropertySet > mxPageStyleProps;
-    bool const mbHeader;
+    bool mbHeader;
 
 public:
     HeadersFootersIndexAccess( const uno::Reference< XHelperInterface >& xParent, const uno::Reference< uno::XComponentContext >& xContext, const uno::Reference< frame::XModel >& xModel, const uno::Reference< beans::XPropertySet >& xPageStyleProps, bool bHeader ) : mxParent( xParent ), mxContext( xContext ), mxModel( xModel ), mxPageStyleProps( xPageStyleProps ), mbHeader( bHeader ) {}
diff --git a/sw/source/ui/vba/vbaheadersfooters.hxx b/sw/source/ui/vba/vbaheadersfooters.hxx
index 3c6336d35ad0..44aa77cfde4d 100644
--- a/sw/source/ui/vba/vbaheadersfooters.hxx
+++ b/sw/source/ui/vba/vbaheadersfooters.hxx
@@ -29,7 +29,7 @@ class SwVbaHeadersFooters : public SwVbaHeadersFooters_BASE
 private:
     css::uno::Reference< css::frame::XModel > mxModel;
     css::uno::Reference< css::beans::XPropertySet > mxPageStyleProps;
-    bool const mbHeader;
+    bool mbHeader;
 
 public:
     SwVbaHeadersFooters( const css::uno::Reference< ooo::vba::XHelperInterface >& rParent, const css::uno::Reference< css::uno::XComponentContext >& rContext, const css::uno::Reference< css::frame::XModel >& xModel, const css::uno::Reference< css::beans::XPropertySet >& xProps, bool isHeader );
diff --git a/sw/source/ui/vba/vbalistgallery.hxx b/sw/source/ui/vba/vbalistgallery.hxx
index b139e876ab0b..187cdd418dde 100644
--- a/sw/source/ui/vba/vbalistgallery.hxx
+++ b/sw/source/ui/vba/vbalistgallery.hxx
@@ -29,7 +29,7 @@ class SwVbaListGallery : public SwVbaListGallery_BASE
 {
 private:
     css::uno::Reference< css::text::XTextDocument > mxTextDocument;
-    sal_Int32 const mnType;
+    sal_Int32 mnType;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbalisthelper.hxx b/sw/source/ui/vba/vbalisthelper.hxx
index f076692d1740..16c6f9d426c3 100644
--- a/sw/source/ui/vba/vbalisthelper.hxx
+++ b/sw/source/ui/vba/vbalisthelper.hxx
@@ -26,8 +26,8 @@ private:
     css::uno::Reference< css::container::XIndexReplace > mxNumberingRules;
     css::uno::Reference< css::container::XNameContainer > mxStyleFamily;
     css::uno::Reference< css::beans::XPropertySet > mxStyleProps;
-    sal_Int32 const mnGalleryType;
-    sal_Int32 const mnTemplateType;
+    sal_Int32 mnGalleryType;
+    sal_Int32 mnTemplateType;
     OUString msStyleName;
 
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbalistlevel.hxx b/sw/source/ui/vba/vbalistlevel.hxx
index f9f5e030e56e..f149a7109104 100644
--- a/sw/source/ui/vba/vbalistlevel.hxx
+++ b/sw/source/ui/vba/vbalistlevel.hxx
@@ -29,7 +29,7 @@ class SwVbaListLevel : public SwVbaListLevel_BASE
 {
 private:
     SwVbaListHelperRef pListHelper;
-    sal_Int32 const mnLevel;
+    sal_Int32 mnLevel;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbalistlevels.hxx b/sw/source/ui/vba/vbalistlevels.hxx
index f3a212b2c9c8..ce5674fc7e97 100644
--- a/sw/source/ui/vba/vbalistlevels.hxx
+++ b/sw/source/ui/vba/vbalistlevels.hxx
@@ -28,7 +28,7 @@ typedef CollTestImplHelper< ooo::vba::word::XListLevels > SwVbaListLevels_BASE;
 class SwVbaListLevels : public SwVbaListLevels_BASE
 {
 private:
-    SwVbaListHelperRef const pListHelper;
+    SwVbaListHelperRef pListHelper;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbalisttemplates.hxx b/sw/source/ui/vba/vbalisttemplates.hxx
index 270e2cc09d4f..d9d4e9d7fba2 100644
--- a/sw/source/ui/vba/vbalisttemplates.hxx
+++ b/sw/source/ui/vba/vbalisttemplates.hxx
@@ -29,7 +29,7 @@ class SwVbaListTemplates : public SwVbaListTemplates_BASE
 {
 private:
     css::uno::Reference< css::text::XTextDocument > mxTextDocument;
-    sal_Int32 const mnGalleryType;
+    sal_Int32 mnGalleryType;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbarow.hxx b/sw/source/ui/vba/vbarow.hxx
index 86628324c8d3..7c6e6f3ccf8b 100644
--- a/sw/source/ui/vba/vbarow.hxx
+++ b/sw/source/ui/vba/vbarow.hxx
@@ -32,7 +32,7 @@ private:
     css::uno::Reference< css::text::XTextTable > mxTextTable;
     css::uno::Reference< css::table::XTableRows > mxTableRows;
     css::uno::Reference< css::beans::XPropertySet > mxRowProps;
-    sal_Int32 const mnIndex;
+    sal_Int32 mnIndex;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/sw/source/ui/vba/vbastyles.cxx b/sw/source/ui/vba/vbastyles.cxx
index 32cf08c84ae0..bfebbb8b48dd 100644
--- a/sw/source/ui/vba/vbastyles.cxx
+++ b/sw/source/ui/vba/vbastyles.cxx
@@ -35,9 +35,9 @@ namespace {
 
 struct BuiltinStyleTable
 {
-    sal_Int32 const wdBuiltinStyle;
-    const char* pOOoStyleName;
-    sal_Int32 const wdStyleType;
+    sal_Int32 wdBuiltinStyle;
+    const sal_Char* pOOoStyleName;
+    sal_Int32 wdStyleType;
 };
 
 }
diff --git a/sw/source/ui/vba/vbatemplate.hxx b/sw/source/ui/vba/vbatemplate.hxx
index 2798c5eccf43..5765c06a8ee5 100644
--- a/sw/source/ui/vba/vbatemplate.hxx
+++ b/sw/source/ui/vba/vbatemplate.hxx
@@ -27,7 +27,7 @@ typedef InheritedHelperInterfaceWeakImpl< ooo::vba::word::XTemplate > SwVbaTempl
 class SwVbaTemplate : public SwVbaTemplate_BASE
 {
 private:
-    OUString const msFullUrl;
+    OUString msFullUrl;
 public:
     SwVbaTemplate( const css::uno::Reference< ooo::vba::XHelperInterface >& rParent, const css::uno::Reference< css::uno::XComponentContext >& rContext,
         const OUString& );
diff --git a/sw/source/ui/vba/vbavariable.hxx b/sw/source/ui/vba/vbavariable.hxx
index c69ddfce023c..a278ed16d2b6 100644
--- a/sw/source/ui/vba/vbavariable.hxx
+++ b/sw/source/ui/vba/vbavariable.hxx
@@ -29,7 +29,7 @@ class SwVbaVariable : public SwVbaVariable_BASE
 {
 private:
     css::uno::Reference< css::beans::XPropertyAccess > mxUserDefined;
-    OUString const maVariableName;
+    OUString maVariableName;
 
 public:
     /// @throws css::uno::RuntimeException