diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-11 14:06:21 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-11 18:43:34 +0200 |
commit | 3739253b35212f45dd1654286db5e97b70589a57 (patch) | |
tree | e57640c9e9c8f1e8acc7b34a78fcc480c91cbcad /sw/source/ui/vba | |
parent | 043ba6ddf8d90b04acfae8ec836c4b772fb36754 (diff) |
loplugin:moveparam in sw
Change-Id: I4fa524e4abb101ed0ff1b8f97b84582b84aa1d07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123387
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/source/ui/vba')
-rw-r--r-- | sw/source/ui/vba/vbadocumentproperties.cxx | 6 | ||||
-rw-r--r-- | sw/source/ui/vba/vbarevisions.cxx | 4 | ||||
-rw-r--r-- | sw/source/ui/vba/vbasections.cxx | 4 |
3 files changed, 7 insertions, 7 deletions
diff --git a/sw/source/ui/vba/vbadocumentproperties.cxx b/sw/source/ui/vba/vbadocumentproperties.cxx index af04be582cda..78f553ed0365 100644 --- a/sw/source/ui/vba/vbadocumentproperties.cxx +++ b/sw/source/ui/vba/vbadocumentproperties.cxx @@ -650,7 +650,7 @@ class DocPropEnumeration : public ::cppu::WeakImplHelper< css::container::XEnume DocProps::iterator mIt; public: - explicit DocPropEnumeration( const DocProps& rProps ) : mDocProps( rProps ), mIt( mDocProps.begin() ) {} + explicit DocPropEnumeration( DocProps&& rProps ) : mDocProps( std::move(rProps) ), mIt( mDocProps.begin() ) {} virtual sal_Bool SAL_CALL hasMoreElements( ) override { return mIt != mDocProps.end(); @@ -739,7 +739,7 @@ protected: } virtual uno::Reference< container::XEnumeration > SAL_CALL createEnumeration( ) override { - return new DocPropEnumeration( mDocProps ); + return new DocPropEnumeration( std::unordered_map(mDocProps) ); } }; @@ -872,7 +872,7 @@ public: for ( ; key < nElem; ++key ) simpleDocPropSnapShot[ key ].set( getByIndex( key ), uno::UNO_QUERY_THROW ); SAL_INFO("sw.vba", "After creating the enumeration"); - return new DocPropEnumeration( simpleDocPropSnapShot ); + return new DocPropEnumeration( std::move(simpleDocPropSnapShot) ); } void addProp( const OUString& Name, const uno::Any& Value ) diff --git a/sw/source/ui/vba/vbarevisions.cxx b/sw/source/ui/vba/vbarevisions.cxx index 37e078176f3e..03ab7c886b1d 100644 --- a/sw/source/ui/vba/vbarevisions.cxx +++ b/sw/source/ui/vba/vbarevisions.cxx @@ -36,7 +36,7 @@ class RedlinesEnumeration : public ::cppu::WeakImplHelper< container::XEnumerati RevisionMap mRevisionMap; RevisionMap::iterator mIt; public: - explicit RedlinesEnumeration( const RevisionMap& sMap ) : mRevisionMap( sMap ), mIt( mRevisionMap.begin() ) {} + explicit RedlinesEnumeration( RevisionMap&& sMap ) : mRevisionMap( std::move(sMap) ), mIt( mRevisionMap.begin() ) {} virtual sal_Bool SAL_CALL hasMoreElements( ) override { return ( mIt != mRevisionMap.end() ); @@ -74,7 +74,7 @@ RevisionCollectionHelper( const uno::Reference< frame::XModel >& xModel, const u // XEnumerationAccess virtual uno::Reference< container::XEnumeration > SAL_CALL createEnumeration( ) override { - return new RedlinesEnumeration( mRevisionMap ); + return new RedlinesEnumeration( std::vector(mRevisionMap) ); } }; diff --git a/sw/source/ui/vba/vbasections.cxx b/sw/source/ui/vba/vbasections.cxx index 04a6cd560ab1..0665ebfce809 100644 --- a/sw/source/ui/vba/vbasections.cxx +++ b/sw/source/ui/vba/vbasections.cxx @@ -37,7 +37,7 @@ class SectionEnumeration : public ::cppu::WeakImplHelper< container::XEnumeratio XSectionVec::iterator mIt; public: - explicit SectionEnumeration( const XSectionVec& rVec ) : mxSections( rVec ), mIt( mxSections.begin() ) {} + explicit SectionEnumeration( XSectionVec&& rVec ) : mxSections( std::move(rVec) ), mIt( mxSections.begin() ) {} virtual sal_Bool SAL_CALL hasMoreElements( ) override { return ( mIt != mxSections.end() ); @@ -115,7 +115,7 @@ public: // XEnumerationAccess virtual uno::Reference< container::XEnumeration > SAL_CALL createEnumeration( ) override { - return new SectionEnumeration( mxSections ); + return new SectionEnumeration( std::vector(mxSections) ); } }; |