diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-06 14:40:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-09 11:33:43 +0100 |
| commit | abe39f7781f59b96c5a8d3dd5b41c60fdf04ad84 (patch) | |
| tree | 0f72d1968e5f25e3f280688a414398e3f4a7cce8 /sw/source/ui | |
| parent | bdb1c72198f60fdd91460e26282134d43bc0e2df (diff) | |
improve loplugin:unusedfields
noticed something that wasn't being picked up, wrote some tests,
and found an unhandled case in Plugin::getParentFunctionDecl
Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/source/ui')
| -rw-r--r-- | sw/source/ui/chrdlg/pardlg.cxx | 2 | ||||
| -rw-r--r-- | sw/source/ui/index/cnttab.cxx | 35 |
2 files changed, 15 insertions, 22 deletions
diff --git a/sw/source/ui/chrdlg/pardlg.cxx b/sw/source/ui/chrdlg/pardlg.cxx index 99751fed15c9..80388415f486 100644 --- a/sw/source/ui/chrdlg/pardlg.cxx +++ b/sw/source/ui/chrdlg/pardlg.cxx @@ -52,7 +52,7 @@ SwParaDlg::SwParaDlg(weld::Window *pParent, , rView(rVw) , bDrawParaDlg(bDraw) { - nHtmlMode = ::GetHtmlMode(rVw.GetDocShell()); + sal_uInt16 nHtmlMode = ::GetHtmlMode(rVw.GetDocShell()); bool bHtmlMode = (nHtmlMode & HTMLMODE_ON) == HTMLMODE_ON; if(pTitle) { diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx index 60ced0cbbf30..16959698f976 100644 --- a/sw/source/ui/index/cnttab.cxx +++ b/sw/source/ui/index/cnttab.cxx @@ -134,13 +134,6 @@ class SwEntryBrowseBox : public SwEntryBrowseBox_Base VclPtr<Edit> m_aCellEdit; VclPtr< ::svt::CheckBoxControl> m_aCellCheckBox; - OUString m_sSearch; - OUString m_sAlternative; - OUString m_sPrimKey; - OUString m_sSecKey; - OUString m_sComment; - OUString m_sCaseSensitive; - OUString m_sWordOnly; OUString m_sYes; OUString m_sNo; @@ -3565,13 +3558,13 @@ SwEntryBrowseBox::SwEntryBrowseBox(const css::uno::Reference<css::awt::XWindow> , m_nCurrentRow(0) , m_bModified(false) { - m_sSearch = SwResId(STR_AUTOMARK_SEARCHTERM); - m_sAlternative = SwResId(STR_AUTOMARK_ALTERNATIVE); - m_sPrimKey = SwResId(STR_AUTOMARK_KEY1); - m_sSecKey = SwResId(STR_AUTOMARK_KEY2); - m_sComment = SwResId(STR_AUTOMARK_COMMENT); - m_sCaseSensitive = SwResId(STR_AUTOMARK_CASESENSITIVE); - m_sWordOnly = SwResId(STR_AUTOMARK_WORDONLY); + OUString sSearch = SwResId(STR_AUTOMARK_SEARCHTERM); + OUString sAlternative = SwResId(STR_AUTOMARK_ALTERNATIVE); + OUString sPrimKey = SwResId(STR_AUTOMARK_KEY1); + OUString sSecKey = SwResId(STR_AUTOMARK_KEY2); + OUString sComment = SwResId(STR_AUTOMARK_COMMENT); + OUString sCaseSensitive = SwResId(STR_AUTOMARK_CASESENSITIVE); + OUString sWordOnly = SwResId(STR_AUTOMARK_WORDONLY); m_sYes = SwResId(STR_AUTOMARK_YES); m_sNo = SwResId(STR_AUTOMARK_NO); @@ -3591,13 +3584,13 @@ SwEntryBrowseBox::SwEntryBrowseBox(const css::uno::Reference<css::awt::XWindow> const OUString* aTitles[7] = { - &m_sSearch, - &m_sAlternative, - &m_sPrimKey, - &m_sSecKey, - &m_sComment, - &m_sCaseSensitive, - &m_sWordOnly + &sSearch, + &sAlternative, + &sPrimKey, + &sSecKey, + &sComment, + &sCaseSensitive, + &sWordOnly }; long nWidth = GetSizePixel().Width(); |