new loplugin: externalandnotdefined

Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2

8 files changed, 36 insertions, 27 deletions

diff --git a/sw/source/ui/dbui/dbinsdlg.cxx b/sw/source/ui/dbui/dbinsdlg.cxx
index e61d7736757d..38df859ee57c 100644
--- a/sw/source/ui/dbui/dbinsdlg.cxx
+++ b/sw/source/ui/dbui/dbinsdlg.cxx
@@ -92,11 +92,7 @@
 
 #include <boost/noncopyable.hpp>
 #include <boost/scoped_ptr.hpp>
-
-namespace swui
-{
-    SwAbstractDialogFactory * GetFactory();
-}
+#include <swuiexp.hxx>
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::beans;
diff --git a/sw/source/ui/dialog/swuiexp.cxx b/sw/source/ui/dialog/swuiexp.cxx
index f2139afa2467..f90812fa4681 100644
--- a/sw/source/ui/dialog/swuiexp.cxx
+++ b/sw/source/ui/dialog/swuiexp.cxx
@@ -19,6 +19,7 @@
 
 #include "swdlgfact.hxx"
 #include "dialmgr.hxx"
+#include <swuiexp.hxx>
 
 namespace swui
 {
diff --git a/sw/source/ui/envelp/envfmt.cxx b/sw/source/ui/envelp/envfmt.cxx
index bdc199278157..4025f3703b8f 100644
--- a/sw/source/ui/envelp/envfmt.cxx
+++ b/sw/source/ui/envelp/envfmt.cxx
@@ -49,6 +49,7 @@
 
 #include "swabstdlg.hxx"
 #include "chrdlg.hrc"
+#include <swuiexp.hxx>
 
 namespace {
     /// Converts a ranges array to a list containing one entry for each
@@ -112,11 +113,6 @@ namespace {
 
 }
 
-namespace swui
-{
-    SwAbstractDialogFactory * GetFactory();
-}
-
 static long lUserW = 5669; // 10 cm
 static long lUserH = 5669; // 10 cm
 
diff --git a/sw/source/ui/envelp/label1.cxx b/sw/source/ui/envelp/label1.cxx
index 784ecdb8c6f9..e09c0141a40e 100644
--- a/sw/source/ui/envelp/label1.cxx
+++ b/sw/source/ui/envelp/label1.cxx
@@ -34,9 +34,7 @@
 #include <helpid.h>
 #include <globals.hrc>
 #include <../../uibase/envelp/label.hrc>
-
-//impl in envimg.cxx
-extern SW_DLLPUBLIC OUString MakeSender();
+#include <envimg.hxx>
 
 void SwLabRec::SetFromItem( const SwLabItem& rItem )
 {
diff --git a/sw/source/ui/fldui/fldedt.cxx b/sw/source/ui/fldui/fldedt.cxx
index 4e94a7775b82..26a28cfd866e 100644
--- a/sw/source/ui/fldui/fldedt.cxx
+++ b/sw/source/ui/fldui/fldedt.cxx
@@ -47,11 +47,8 @@
 #include <com/sun/star/document/XDocumentProperties.hpp>
 #include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
 #include <boost/scoped_ptr.hpp>
+#include <swuiexp.hxx>
 
-namespace swui
-{
-    SwAbstractDialogFactory * GetFactory();
-}
 
 SwFldEditDlg::SwFldEditDlg(SwView& rVw)
     : SfxSingleTabDialog(&rVw.GetViewFrame()->GetWindow(), 0,
diff --git a/sw/source/ui/inc/swuiexp.hxx b/sw/source/ui/inc/swuiexp.hxx
new file mode 100644
index 000000000000..6e9993b0717f
--- /dev/null
+++ b/sw/source/ui/inc/swuiexp.hxx
@@ -0,0 +1,29 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+#ifndef INCLUDED_SW_SOURCE_UI_INC_SWUIEXP_HXX
+#define INCLUDED_SW_SOURCE_UI_INC_SWUIEXP_HXX
+
+namespace swui
+{
+    SwAbstractDialogFactory * GetFactory();
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/ui/table/convert.cxx b/sw/source/ui/table/convert.cxx
index 3c52e34cde2e..c0af214b553b 100644
--- a/sw/source/ui/table/convert.cxx
+++ b/sw/source/ui/table/convert.cxx
@@ -35,11 +35,7 @@
 #include "table.hrc"
 #include "swabstdlg.hxx"
 #include <boost/scoped_ptr.hpp>
-
-namespace swui
-{
-    SwAbstractDialogFactory * GetFactory();
-}
+#include <swuiexp.hxx>
 
 //keep the state of the buttons on runtime
 static int nSaveButtonState = -1; // 0: tab, 1: semicolon, 2: paragraph, 3: other, -1: not yet used
diff --git a/sw/source/ui/table/instable.cxx b/sw/source/ui/table/instable.cxx
index 6cfe91602781..c291cd8dd571 100644
--- a/sw/source/ui/table/instable.cxx
+++ b/sw/source/ui/table/instable.cxx
@@ -33,11 +33,7 @@
 
 #include "swabstdlg.hxx"
 #include <boost/scoped_ptr.hpp>
-
-namespace swui
-{
-    SwAbstractDialogFactory * GetFactory();
-}
+#include <swuiexp.hxx>
 
 #define ROW_COL_PROD 16384