diff options
author | Armin Le Grand <Armin.Le.Grand@cib.de> | 2016-03-15 17:24:11 +0100 |
---|---|---|
committer | Armin Le Grand <Armin.Le.Grand@cib.de> | 2016-03-22 09:00:45 +0000 |
commit | 23391fdb5cffb62006415ad1f4c96b6ed5d50cf8 (patch) | |
tree | fc25a363096c6ed5d6aa1c58a7bfbdf4ca6d415a /sw/source/uibase/fldui | |
parent | 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14 (diff) |
tdf#98646 Fixed freeze by flattening loops
DrawViewShell::MakeVisible was using loops for finding the area
to change the visible part of the EditView to. That could (and did)
potentially loop for a long time for very large objects, deep zoom or
numerical problems. That loops were flattened, the results checked
to be the same.
Also added a test for numerical overflow for getting values from the
Rectangle describing the object size. Despite these values being
the result of erraneous import, I opt for checking and avoiding using
these values.
Change-Id: I783dc1f2ad9b6a60a47e660b0d576ea3f22a4e42
Reviewed-on: https://gerrit.libreoffice.org/23278
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
Diffstat (limited to 'sw/source/uibase/fldui')
0 files changed, 0 insertions, 0 deletions