diff options
| author | Michael Stahl <mstahl@redhat.com> | 2016-11-24 14:18:05 +0100 |
|---|---|---|
| committer | Michael Stahl <mstahl@redhat.com> | 2016-11-24 22:56:32 +0100 |
| commit | cbdf4e007650cfda4f7808402e8e24ae66d45792 (patch) | |
| tree | f5c202c4afe8b8eab491f3e1b65b46ea97eeb353 /sw/source/uibase/inc/conttree.hxx | |
| parent | c2c4c6ee16120108590dc64f295ab54e34a05ac0 (diff) | |
tdf#103788 sw: fix use-after-free in navigator dialog
The problem is that if SwContentTree::HasContentChanged() returns true,
it may have deleted the SwTypeNumber instances that are referenced in
SvTreeListEntry::pUserData, but it has not reset pUserData so those
pointers are now used to acceess deleted objects.
Also it looks like the HasContentChanged() detects additional conditions
that would not cause a modified event from the document but should still
cause a repaint, such as when the user moves the cursor between
headings.
Revert the optimization, it was a stupid idea.
(regression from 329742e6c9da7cd7848d92a6846e3d1249d8d9b4)
Change-Id: Idb5207e896b0638324fc41b7c214536be4ba864b
Diffstat (limited to 'sw/source/uibase/inc/conttree.hxx')
| -rw-r--r-- | sw/source/uibase/inc/conttree.hxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sw/source/uibase/inc/conttree.hxx b/sw/source/uibase/inc/conttree.hxx index 525d11fe4fd2..4dd2bf4db31a 100644 --- a/sw/source/uibase/inc/conttree.hxx +++ b/sw/source/uibase/inc/conttree.hxx @@ -96,7 +96,6 @@ class SwContentTree bool m_bIsOutlineMoveable :1; bool m_bViewHasChanged :1; bool m_bIsImageListInitialized : 1; - bool m_bActiveDocModified :1; static bool bIsInDrag; |