loplugin:constantparam in sw

Change-Id: I16badc615e98202668b1b201035b5137cb94c10c

6 files changed, 15 insertions, 17 deletions

diff --git a/sw/source/uibase/inc/cfgitems.hxx b/sw/source/uibase/inc/cfgitems.hxx
index fce80f1aea10..57a8c5f38bbf 100644
--- a/sw/source/uibase/inc/cfgitems.hxx
+++ b/sw/source/uibase/inc/cfgitems.hxx
@@ -55,11 +55,10 @@ class SW_DLLPUBLIC SwDocDisplayItem : public SfxPoolItem
     bool bShowHiddenPara    :1;
 
 public:
-                                SwDocDisplayItem( sal_uInt16 nWhich = FN_PARAM_DOCDISP );
+                                SwDocDisplayItem();
                                 SwDocDisplayItem(
                                     const SwDocDisplayItem& rSwDocDisplayItem );
-                                SwDocDisplayItem( const SwViewOption& rVOpt,
-                                                                sal_uInt16 nWhich );
+                                SwDocDisplayItem( const SwViewOption& rVOpt );
 
     virtual SfxPoolItem*        Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool                operator==( const SfxPoolItem& ) const override;
@@ -87,9 +86,9 @@ class SW_DLLPUBLIC SwElemItem : public SfxPoolItem
     friend class SwContentOptPage;
 
 public:
-                            SwElemItem( sal_uInt16 nWhich = FN_PARAM_ELEM );
+                            SwElemItem();
                             SwElemItem(const SwElemItem& rElemItem);
-                            SwElemItem(const SwViewOption& rVOpt, sal_uInt16 nWhich);
+                            SwElemItem(const SwViewOption& rVOpt);
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
@@ -108,8 +107,8 @@ class SW_DLLPUBLIC SwAddPrinterItem : public SfxPoolItem, public SwPrintData
     using  SwPrintData::operator ==;
 
 public:
-    SwAddPrinterItem( sal_uInt16 nWhich = FN_PARAM_ADDPRINTER );
-    SwAddPrinterItem( sal_uInt16 nWhich, const SwPrintData& rPrtData );
+    SwAddPrinterItem();
+    SwAddPrinterItem( const SwPrintData& rPrtData );
     SwAddPrinterItem( const SwAddPrinterItem& rAddPrinterItem);
 
     virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override;
@@ -125,9 +124,9 @@ class SW_DLLPUBLIC SwShadowCursorItem : public SfxPoolItem
     sal_uInt8 eMode;
     bool bOn;
 public:
-    SwShadowCursorItem( sal_uInt16 nWhich = FN_PARAM_SHADOWCURSOR );
+    SwShadowCursorItem();
     SwShadowCursorItem( const SwShadowCursorItem& rElemItem );
-    SwShadowCursorItem( const SwViewOption& rVOpt, sal_uInt16 nWhich );
+    SwShadowCursorItem( const SwViewOption& rVOpt );
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
@@ -163,8 +162,7 @@ class SW_DLLPUBLIC SwTestItem : public SfxPoolItem
     bool    bTest10:1;
 
 public:
-                            SwTestItem( sal_uInt16 _nWhich):
-                                            SfxPoolItem(_nWhich){};
+                            SwTestItem() : SfxPoolItem(FN_PARAM_SWTEST) {};
                             SwTestItem( const SwTestItem& pTestItem);
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
diff --git a/sw/source/uibase/inc/colmgr.hxx b/sw/source/uibase/inc/colmgr.hxx
index c9b59dcb6fe9..53cc566e1dd7 100644
--- a/sw/source/uibase/inc/colmgr.hxx
+++ b/sw/source/uibase/inc/colmgr.hxx
@@ -28,7 +28,7 @@ class SW_DLLPUBLIC SwColMgr
 {
 public:
         // lActWidth is passed directly from the page dialogs edits
-    SwColMgr(const SfxItemSet &rSet, sal_uInt16 nActWidth = USHRT_MAX);
+    SwColMgr(const SfxItemSet &rSet);
     ~SwColMgr();
 
     inline sal_uInt16   GetCount() const;
diff --git a/sw/source/uibase/inc/numfmtlb.hxx b/sw/source/uibase/inc/numfmtlb.hxx
index 300d976cd1fa..4ef3759e9ffb 100644
--- a/sw/source/uibase/inc/numfmtlb.hxx
+++ b/sw/source/uibase/inc/numfmtlb.hxx
@@ -41,7 +41,7 @@ class SW_DLLPUBLIC NumFormatListBox : public ListBox
     DECL_DLLPRIVATE_LINK_TYPED( SelectHdl, ListBox&, void );
 
     SAL_DLLPRIVATE double          GetDefValue(const short nFormatType) const;
-    SAL_DLLPRIVATE void            Init(short nFormatType);
+    SAL_DLLPRIVATE void            Init();
     SAL_DLLPRIVATE SwView*         GetView();
 
 public:
diff --git a/sw/source/uibase/inc/swwrtshitem.hxx b/sw/source/uibase/inc/swwrtshitem.hxx
index 39003198854a..dcdb04dbda46 100644
--- a/sw/source/uibase/inc/swwrtshitem.hxx
+++ b/sw/source/uibase/inc/swwrtshitem.hxx
@@ -28,7 +28,7 @@ class SW_DLLPUBLIC SwWrtShellItem: public SfxPoolItem
     SwWrtShell*         pWrtSh;
 
 public:
-                            SwWrtShellItem( sal_uInt16 nWhich , SwWrtShell* pWrtSh);
+                            SwWrtShellItem( SwWrtShell* pWrtSh );
                             SwWrtShellItem( const SwWrtShellItem& );
 
     virtual bool            operator==( const SfxPoolItem& ) const override;
diff --git a/sw/source/uibase/inc/uiitems.hxx b/sw/source/uibase/inc/uiitems.hxx
index 2222ffd2e8ec..add23a7bab5f 100644
--- a/sw/source/uibase/inc/uiitems.hxx
+++ b/sw/source/uibase/inc/uiitems.hxx
@@ -35,7 +35,7 @@ class SW_DLLPUBLIC SwPageFootnoteInfoItem : public SfxPoolItem
 
 public:
 
-    SwPageFootnoteInfoItem(const sal_uInt16 nId, SwPageFootnoteInfo& rInfo);
+    SwPageFootnoteInfoItem(SwPageFootnoteInfo& rInfo);
     SwPageFootnoteInfoItem(const SwPageFootnoteInfoItem& rItem );
     virtual ~SwPageFootnoteInfoItem();
 
@@ -73,7 +73,7 @@ class SW_DLLPUBLIC SwUINumRuleItem : public SfxPoolItem
     SwNumRule* pRule;
 
 public:
-    SwUINumRuleItem( const SwNumRule& rRule, const sal_uInt16 = FN_PARAM_ACT_NUMBER);
+    SwUINumRuleItem( const SwNumRule& rRule );
     SwUINumRuleItem( const SwUINumRuleItem& rItem );
     virtual ~SwUINumRuleItem();
 
diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx
index 5226c3ad6480..6e633ce13098 100644
--- a/sw/source/uibase/inc/wrtsh.hxx
+++ b/sw/source/uibase/inc/wrtsh.hxx
@@ -416,7 +416,7 @@ typedef bool (SwWrtShell:: *FNSimpleMove)();
     void ExecMacro( const SvxMacro& rMacro, OUString* pRet = nullptr, SbxArray* pArgs = nullptr );
     // call into the dark Basic/JavaScript
     sal_uInt16 CallEvent( sal_uInt16 nEvent, const SwCallMouseEvent& rCallEvent,
-                        bool bCheckPtr = false, SbxArray* pArgs = nullptr );
+                        bool bCheckPtr = false );
 
     // a click at the given field. the cursor is on it.
     // execute the predefined actions.