summaryrefslogtreecommitdiff
path: root/sw/source/uibase/shells/txtattr.cxx
diff options
context:
space:
mode:
authorJustin Luth <justin_luth@sil.org>2020-02-18 11:05:51 +0300
committerMiklos Vajna <vmiklos@collabora.com>2023-06-12 09:30:30 +0200
commitd384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8 (patch)
treede6810353365810f70b5f27f8c7e206791ab5c97 /sw/source/uibase/shells/txtattr.cxx
parent49d9bdd259bf17c1db8aae1e95937a15bb672521 (diff)
related tdf#80194 SvxEscapementItem: set auto flag as default
This OUGHT to effectively be identical - since nProp is the default, and the DFLT_ESC_ values match what _AUTO_ ought to calculate. So it shouldn't be too scary. It would ?only? expose areas that deficiently handle _AUTO_. The primary intended effect is on calling .uno:SubScript (via the properties panel or toolbar) and getting an automatic subscript/superscript for editeng text (which would be draw/impress/calc objects, or Writer textboxes). Instead of setting the default value for subscript/superscript, set the auto-flag so the computer can more intelligently handle the positioning. That's what I would expect as a user, especially since this is the default in the character format dialog, and Writer already did this explicitly. One possible downside to this is that "automatic" is less clearly defined for pixel-exact compatibility with other programs, or for export/import. But we already do that with Writer - which is the most concerned about pixel-exactness... Prior to 7.0, editeng automatic subscripts weren't calculated very well (i.e. subscripts were placed way too low). So don't enable automatic mode until after 7.6, so that the older, stable versions have a chance to not mess up positioning an automatic value on newly created documents. CAUTION: Doing this at such a low level might be too radical. The other option would be to specify it at all of the SID_SET_SUB_SCRIPT locations - similar to the way that Writer did it. Change-Id: Ic6fb866477653ff57edd02bb894769545a60acf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88998 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'sw/source/uibase/shells/txtattr.cxx')
-rw-r--r--sw/source/uibase/shells/txtattr.cxx4
1 files changed, 0 insertions, 4 deletions
diff --git a/sw/source/uibase/shells/txtattr.cxx b/sw/source/uibase/shells/txtattr.cxx
index c5c90c8afc7c..68f4197f5437 100644
--- a/sw/source/uibase/shells/txtattr.cxx
+++ b/sw/source/uibase/shells/txtattr.cxx
@@ -115,10 +115,6 @@ void SwTextShell::ExecCharAttr(SfxRequest &rReq)
break;
}
SvxEscapementItem aEscape( eEscape, RES_CHRATR_ESCAPEMENT );
- if(eEscape == SvxEscapement::Superscript)
- aEscape.GetEsc() = DFLT_ESC_AUTO_SUPER;
- else if(eEscape == SvxEscapement::Subscript)
- aEscape.GetEsc() = DFLT_ESC_AUTO_SUB;
rSh.SetAttrItem( aEscape );
rReq.AppendItem( aEscape );
rReq.Done();