remove cargo cult OSL_ENSURE(pFact, "ScAbstractFactory create fail!"(

Possibly this was useful once upon a time, but now it's just noise.

If it failed, we're going to crash on the next line when we call a
method on that pointer anyway.

Change-Id: Ic601f0c3344f6895f8a6ffb3bc6f8bcb45d00a92
Reviewed-on: https://gerrit.libreoffice.org/55082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 0 insertions, 5 deletions

diff --git a/sw/source/uibase/uiview/viewdlg2.cxx b/sw/source/uibase/uiview/viewdlg2.cxx
index 41bec30c8023..7bc9cb1a94b4 100644
--- a/sw/source/uibase/uiview/viewdlg2.cxx
+++ b/sw/source/uibase/uiview/viewdlg2.cxx
@@ -56,7 +56,6 @@ void SwView::ExecDlgExt(SfxRequest const &rReq)
             assert(pFact && "SwAbstractDialogFactory fail!");
 
             ScopedVclPtr<VclAbstractDialog> pDialog(pFact->CreateSwCaptionDialog( &rMDI, *this ));
-            assert(pDialog && "Dialog creation failed!");
             if ( pDialog )
             {
                 pDialog->Execute();
@@ -72,7 +71,6 @@ void SwView::ExecDlgExt(SfxRequest const &rReq)
             const uno::Reference<frame::XModel> xModel(GetCurrentDocument());
             ScopedVclPtr<AbstractSignatureLineDialog> pDialog(pFact->CreateSignatureLineDialog(
                 GetFrameWeld(), xModel, rReq.GetSlot() == SID_EDIT_SIGNATURELINE));
-            assert(pDialog && "Dialog creation failed!");
 
             if (pDialog)
                 pDialog->Execute();
@@ -86,7 +84,6 @@ void SwView::ExecDlgExt(SfxRequest const &rReq)
             const uno::Reference<frame::XModel> xModel(GetCurrentDocument());
             VclPtr<AbstractSignSignatureLineDialog> pDialog
                 = pFact->CreateSignSignatureLineDialog(GetFrameWeld(), xModel);
-            assert(pDialog && "Dialog creation failed!");
 
             if (pDialog)
                 pDialog->Execute();
@@ -95,10 +92,8 @@ void SwView::ExecDlgExt(SfxRequest const &rReq)
         case  FN_EDIT_FOOTNOTE:
         {
             SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-            assert(pFact && "Dialog creation failed!");
             ScopedVclPtr<AbstractInsFootNoteDlg> pDlg(pFact->CreateInsFootNoteDlg(
                 GetFrameWeld(), *m_pWrtShell, true));
-            assert(pDlg && "Dialog creation failed!");
 
             pDlg->SetHelpId(GetStaticInterface()->GetSlot(FN_EDIT_FOOTNOTE)->GetCommand());
             pDlg->SetText( SwResId(STR_EDIT_FOOTNOTE) );