diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-08 13:46:08 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-09 10:44:03 +0200 |
commit | b35a4cf023844dbbb3666c730213e9bc679d4a4f (patch) | |
tree | 6788333e22b2a73e5116d3b67bea0df3c7093707 /sw/source/uibase | |
parent | ea8c12b8cc03ed259389ac267edd459844634767 (diff) |
loplugin:checkunusedparams in sw(part5)
Change-Id: Iee48e6c77f1eb57cd8a3a245e5415051b85f4cc1
Reviewed-on: https://gerrit.libreoffice.org/37387
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/source/uibase')
-rw-r--r-- | sw/source/uibase/app/swmodul1.cxx | 4 | ||||
-rw-r--r-- | sw/source/uibase/docvw/PostItMgr.cxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/fldui/fldmgr.cxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/inc/fldmgr.hxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/inc/navipi.hxx | 5 | ||||
-rw-r--r-- | sw/source/uibase/inc/pview.hxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/inc/unodispatch.hxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/uiview/pview.cxx | 8 | ||||
-rw-r--r-- | sw/source/uibase/uiview/uivwimp.cxx | 4 | ||||
-rw-r--r-- | sw/source/uibase/uiview/view.cxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/uiview/viewport.cxx | 6 | ||||
-rw-r--r-- | sw/source/uibase/uno/unodispatch.cxx | 19 | ||||
-rw-r--r-- | sw/source/uibase/utlui/content.cxx | 2 | ||||
-rw-r--r-- | sw/source/uibase/utlui/navipi.cxx | 9 |
14 files changed, 33 insertions, 36 deletions
diff --git a/sw/source/uibase/app/swmodul1.cxx b/sw/source/uibase/app/swmodul1.cxx index c9ef218bb807..78300a9e7ac7 100644 --- a/sw/source/uibase/app/swmodul1.cxx +++ b/sw/source/uibase/app/swmodul1.cxx @@ -609,14 +609,14 @@ FieldUnit SwModule::GetMetric( bool bWeb ) const } // Pass-through Update-Status -sal_uInt16 SwModule::GetLinkUpdMode( bool ) const +sal_uInt16 SwModule::GetLinkUpdMode() const { if(!m_pUsrPref) GetUsrPref(false); return (sal_uInt16)m_pUsrPref->GetUpdateLinkMode(); } -SwFieldUpdateFlags SwModule::GetFieldUpdateFlags( bool ) const +SwFieldUpdateFlags SwModule::GetFieldUpdateFlags() const { if(!m_pUsrPref) GetUsrPref(false); diff --git a/sw/source/uibase/docvw/PostItMgr.cxx b/sw/source/uibase/docvw/PostItMgr.cxx index 6b2f3e4c567c..6f49708864d2 100644 --- a/sw/source/uibase/docvw/PostItMgr.cxx +++ b/sw/source/uibase/docvw/PostItMgr.cxx @@ -971,7 +971,7 @@ void SwPostItMgr::DrawNotesForPage(OutputDevice *pOutDev, sal_uInt32 nPage) } } -void SwPostItMgr::PaintTile(OutputDevice& rRenderContext, const tools::Rectangle& /*rRect*/) +void SwPostItMgr::PaintTile(OutputDevice& rRenderContext) { for (SwSidebarItem* pItem : mvPostItFields) { diff --git a/sw/source/uibase/fldui/fldmgr.cxx b/sw/source/uibase/fldui/fldmgr.cxx index 4a291cdd6e0b..88718273b980 100644 --- a/sw/source/uibase/fldui/fldmgr.cxx +++ b/sw/source/uibase/fldui/fldmgr.cxx @@ -1611,7 +1611,7 @@ void SwFieldType::GetFieldName_() } } -bool SwFieldMgr::ChooseMacro(const OUString&) +bool SwFieldMgr::ChooseMacro() { bool bRet = false; diff --git a/sw/source/uibase/inc/fldmgr.hxx b/sw/source/uibase/inc/fldmgr.hxx index 6302a84355c2..4e134e5f70aa 100644 --- a/sw/source/uibase/inc/fldmgr.hxx +++ b/sw/source/uibase/inc/fldmgr.hxx @@ -137,7 +137,7 @@ public: void InsertFieldType(SwFieldType& rType); - bool ChooseMacro(const OUString &rSelMacro); + bool ChooseMacro(); void SetMacroPath(const OUString& rPath); const OUString& GetMacroPath() const { return sMacroPath; } const OUString& GetMacroName() const { return sMacroName; } diff --git a/sw/source/uibase/inc/navipi.hxx b/sw/source/uibase/inc/navipi.hxx index 90a20d6ac7ec..1825f8eac10f 100644 --- a/sw/source/uibase/inc/navipi.hxx +++ b/sw/source/uibase/inc/navipi.hxx @@ -149,7 +149,7 @@ public: RegionMode GetRegionDropMode() const {return m_nRegionMode;} void SetRegionDropMode(RegionMode nNewMode); - sal_Int8 AcceptDrop( const AcceptDropEvent& rEvt ); + sal_Int8 AcceptDrop(); sal_Int8 ExecuteDrop( const ExecuteDropEvent& rEvt ); bool IsGlobalDoc() const; @@ -164,8 +164,7 @@ class SwNavigationChild : public SfxChildWindowContext public: SwNavigationChild( vcl::Window* , sal_uInt16 nId, - SfxBindings*, - SfxChildWinInfo* ); + SfxBindings* ); //! soon obsolete ! static SfxChildWindowContext* CreateImpl(vcl::Window *pParent, diff --git a/sw/source/uibase/inc/pview.hxx b/sw/source/uibase/inc/pview.hxx index 08427f6c778a..7e04b535568a 100644 --- a/sw/source/uibase/inc/pview.hxx +++ b/sw/source/uibase/inc/pview.hxx @@ -203,7 +203,7 @@ class SW_DLLPUBLIC SwPagePreview: public SfxViewShell SAL_DLLPRIVATE virtual bool HasPrintOptionsPage() const override; SAL_DLLPRIVATE virtual VclPtr<SfxTabPage> CreatePrintOptionsPage(vcl::Window *pParent, const SfxItemSet &rOptions ) override; - SAL_DLLPRIVATE void CalcAndSetBorderPixel( SvBorder &rToFill, bool bInner ); + SAL_DLLPRIVATE void CalcAndSetBorderPixel( SvBorder &rToFill ); /** Helper method to execute SfxRequest FN_PAGE_UP and FN_PAGE_DOWN diff --git a/sw/source/uibase/inc/unodispatch.hxx b/sw/source/uibase/inc/unodispatch.hxx index c603f499fd4c..320bbf775d61 100644 --- a/sw/source/uibase/inc/unodispatch.hxx +++ b/sw/source/uibase/inc/unodispatch.hxx @@ -45,7 +45,7 @@ class SwXDispatchProviderInterceptor : public cppu::WeakImplHelper //::osl::MutexGuard aGuard; #102295# solar mutex has to be used currently SolarMutexGuard aGuard; public: - DispatchMutexLock_Impl(SwXDispatchProviderInterceptor&); + DispatchMutexLock_Impl(); ~DispatchMutexLock_Impl(); }; friend class DispatchMutexLock_Impl; diff --git a/sw/source/uibase/uiview/pview.cxx b/sw/source/uibase/uiview/pview.cxx index 08bc2285c4e3..0610d9b104f6 100644 --- a/sw/source/uibase/uiview/pview.cxx +++ b/sw/source/uibase/uiview/pview.cxx @@ -1318,7 +1318,7 @@ bool SwPagePreview::ChgPage( int eMvMode, bool bUpdateScrollbar ) } // From here, everything was taken from the SwView. -void SwPagePreview::CalcAndSetBorderPixel( SvBorder &rToFill, bool /*bInner*/ ) +void SwPagePreview::CalcAndSetBorderPixel( SvBorder &rToFill ) { const StyleSettings &rSet = m_pViewWin->GetSettings().GetStyleSettings(); const long nTmp = rSet.GetScrollBarSize(); @@ -1332,7 +1332,7 @@ void SwPagePreview::CalcAndSetBorderPixel( SvBorder &rToFill, bool /*bInner*/ ) void SwPagePreview::InnerResizePixel( const Point &rOfst, const Size &rSize, bool ) { SvBorder aBorder; - CalcAndSetBorderPixel( aBorder, true ); + CalcAndSetBorderPixel( aBorder ); tools::Rectangle aRect( rOfst, rSize ); aRect += aBorder; ViewResizePixel( *m_pViewWin, aRect.TopLeft(), aRect.GetSize(), @@ -1346,7 +1346,7 @@ void SwPagePreview::InnerResizePixel( const Point &rOfst, const Size &rSize, bo void SwPagePreview::OuterResizePixel( const Point &rOfst, const Size &rSize ) { SvBorder aBorder; - CalcAndSetBorderPixel( aBorder, false ); + CalcAndSetBorderPixel( aBorder ); // Never set EditWin ! @@ -1363,7 +1363,7 @@ void SwPagePreview::OuterResizePixel( const Point &rOfst, const Size &rSize ) } SvBorder aBorderNew; - CalcAndSetBorderPixel( aBorderNew, false ); + CalcAndSetBorderPixel( aBorderNew ); ViewResizePixel( *m_pViewWin, rOfst, rSize, m_pViewWin->GetOutputSizePixel(), *m_pVScrollbar, *m_pHScrollbar, *m_pScrollFill ); } diff --git a/sw/source/uibase/uiview/uivwimp.cxx b/sw/source/uibase/uiview/uivwimp.cxx index 6c7288e5521d..0584ffffd7c1 100644 --- a/sw/source/uibase/uiview/uivwimp.cxx +++ b/sw/source/uibase/uiview/uivwimp.cxx @@ -269,12 +269,12 @@ SwScannerEventListener::~SwScannerEventListener() { } -void SAL_CALL SwScannerEventListener::disposing( const EventObject& rEventObject) +void SAL_CALL SwScannerEventListener::disposing( const EventObject& /*rEventObject*/) { #if defined(_WIN32) || defined UNX SolarMutexGuard aGuard; if( pView ) - pView->ScannerEventHdl( rEventObject ); + pView->ScannerEventHdl(); #endif } diff --git a/sw/source/uibase/uiview/view.cxx b/sw/source/uibase/uiview/view.cxx index 5383c26d0a36..8cc9b2438f62 100644 --- a/sw/source/uibase/uiview/view.cxx +++ b/sw/source/uibase/uiview/view.cxx @@ -1656,7 +1656,7 @@ void SwView::Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) #if defined(_WIN32) || defined UNX -void SwView::ScannerEventHdl( const EventObject& /*rEventObject*/ ) +void SwView::ScannerEventHdl() { uno::Reference< XScannerManager2 > xScanMgr = SW_MOD()->GetScannerManager(); if( xScanMgr.is() ) diff --git a/sw/source/uibase/uiview/viewport.cxx b/sw/source/uibase/uiview/viewport.cxx index edf3f4a21e90..e56fcd6c330c 100644 --- a/sw/source/uibase/uiview/viewport.cxx +++ b/sw/source/uibase/uiview/viewport.cxx @@ -813,7 +813,7 @@ void SwView::CalcVisArea( const Size &rOutPixel ) // Rearrange control elements -void SwView::CalcAndSetBorderPixel( SvBorder &rToFill, bool /*bInner*/ ) +void SwView::CalcAndSetBorderPixel( SvBorder &rToFill ) { bool bRightVRuler = m_pWrtShell->GetViewOptions()->IsVRulerRight(); if ( m_pVRuler->IsVisible() ) @@ -971,7 +971,7 @@ void SwView::InnerResizePixel( const Point &rOfst, const Size &rSize, bool ) { Size aSz( rSize ); SvBorder aBorder; - CalcAndSetBorderPixel( aBorder, true ); + CalcAndSetBorderPixel( aBorder ); if ( GetViewFrame()->GetFrame().IsInPlace() ) { Size aViewSize( aSz ); @@ -1083,7 +1083,7 @@ void SwView::OuterResizePixel( const Point &rOfst, const Size &rSize ) const bool bScroll1 = m_pVScrollbar->IsVisible(true); const bool bScroll2 = m_pHScrollbar->IsVisible(true); SvBorder aBorder; - CalcAndSetBorderPixel( aBorder, false ); + CalcAndSetBorderPixel( aBorder ); const Size aEditSz( GetEditWin().GetOutputSizePixel() ); ViewResizePixel( GetEditWin(), rOfst, rSize, aEditSz, *m_pVScrollbar, *m_pHScrollbar, *m_pScrollFill, m_pVRuler, m_pHRuler, diff --git a/sw/source/uibase/uno/unodispatch.cxx b/sw/source/uibase/uno/unodispatch.cxx index dd799932eed6..fd20b70d4961 100644 --- a/sw/source/uibase/uno/unodispatch.cxx +++ b/sw/source/uibase/uno/unodispatch.cxx @@ -64,7 +64,7 @@ SwXDispatchProviderInterceptor::~SwXDispatchProviderInterceptor() uno::Reference< frame::XDispatch > SwXDispatchProviderInterceptor::queryDispatch( const util::URL& aURL, const OUString& aTargetFrameName, sal_Int32 nSearchFlags ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; uno::Reference< frame::XDispatch> xResult; // create some dispatch ... if(m_pView && aURL.Complete.startsWith(".uno:DataSourceBrowser/")) @@ -100,7 +100,7 @@ uno::Sequence<OUString> SAL_CALL SwXDispatchProviderInterceptor::getInterceptedU uno::Sequence< uno::Reference< frame::XDispatch > > SwXDispatchProviderInterceptor::queryDispatches( const uno::Sequence< frame::DispatchDescriptor >& aDescripts ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; uno::Sequence< uno::Reference< frame::XDispatch> > aReturn(aDescripts.getLength()); uno::Reference< frame::XDispatch>* pReturn = aReturn.getArray(); const frame::DispatchDescriptor* pDescripts = aDescripts.getConstArray(); @@ -114,33 +114,33 @@ uno::Sequence< uno::Reference< frame::XDispatch > > SwXDispatchProviderIntercept uno::Reference< frame::XDispatchProvider > SwXDispatchProviderInterceptor::getSlaveDispatchProvider( ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; return m_xSlaveDispatcher; } void SwXDispatchProviderInterceptor::setSlaveDispatchProvider( const uno::Reference< frame::XDispatchProvider >& xNewDispatchProvider ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; m_xSlaveDispatcher = xNewDispatchProvider; } uno::Reference< frame::XDispatchProvider > SwXDispatchProviderInterceptor::getMasterDispatchProvider( ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; return m_xMasterDispatcher; } void SwXDispatchProviderInterceptor::setMasterDispatchProvider( const uno::Reference< frame::XDispatchProvider >& xNewSupplier ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; m_xMasterDispatcher = xNewSupplier; } void SwXDispatchProviderInterceptor::disposing( const lang::EventObject& ) { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; if (m_xIntercepted.is()) { m_xIntercepted->releaseDispatchProviderInterceptor(static_cast<frame::XDispatchProviderInterceptor*>(this)); @@ -176,7 +176,7 @@ sal_Int64 SwXDispatchProviderInterceptor::getSomething( void SwXDispatchProviderInterceptor::Invalidate() { - DispatchMutexLock_Impl aLock(*this); + DispatchMutexLock_Impl aLock; if (m_xIntercepted.is()) { m_xIntercepted->releaseDispatchProviderInterceptor(static_cast<frame::XDispatchProviderInterceptor*>(this)); @@ -392,8 +392,7 @@ const sal_Char* SwXDispatch::GetDBChangeURL() return cInternalDBChangeNotification; } -SwXDispatchProviderInterceptor::DispatchMutexLock_Impl::DispatchMutexLock_Impl( - SwXDispatchProviderInterceptor& ) +SwXDispatchProviderInterceptor::DispatchMutexLock_Impl::DispatchMutexLock_Impl() { } diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx index abdb7dd027c1..ee788fd86840 100644 --- a/sw/source/uibase/utlui/content.cxx +++ b/sw/source/uibase/utlui/content.cxx @@ -1043,7 +1043,7 @@ sal_Int8 SwContentTree::AcceptDrop( const AcceptDropEvent& rEvt ) nRet = SvTreeListBox::AcceptDrop( rEvt ); } else if( !bIsInDrag ) - nRet = GetParentWindow()->AcceptDrop( rEvt ); + nRet = GetParentWindow()->AcceptDrop(); return nRet; } diff --git a/sw/source/uibase/utlui/navipi.cxx b/sw/source/uibase/utlui/navipi.cxx index a136379b4131..0a4cca1220e5 100644 --- a/sw/source/uibase/utlui/navipi.cxx +++ b/sw/source/uibase/utlui/navipi.cxx @@ -64,11 +64,11 @@ using namespace ::com::sun::star::frame; //! soon obsolete ! SfxChildWindowContext* SwNavigationChild::CreateImpl( vcl::Window *pParent, - SfxBindings *pBindings, SfxChildWinInfo* pInfo ) + SfxBindings *pBindings, SfxChildWinInfo* /*pInfo*/ ) { SfxChildWindowContext *pContext = new SwNavigationChild(pParent, /* cast is safe here! */static_cast< sal_uInt16 >(SwView::GetInterfaceId()), - pBindings,pInfo); + pBindings); return pContext; } void SwNavigationChild::RegisterChildWindowContext(SfxModule* pMod) @@ -1032,7 +1032,7 @@ OUString SwNavigationPI::CreateDropFileName( TransferableDataHelper& rData ) return sFileName; } -sal_Int8 SwNavigationPI::AcceptDrop( const AcceptDropEvent& /*rEvt*/ ) +sal_Int8 SwNavigationPI::AcceptDrop() { return ( !SwContentTree::IsInDrag() && ( m_aContentTree->IsDropFormatSupported( SotClipboardFormatId::SIMPLE_FILE ) || @@ -1192,8 +1192,7 @@ SwView* SwNavigationPI::GetCreateView() const SwNavigationChild::SwNavigationChild( vcl::Window* pParent, sal_uInt16 nId, - SfxBindings* _pBindings, - SfxChildWinInfo* ) + SfxBindings* _pBindings ) : SfxChildWindowContext( nId ) { VclPtr<SwNavigationPI> pNavi = VclPtr<SwNavigationPI>::Create(_pBindings, pParent); |