diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-11 14:06:21 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-10-11 18:43:34 +0200 |
commit | 3739253b35212f45dd1654286db5e97b70589a57 (patch) | |
tree | e57640c9e9c8f1e8acc7b34a78fcc480c91cbcad /sw/source/uibase | |
parent | 043ba6ddf8d90b04acfae8ec836c4b772fb36754 (diff) |
loplugin:moveparam in sw
Change-Id: I4fa524e4abb101ed0ff1b8f97b84582b84aa1d07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123387
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw/source/uibase')
-rw-r--r-- | sw/source/uibase/docvw/AnnotationWin2.cxx | 4 | ||||
-rw-r--r-- | sw/source/uibase/docvw/OverlayRanges.cxx | 12 | ||||
-rw-r--r-- | sw/source/uibase/docvw/OverlayRanges.hxx | 6 |
3 files changed, 11 insertions, 11 deletions
diff --git a/sw/source/uibase/docvw/AnnotationWin2.cxx b/sw/source/uibase/docvw/AnnotationWin2.cxx index 64ea2a7de872..3bf0da22420a 100644 --- a/sw/source/uibase/docvw/AnnotationWin2.cxx +++ b/sw/source/uibase/docvw/AnnotationWin2.cxx @@ -707,7 +707,7 @@ void SwAnnotationWin::SetPosAndSize() { if ( mpTextRangeOverlay != nullptr ) { - mpTextRangeOverlay->setRanges( maAnnotationTextRanges ); + mpTextRangeOverlay->setRanges( std::vector(maAnnotationTextRanges) ); if ( mpAnchor != nullptr && mpAnchor->getLineSolid() ) { mpTextRangeOverlay->ShowSolidBorder(); @@ -724,7 +724,7 @@ void SwAnnotationWin::SetPosAndSize() sw::overlay::OverlayRanges::CreateOverlayRange( mrView, mColorAnchor, - maAnnotationTextRanges, + std::vector(maAnnotationTextRanges), mpAnchor && mpAnchor->getLineSolid() ); } } diff --git a/sw/source/uibase/docvw/OverlayRanges.cxx b/sw/source/uibase/docvw/OverlayRanges.cxx index 2db0a2194a55..ccbcc0041196 100644 --- a/sw/source/uibase/docvw/OverlayRanges.cxx +++ b/sw/source/uibase/docvw/OverlayRanges.cxx @@ -103,7 +103,7 @@ namespace sw::overlay /*static*/ std::unique_ptr<OverlayRanges> OverlayRanges::CreateOverlayRange( SwView const & rDocView, const Color& rColor, - const std::vector< basegfx::B2DRange >& rRanges, + std::vector< basegfx::B2DRange >&& rRanges, const bool bShowSolidBorder ) { std::unique_ptr<OverlayRanges> pOverlayRanges; @@ -116,7 +116,7 @@ namespace sw::overlay if ( xTargetOverlay.is() ) { - pOverlayRanges.reset(new sw::overlay::OverlayRanges( rColor, rRanges, bShowSolidBorder )); + pOverlayRanges.reset(new sw::overlay::OverlayRanges( rColor, std::move(rRanges), bShowSolidBorder )); xTargetOverlay->add( *pOverlayRanges ); } } @@ -126,10 +126,10 @@ namespace sw::overlay OverlayRanges::OverlayRanges( const Color& rColor, - const std::vector< basegfx::B2DRange >& rRanges, + std::vector< basegfx::B2DRange >&& rRanges, const bool bShowSolidBorder ) : sdr::overlay::OverlayObject( rColor ) - , maRanges( rRanges ) + , maRanges( std::move(rRanges) ) , mbShowSolidBorder( bShowSolidBorder ) { // no AA for highlight overlays @@ -144,11 +144,11 @@ namespace sw::overlay } } - void OverlayRanges::setRanges(const std::vector< basegfx::B2DRange >& rNew) + void OverlayRanges::setRanges(std::vector< basegfx::B2DRange >&& rNew) { if(rNew != maRanges) { - maRanges = rNew; + maRanges = std::move(rNew); objectChange(); } } diff --git a/sw/source/uibase/docvw/OverlayRanges.hxx b/sw/source/uibase/docvw/OverlayRanges.hxx index 829f0c4001dc..d698e2cde3a6 100644 --- a/sw/source/uibase/docvw/OverlayRanges.hxx +++ b/sw/source/uibase/docvw/OverlayRanges.hxx @@ -35,7 +35,7 @@ namespace sw::overlay static std::unique_ptr<OverlayRanges> CreateOverlayRange( SwView const & rDocView, const Color& rColor, - const std::vector< basegfx::B2DRange >& rRanges, + std::vector< basegfx::B2DRange >&& rRanges, const bool bShowSolidBorder ); virtual ~OverlayRanges() override; @@ -47,7 +47,7 @@ namespace sw::overlay } // data write access - void setRanges(const std::vector< basegfx::B2DRange >& rNew); + void setRanges(std::vector< basegfx::B2DRange >&& rNew); void ShowSolidBorder(); void HideSolidBorder(); @@ -55,7 +55,7 @@ namespace sw::overlay private: OverlayRanges( const Color& rColor, - const std::vector< basegfx::B2DRange >& rRanges, + std::vector< basegfx::B2DRange >&& rRanges, const bool bShowSolidBorder ); // geometry creation for OverlayObject |