diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2014-11-12 10:35:18 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-11-12 12:25:18 +0000 |
| commit | 84e44386d70e886f9bae633ebe915ea3a52f8dbd (patch) | |
| tree | 405cf58ea8be3220d7689c5ae9493837c7df325c /sw/source | |
| parent | 1e9a50075bd39e1387f43605eeaa0132af1bd2c0 (diff) | |
coverity#982189 Unchecked return value
Change-Id: I6f5ef42b38236ea5f70ddbccfa25a81f2f3e976c
Diffstat (limited to 'sw/source')
| -rw-r--r-- | sw/source/core/crsr/crstrvl.cxx | 6 | ||||
| -rw-r--r-- | sw/source/core/doc/DocumentLinksAdministrationManager.cxx | 34 |
2 files changed, 18 insertions, 22 deletions
diff --git a/sw/source/core/crsr/crstrvl.cxx b/sw/source/core/crsr/crstrvl.cxx index 73f6e35d91e4..f688b5eeffa5 100644 --- a/sw/source/core/crsr/crstrvl.cxx +++ b/sw/source/core/crsr/crstrvl.cxx @@ -983,10 +983,8 @@ bool SwCrsrShell::GotoPrevOutline() SwNode* pNd = &(pCrsr->GetNode()); sal_uInt16 nPos; - rNds.GetOutLineNds().Seek_Entry( pNd, &nPos ); - - bool bRet = false; - if( nPos ) + bool bRet = rNds.GetOutLineNds().Seek_Entry(pNd, &nPos); + if (bRet && nPos) { --nPos; // before diff --git a/sw/source/core/doc/DocumentLinksAdministrationManager.cxx b/sw/source/core/doc/DocumentLinksAdministrationManager.cxx index 0d2633c71b37..1d596a4ee67c 100644 --- a/sw/source/core/doc/DocumentLinksAdministrationManager.cxx +++ b/sw/source/core/doc/DocumentLinksAdministrationManager.cxx @@ -498,24 +498,22 @@ bool DocumentLinksAdministrationManager::SelectServerObj( const OUString& rStr, const SwOutlineNodes& rOutlNds = m_rDoc.GetNodes().GetOutLineNds(); sal_uInt16 nTmpPos; - if ( rOutlNds.Seek_Entry( pNd, &nTmpPos ) ) - { - rpRange = new SwNodeRange( aPos.nNode, 0, aPos.nNode ); - - // look for the section's end, now - for( ++nTmpPos; - nTmpPos < rOutlNds.size() && - nLvl < rOutlNds[ nTmpPos ]->GetTxtNode()-> - GetAttrOutlineLevel()-1; - ++nTmpPos ) - ; // there is no block - - if( nTmpPos < rOutlNds.size() ) - rpRange->aEnd = *rOutlNds[ nTmpPos ]; - else - rpRange->aEnd = m_rDoc.GetNodes().GetEndOfContent(); - return true; - } + (void)rOutlNds.Seek_Entry( pNd, &nTmpPos ); + rpRange = new SwNodeRange( aPos.nNode, 0, aPos.nNode ); + + // look for the section's end, now + for( ++nTmpPos; + nTmpPos < rOutlNds.size() && + nLvl < rOutlNds[ nTmpPos ]->GetTxtNode()-> + GetAttrOutlineLevel()-1; + ++nTmpPos ) + ; // there is no block + + if( nTmpPos < rOutlNds.size() ) + rpRange->aEnd = *rOutlNds[ nTmpPos ]; + else + rpRange->aEnd = m_rDoc.GetNodes().GetEndOfContent(); + return true; } } |