diff options
| author | Jim Raykowski <raykowj@gmail.com> | 2023-10-17 17:21:33 -0800 |
|---|---|---|
| committer | Jim Raykowski <raykowj@gmail.com> | 2023-11-03 03:18:38 +0100 |
| commit | 167fb166e4097c4a855c08a70cdf70c19d4d87ac (patch) | |
| tree | 216793eb036ef389160ffc7841214fca8577d466 /sw/source | |
| parent | 3e266d5902439f34bc5559d6871f8c9fd6e579bb (diff) | |
tdf#157801 Fix direct formatting is applied after pressing OK in the
Character properties dialog when the Highlighting tab Color page is
open and the color has not been changed
This is noticeable when character highlighting direct formatting is
already at paragraph level.
The expected result of opening the properties dialog, and immediately
pressing OK without changing anything (or alternatively, after
changing something there and then pressing Reset then OK), is no
changes in applied properties at all.
Inspiration for rework of the background tab page. With this patch
XATTR_FILL items need not be included in the InAttrs set, for
example, as part of this patch, the XATTR_FILLSTYLE, XATTR_FILLCOLOR
range is removed from the sw_CharDialog core set.
Change-Id: Ic2de53a29579c33820fc381d354a4afebe048a5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158100
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Diffstat (limited to 'sw/source')
| -rw-r--r-- | sw/source/uibase/shells/textsh1.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sw/source/uibase/shells/textsh1.cxx b/sw/source/uibase/shells/textsh1.cxx index d7fbf8c2674a..746e47dd8668 100644 --- a/sw/source/uibase/shells/textsh1.cxx +++ b/sw/source/uibase/shells/textsh1.cxx @@ -143,7 +143,6 @@ static void sw_CharDialog(SwWrtShell& rWrtSh, bool bUseDialog, bool bApplyToPara RES_CHRATR_BEGIN, RES_CHRATR_END - 1, RES_TXTATR_INETFMT, RES_TXTATR_INETFMT, RES_BACKGROUND, RES_SHADOW, - XATTR_FILLSTYLE, XATTR_FILLCOLOR, SID_ATTR_BORDER_INNER, SID_ATTR_BORDER_INNER, SID_HTML_MODE, SID_HTML_MODE, SID_ATTR_CHAR_WIDTH_FIT_TO_LINE, SID_ATTR_CHAR_WIDTH_FIT_TO_LINE, |