look for =() in loplugin:unnecessaryparen

Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

12 files changed, 18 insertions, 19 deletions

diff --git a/sw/source/core/access/acccontext.cxx b/sw/source/core/access/acccontext.cxx
index fd5356d333fa..0a6414cf148b 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -1215,7 +1215,7 @@ void SwAccessibleContext::InvalidateChildPosOrSize(
             {
                 AccessibleEventObject aEvent;
                 aEvent.EventId = AccessibleEventId::CHILD;
-                aEvent.NewValue <<= (rChildFrameOrObj.GetWindow()->GetAccessible());
+                aEvent.NewValue <<= rChildFrameOrObj.GetWindow()->GetAccessible();
                 FireAccessibleEvent( aEvent );
             }
         }
diff --git a/sw/source/core/crsr/crsrsh.cxx b/sw/source/core/crsr/crsrsh.cxx
index 667b49d789ed..63a487c367a6 100644
--- a/sw/source/core/crsr/crsrsh.cxx
+++ b/sw/source/core/crsr/crsrsh.cxx
@@ -3314,7 +3314,7 @@ void SwCursorShell::ClearUpCursors()
             // If the start entry of the ring is invalid replace it with a
             // cursor pointing to the beginning of the first content node in the
             // document.
-            aIdx = (*(aNodes.GetEndOfContent().StartOfSectionNode()));
+            aIdx = *(aNodes.GetEndOfContent().StartOfSectionNode());
             pNode = aNodes.GoNext( &aIdx );
         }
         bool bFound = (pNode != nullptr);
diff --git a/sw/source/core/crsr/pam.cxx b/sw/source/core/crsr/pam.cxx
index 86aa82e088ce..4e762bfcf218 100644
--- a/sw/source/core/crsr/pam.cxx
+++ b/sw/source/core/crsr/pam.cxx
@@ -457,7 +457,7 @@ void SwPaM::SetMark()
     {
         m_pMark = &m_Bound1;
     }
-    (*m_pMark) = (*m_pPoint);
+    (*m_pMark) = *m_pPoint;
 }
 
 #ifdef DBG_UTIL
diff --git a/sw/source/core/tox/txmsrt.cxx b/sw/source/core/tox/txmsrt.cxx
index 14600c68af1b..87189bcc9d05 100644
--- a/sw/source/core/tox/txmsrt.cxx
+++ b/sw/source/core/tox/txmsrt.cxx
@@ -714,7 +714,7 @@ void    SwTOXAuthority::FillText( SwTextNode& rNd,
             sText = SwAuthorityFieldType::GetAuthTypeName((ToxAuthorityType) --nLevel);
     }
     else
-        sText = (pField->GetFieldText((ToxAuthorityField) nAuthField));
+        sText = pField->GetFieldText((ToxAuthorityField) nAuthField);
     rNd.InsertText( sText, rInsPos );
 }
 
diff --git a/sw/source/core/txtnode/thints.cxx b/sw/source/core/txtnode/thints.cxx
index 3d33f5bf1f5a..aa360444fe2b 100644
--- a/sw/source/core/txtnode/thints.cxx
+++ b/sw/source/core/txtnode/thints.cxx
@@ -2981,9 +2981,9 @@ bool SwpHints::TryInsertHint(
         const sal_uInt16 *pRanges = pSet->GetRanges();
         while( (*pRanges) != 0 )
         {
-            const sal_uInt16 nBeg = (*pRanges);
+            const sal_uInt16 nBeg = *pRanges;
             ++pRanges;
-            const sal_uInt16 nEnd = (*pRanges);
+            const sal_uInt16 nEnd = *pRanges;
             ++pRanges;
             for( sal_uInt16 nSubElem = nBeg; nSubElem <= nEnd; ++nSubElem )
                 if( pSet->HasItem( nSubElem ) )
diff --git a/sw/source/core/unocore/unocrsrhelper.cxx b/sw/source/core/unocore/unocrsrhelper.cxx
index a6dd3ecf1788..9e1b3babed4d 100644
--- a/sw/source/core/unocore/unocrsrhelper.cxx
+++ b/sw/source/core/unocore/unocrsrhelper.cxx
@@ -637,9 +637,8 @@ bool getCursorPropertyValue(const SfxItemPropertySimpleEntry& rEntry
             std::vector<SwTextAttr *> marks;
             if (rPam.GetNode().IsTextNode())
             {
-                marks = (
-                rPam.GetNode().GetTextNode()->GetTextAttrsAt(
-                    rPam.GetPoint()->nContent.GetIndex(), RES_TXTATR_REFMARK));
+                marks = rPam.GetNode().GetTextNode()->GetTextAttrsAt(
+                            rPam.GetPoint()->nContent.GetIndex(), RES_TXTATR_REFMARK);
             }
             if (marks.size())
             {
@@ -1209,7 +1208,7 @@ void makeRedline( SwPaM const & rPaM,
             nMap = PROPERTY_MAP_PARAGRAPH;
         else
             nMap = PROPERTY_MAP_TEXTPORTION_EXTENSIONS;
-        SfxItemPropertySet const& rPropSet = (*aSwMapProvider.GetPropertySet(nMap));
+        SfxItemPropertySet const& rPropSet = *aSwMapProvider.GetPropertySet(nMap);
 
         // Check if there are any properties
         if (aRevertProperties.getLength())
diff --git a/sw/source/core/unocore/unoidx.cxx b/sw/source/core/unocore/unoidx.cxx
index f9fe2b6f4895..e14606334462 100644
--- a/sw/source/core/unocore/unoidx.cxx
+++ b/sw/source/core/unocore/unoidx.cxx
@@ -3038,7 +3038,7 @@ SwXDocumentIndex::TokenAccess_Impl::getByIndex(sal_Int32 nIndex)
                 else
                 {
                     pArr[1].Name = "TabStopPosition";
-                    sal_Int32 nPos = (convertTwipToMm100(aToken.nTabStopPosition));
+                    sal_Int32 nPos = convertTwipToMm100(aToken.nTabStopPosition);
                     if(nPos < 0)
                         nPos = 0;
                     pArr[1].Value <<= nPos;
diff --git a/sw/source/core/unocore/unoobj2.cxx b/sw/source/core/unocore/unoobj2.cxx
index cf1afe3de44a..737a38eec04c 100644
--- a/sw/source/core/unocore/unoobj2.cxx
+++ b/sw/source/core/unocore/unoobj2.cxx
@@ -1539,7 +1539,7 @@ uno::Any SAL_CALL SwXTextRangesImpl::getByIndex(sal_Int32 nIndex)
     if ((nIndex < 0) || (static_cast<size_t>(nIndex) >= m_Ranges.size()))
         throw lang::IndexOutOfBoundsException();
     uno::Any ret;
-    ret <<= (m_Ranges.at(nIndex));
+    ret <<= m_Ranges.at(nIndex);
     return ret;
 }
 
diff --git a/sw/source/ui/index/cnttab.cxx b/sw/source/ui/index/cnttab.cxx
index fadd507f4f75..7cbb0ab13632 100644
--- a/sw/source/ui/index/cnttab.cxx
+++ b/sw/source/ui/index/cnttab.cxx
@@ -3470,7 +3470,7 @@ bool SwTokenWindow::CreateQuickHelp(Control const * pCtrl,
         bool bBalloon = Help::IsBalloonHelpEnabled();
         OUString sEntry;
         if(bBalloon || rToken.eTokenType != TOKEN_AUTHORITY)
-            sEntry = (m_aButtonHelpTexts[rToken.eTokenType]);
+            sEntry = m_aButtonHelpTexts[rToken.eTokenType];
         if(rToken.eTokenType == TOKEN_AUTHORITY )
         {
              sEntry += SwAuthorityFieldType::GetAuthFieldName(
diff --git a/sw/source/ui/index/swuiidxmrk.cxx b/sw/source/ui/index/swuiidxmrk.cxx
index c3266c823339..61249f585796 100644
--- a/sw/source/ui/index/swuiidxmrk.cxx
+++ b/sw/source/ui/index/swuiidxmrk.cxx
@@ -709,7 +709,7 @@ void SwIndexMarkPane::ModifyHdl(Control const * pBox)
     }
     else //m_pEntryED  !!m_pEntryED is not a ListBox but a Edit
     {
-        bool bHasText = (!m_pEntryED->GetText().isEmpty());
+        bool bHasText = !m_pEntryED->GetText().isEmpty();
         if(!bHasText)
         {
             m_pPhoneticED0->SetText(OUString());
@@ -933,8 +933,8 @@ IMPL_LINK( SwIndexMarkPane, KeyDCBModifyHdl, Edit&, rEdit, void )
                 m_pPhoneticED2->SetText(GetDefaultPhoneticReading(pBox->GetText()));
         }
     }
-    bool    bKey1HasText    = (!m_pKey1DCB->GetText().isEmpty());
-    bool    bKey2HasText    = (!m_pKey2DCB->GetText().isEmpty());
+    bool    bKey1HasText    = !m_pKey1DCB->GetText().isEmpty();
+    bool    bKey2HasText    = !m_pKey2DCB->GetText().isEmpty();
 
     m_pPhoneticFT1->Enable(bKey1HasText && bIsPhoneticReadingEnabled);
     m_pPhoneticED1->Enable(bKey1HasText && bIsPhoneticReadingEnabled);
diff --git a/sw/source/ui/misc/glosbib.cxx b/sw/source/ui/misc/glosbib.cxx
index be6c855a8af3..d54e457f079b 100644
--- a/sw/source/ui/misc/glosbib.cxx
+++ b/sw/source/ui/misc/glosbib.cxx
@@ -383,7 +383,7 @@ IMPL_LINK_NOARG(SwGlossaryGroupDlg, ModifyHdl, Edit&, void)
 
 bool SwGlossaryGroupDlg::IsDeleteAllowed(const OUString &rGroup)
 {
-    bool bDel = (!pGlosHdl->IsReadOnly(&rGroup));
+    bool bDel = !pGlosHdl->IsReadOnly(&rGroup);
 
     // OM: if the name is among the new region name, it is deletable
     // as well! Because for non existing region names ReadOnly issues
diff --git a/sw/source/uibase/uiview/viewsrch.cxx b/sw/source/uibase/uiview/viewsrch.cxx
index 479be401bd7e..6be76c0485c3 100644
--- a/sw/source/uibase/uiview/viewsrch.cxx
+++ b/sw/source/uibase/uiview/viewsrch.cxx
@@ -699,8 +699,8 @@ void SwView::Replace()
         {
             /* check that the selection match the search string*/
             //save state
-            SwPosition aStartPos = (* m_pWrtShell->GetSwCursor()->Start());
-            SwPosition aEndPos = (* m_pWrtShell->GetSwCursor()->End());
+            SwPosition aStartPos = * m_pWrtShell->GetSwCursor()->Start();
+            SwPosition aEndPos = * m_pWrtShell->GetSwCursor()->End();
             bool   bHasSelection = m_pSrchItem->GetSelection();
             SvxSearchCmd nOldCmd = m_pSrchItem->GetCommand();