diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2024-08-07 07:54:46 +0200 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2024-08-07 16:10:44 +0200 |
| commit | 8950ae3095c43d6217cb53d1e8969ccf3a0b56ac (patch) | |
| tree | 33c014cb9073d87039058a1cd9259199733f88dc /sw/uiconfig | |
| parent | 0633189fabe85f73062ff2ce67b5f40af7d3f504 (diff) | |
sw a11y: Add a11y names for bg settings in side bar
Set a11y names for UI elements related to the page
background in Writer's "Page" sidebar deck, section
"Styles."
Some of those combo boxes/menu buttons are reused for
multiple background types, so set an a11y name
depending on the currently selected background
type in C++ code instead of a static one in the .ui
file for these.
This allows screen readers to announce what those
comboboxes/menu buttons are for when they receive
focus.
Lack of some of those led to gla11y failures in pending
Gerrit change [1], but is actually a preexisting issue
as mentioned in [2].
(The gla11y issue even showed up after simply resaving
pagestylespanel.ui with glade 3.40, see CI failure for [3],
a previous change doing that in preparation for this
commit, but now squashed into this commit.)
[1] https://gerrit.libreoffice.org/c/core/+/171430
[2] https://gerrit.libreoffice.org/c/core/+/171430/comments/6fac1506_50ddcce5
[3] https://gerrit.libreoffice.org/c/core/+/171582
Change-Id: I4e78c61cfd5d5b9f198887eec53be368cb6a0716
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171583
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Diffstat (limited to 'sw/uiconfig')
| -rw-r--r-- | sw/uiconfig/swriter/ui/pagestylespanel.ui | 25 |
1 files changed, 16 insertions, 9 deletions
diff --git a/sw/uiconfig/swriter/ui/pagestylespanel.ui b/sw/uiconfig/swriter/ui/pagestylespanel.ui index a60f61f1c339..f966e4be5cd9 100644 --- a/sw/uiconfig/swriter/ui/pagestylespanel.ui +++ b/sw/uiconfig/swriter/ui/pagestylespanel.ui @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<!-- Generated with glade 3.38.2 --> +<!-- Generated with glade 3.40.0 --> <interface domain="sw"> <requires lib="gtk+" version="3.20"/> <object class="GtkListStore" id="liststore4"> @@ -159,9 +159,11 @@ </child> <child> <object class="GtkCellRendererPixbuf" id="cellrenderertext4"/> - <attributes> - <attribute name="surface">3</attribute> - </attributes> + </child> + <child internal-child="accessible"> + <object class="AtkObject" id="lbhatching-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="pagestylespanel|hatching|accessible_name">Background Hatching</property> + </object> </child> </object> <packing> @@ -185,9 +187,6 @@ </child> <child> <object class="GtkCellRendererPixbuf" id="cellrenderertext6"/> - <attributes> - <attribute name="surface">3</attribute> - </attributes> </child> </object> <packing> @@ -205,10 +204,14 @@ <property name="hexpand">True</property> <property name="xalign">0</property> <property name="draw-indicator">True</property> - <property name="label" translatable="no"></property> <child> <placeholder/> </child> + <child internal-child="accessible"> + <object class="AtkObject" id="lbcolor-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="pagestylespanel|background_color|accessible_name">Background Color</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> @@ -225,10 +228,14 @@ <property name="hexpand">True</property> <property name="xalign">0</property> <property name="draw-indicator">True</property> - <property name="label" translatable="no"></property> <child> <placeholder/> </child> + <child internal-child="accessible"> + <object class="AtkObject" id="lbgradient-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="pagestylespanel|second_gradient_color">Second gradient color</property> + </object> + </child> </object> <packing> <property name="left-attach">1</property> |