summaryrefslogtreecommitdiff
path: root/sw
diff options
context:
space:
mode:
authorXisco Fauli <xiscofauli@libreoffice.org>2018-10-21 22:47:24 +0200
committerCaolán McNamara <caolanm@redhat.com>2018-10-22 10:00:27 +0200
commitb9e4f8e1d7464858f15030ee55aa2b4a8b86e427 (patch)
treefc26be7e68620e1725bf14d8c42df0e0c9f0e1a8 /sw
parentfbfb65f140f0dea1c782d1d4c97f272d40135426 (diff)
tdf#120703 (PVS): Recurring check.
V571 The 'pColumn->GetWidthOption()' condition was already verified in line 1033. Change-Id: I5bc11bceddc8090f41bf86b45f880ceea3dfb204 Reviewed-on: https://gerrit.libreoffice.org/62158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sw')
-rw-r--r--sw/source/core/doc/htmltbl.cxx13
1 files changed, 5 insertions, 8 deletions
diff --git a/sw/source/core/doc/htmltbl.cxx b/sw/source/core/doc/htmltbl.cxx
index da0135abd966..346c67c552fe 100644
--- a/sw/source/core/doc/htmltbl.cxx
+++ b/sw/source/core/doc/htmltbl.cxx
@@ -1032,14 +1032,11 @@ void SwHTMLTableLayout::AutoLayoutPass1()
SwHTMLTableLayoutColumn *pColumn = GetColumn( i );
if (pColumn->IsRelWidthOption() && pColumn->GetWidthOption() && nQuotMax)
{
- if( pColumn->GetWidthOption() )
- {
- pColumn->SetMax( pColumn->GetMax() / nQuotMax );
- OSL_ENSURE( pColumn->GetMax() >= pColumn->GetMin(),
- "Minimum width is one column bigger than maximum" );
- if( pColumn->GetMax() < pColumn->GetMin() )
- pColumn->SetMax( pColumn->GetMin() );
- }
+ pColumn->SetMax( pColumn->GetMax() / nQuotMax );
+ OSL_ENSURE( pColumn->GetMax() >= pColumn->GetMin(),
+ "Minimum width is one column bigger than maximum" );
+ if( pColumn->GetMax() < pColumn->GetMin() )
+ pColumn->SetMax( pColumn->GetMin() );
}
m_nMax += pColumn->GetMax();
}
light'> Change-Id: Ifeae43257ce9c2ba8513652c21b512bcffd87841 2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann Change-Id: Ib340ec1731cba5a4409f0e8d8bdde48753312672 2016-02-09Remove excess newlinesChris Sherlock A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> 2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d 2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann Change-Id: I72bf3e008a8941d6e0fdea81b6b3e4a959ff28c5 2015-11-09com::sun::star->css in tools/ and ucb/Noel Grandin Change-Id: I695ff721efd63b8ca0dd3c61ba5a4fef2c43cde6 Reviewed-on: https://gerrit.libreoffice.org/19854 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> 2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin Change-Id: Id036f867e75d03d8347cc32a1011c5cdda1dcc73 2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274 2015-09-30Fix typosAndrea Gelmini Change-Id: I3926eca56ac9f54f9ddbf88610888ce97cf00b34 Reviewed-on: https://gerrit.libreoffice.org/18990 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> 2015-09-23boost::scoped_ptr->std::unique_ptrCaolán McNamara Change-Id: I03020e3536ee692a96224a517794c0d0a294f607 Reviewed-on: https://gerrit.libreoffice.org/18793 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> 2015-05-26cppcheck: noExplicitConstructorCaolán McNamara Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029 2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann Change-Id: I8d1a4fda1cdd679f20de37271f7b832da4fb0c9a 2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann Change-Id: I4df86baf0106283c78942c40a4b5830dd9c91195 2014-12-18ucb: Use appropriate OUString functions on string constantsStephan Bergmann Change-Id: Ie889b3e74160e9ba121ba8351d9e12f6d273c573 2014-10-31coverity#707418 Uncaught exceptionCaolán McNamara and coverity#707419 Uncaught exception coverity#707420 Uncaught exception Change-Id: I98d752c14be5f7b1fccb4bdf2eeefb6bbfe12e0e 2014-07-25Avoid possible memory leaks in case of exceptionsTakeshi Abe Change-Id: I9983e858c4e634b4cac8ad42fa9b06b7ccc167d6 2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9Julien Nabet Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf 2014-04-30ucb: sal_Bool->boolNoel Grandin Change-Id: If79913653f22387ab6d5a376d9cf26751525168a 2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a 2014-03-20kill ucbhelper XTYPEPROVIDER_DECL macroNorbert Thiebaud Change-Id: I1daf6661dd7b5be396bec980da84feaab6e6b80f 2014-03-05kill XINTERFACE_IMPL_3Norbert Thiebaud Change-Id: I72448b67ae52e89c206f9c313b3d351ae2a56dc3 2014-03-05kill XINTERFACE_IMPL_2Norbert Thiebaud Change-Id: Ic735b7d6ddfaacab9af7405e4dacc62f818bed8c 2014-03-05de-macroize XINTERFACE_COMMON_IMPLNorbert Thiebaud Change-Id: I7cffc8a111dd939272c6dbef8827b6f5c04a4590 Reviewed-on: https://gerrit.libreoffice.org/8455 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> 2014-03-05de-macroize XINTERFACE_DECLNorbert Thiebaud Change-Id: Iaa1cf999189f6b62547c208eadc38150400ca0fe Reviewed-on: https://gerrit.libreoffice.org/8454 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com> 2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3 2014-02-23Remove unneccessary commentsAlexander Wilms Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>