uitest: pass OUString by const reference and formatting fixes

Change-Id: I55eca745a84998c74e2d925ed53af20382d98289

3 files changed, 16 insertions, 15 deletions

diff --git a/sw/source/core/edit/edtab.cxx b/sw/source/core/edit/edtab.cxx
index edb2510f8347..c60aed7af194 100644
--- a/sw/source/core/edit/edtab.cxx
+++ b/sw/source/core/edit/edtab.cxx
@@ -55,11 +55,11 @@ using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
 namespace {
 
-void collectUIInformation(const OUString action,const OUString aParameters)
+void collectUIInformation(const OUString& rAction, const OUString& aParameters)
 {
     EventDescription aDescription;
-    aDescription.aAction = action;
-    aDescription.aParameters = {{"parameters",aParameters}};
+    aDescription.aAction = rAction;
+    aDescription.aParameters = {{"parameters", aParameters}};
     aDescription.aID = "writer_edit";
     aDescription.aKeyWord = "SwEditWinUIObject";
     aDescription.aParent = "MainWindow";
@@ -129,8 +129,9 @@ const SwTable& SwEditShell::InsertTable( const SwInsertTableOptions& rInsTableOp
         EndUndo( SwUndoId::END );
 
     EndAllAction();
-    OUString parameter = " Columns : " + OUString::number( nCols )+ " , Rows : " +OUString::number( nRows ) +" ";
-    collectUIInformation("CREATE_TABLE",parameter);
+
+    OUString parameter = " Columns : " + OUString::number( nCols ) + " , Rows : " + OUString::number( nRows ) + " ";
+    collectUIInformation("CREATE_TABLE", parameter);
 
     return *pTable;
 }
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx b/sw/source/uibase/dochdl/swdtflvr.cxx
index 8a192441b769..0d5a46119ab3 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -165,11 +165,11 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::datatransfer;
 namespace {
 
-void collectUIInformation(const OUString action,const OUString aParameters)
+void collectUIInformation(const OUString& rAction, const OUString& aParameters)
 {
     EventDescription aDescription;
-    aDescription.aAction = action;
-    aDescription.aParameters = {{"parameters",aParameters}};
+    aDescription.aAction = rAction;
+    aDescription.aParameters = {{"parameters", aParameters}};
     aDescription.aID = "writer_edit";
     aDescription.aKeyWord = "SwEditWinUIObject";
     aDescription.aParent = "MainWindow";
@@ -846,7 +846,7 @@ int SwTransferable::Cut()
     int nRet = Copy( true );
     if( nRet )
         DeleteSelection();
-    collectUIInformation("CUT","parameter");
+    collectUIInformation("CUT", "parameter");
     return nRet;
 }
 
@@ -1113,7 +1113,7 @@ int SwTransferable::Copy( bool bIsCut )
     }
 
     if( !bIsCut ){
-        collectUIInformation("COPY","parameter");
+        collectUIInformation("COPY", "parameter");
     }
 
     return nRet;
@@ -1433,7 +1433,7 @@ bool SwTransferable::Paste(SwWrtShell& rSh, TransferableDataHelper& rData, RndSt
         }
     }
 
-    collectUIInformation("PASTE","parameter");
+    collectUIInformation("PASTE", "parameter");
 
     return EXCHG_INOUT_ACTION_NONE != nAction &&
             SwTransferable::PasteData( rData, rSh, nAction, nActionFlags, nFormat,
diff --git a/sw/source/uibase/wrtsh/wrtsh1.cxx b/sw/source/uibase/wrtsh/wrtsh1.cxx
index 87202b3cd219..cd5a638250e8 100644
--- a/sw/source/uibase/wrtsh/wrtsh1.cxx
+++ b/sw/source/uibase/wrtsh/wrtsh1.cxx
@@ -121,11 +121,11 @@ using namespace sw::mark;
 using namespace com::sun::star;
 namespace {
 
-void collectUIInformation(const OUString action,const OUString aParameters)
+void collectUIInformation(const OUString& rAction, const OUString& aParameters)
 {
     EventDescription aDescription;
-    aDescription.aAction = action;
-    aDescription.aParameters = {{"parameters",aParameters}};
+    aDescription.aAction = rAction;
+    aDescription.aParameters = {{"parameters", aParameters}};
     aDescription.aID = "writer_edit";
     aDescription.aKeyWord = "SwEditWinUIObject";
     aDescription.aParent = "MainWindow";
@@ -912,7 +912,7 @@ void SwWrtShell::InsertPageBreak(const OUString *pPageDesc, const ::boost::optio
             SetAttrItem( SvxFormatBreakItem(SvxBreak::PageBefore, RES_BREAK) );
         EndUndo(SwUndoId::UI_INSERT_PAGE_BREAK);
     }
-    collectUIInformation("BREAK_PAGE","parameter");
+    collectUIInformation("BREAK_PAGE", "parameter");
 }
 
 // Insert hard page break;