diff options
| author | Zolnai Tamás <tamas.zolnai@collabora.com> | 2013-12-27 09:45:05 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2013-12-28 08:46:49 +0000 |
| commit | c2d4ad7e40f1981da84c467f5b4e775899eeeb1a (patch) | |
| tree | c35b19d380ade5e7c2889a00e6086ac2dd25aadc /sw | |
| parent | dbd8709af0545b0372c28c5ff36effba68bca580 (diff) | |
Fix stepping to the next change
Bug description:
In the "Accept or Reject Changes" dialog, when select a change
(it should be after the first few ones) and clicking "Accept"
or "Reject" button, acception/rejection is made but after it
not the next change is selected for futher work,
but a random one. This bug doesn't appear in all case,
just if changes are complex enough.
Solution:
The nPos means absolute position so we have to get the next entry
with the corresponding GetEntryAtAbsPos() method. It seems simple
position can differ from absolute positions if changes are
complex enough.
Change-Id: I7996f81c2a09c492f9334f071591291d200d533f
(cherry picked from commit dbd8a631bb23c588f52102e5dd2a61c9cd854bc3)
Reviewed-on: https://gerrit.libreoffice.org/7210
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/source/ui/misc/redlndlg.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sw/source/ui/misc/redlndlg.cxx b/sw/source/ui/misc/redlndlg.cxx index 298058b0de2b..907cdfeb74ea 100644 --- a/sw/source/ui/misc/redlndlg.cxx +++ b/sw/source/ui/misc/redlndlg.cxx @@ -833,9 +833,9 @@ void SwRedlineAcceptDlg::CallAcceptReject( sal_Bool bSelect, sal_Bool bAccept ) { if( nPos >= pTable->GetEntryCount() ) nPos = pTable->GetEntryCount() - 1; - pEntry = pTable->GetEntry( nPos ); + pEntry = pTable->GetEntryAtAbsPos( nPos ); if( !pEntry && nPos-- ) - pEntry = pTable->GetEntry( nPos ); + pEntry = pTable->GetEntryAtAbsPos( nPos ); if( pEntry ) { pTable->Select( pEntry ); |