new loplugin:emptyif

Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

8 files changed, 1 insertions, 25 deletions

diff --git a/sw/source/core/fields/dbfld.cxx b/sw/source/core/fields/dbfld.cxx
index 2d1036918eb0..71fb67b21a3f 100644
--- a/sw/source/core/fields/dbfld.cxx
+++ b/sw/source/core/fields/dbfld.cxx
@@ -868,8 +868,6 @@ bool SwDBSetNumberField::PutValue( const uno::Any& rAny, sal_uInt16 nWhichId )
             rAny >>= nSet;
             if(nSet < css::style::NumberingType::NUMBER_NONE )
                 SetFormat(nSet);
-            else {
-            }
         }
         break;
     case FIELD_PROP_FORMAT:
diff --git a/sw/source/core/fields/docufld.cxx b/sw/source/core/fields/docufld.cxx
index 47a7463b298e..8bc6e6912543 100644
--- a/sw/source/core/fields/docufld.cxx
+++ b/sw/source/core/fields/docufld.cxx
@@ -275,8 +275,6 @@ bool SwPageNumberField::PutValue( const uno::Any& rAny, sal_uInt16 nWhichId )
         // TODO: where do the defines come from?
         if(nSet <= SVX_NUM_PAGEDESC )
             SetFormat(nSet);
-        else {
-        }
         break;
     case FIELD_PROP_USHORT1:
         rAny >>= nSet;
@@ -2381,8 +2379,6 @@ bool SwRefPageGetField::PutValue( const uno::Any& rAny, sal_uInt16 nWhichId )
             rAny >>= nSet;
             if(nSet <= SVX_NUM_PAGEDESC )
                 SetFormat(nSet);
-            else {
-            }
         }
         break;
         case FIELD_PROP_PAR1:
diff --git a/sw/source/core/para/paratr.cxx b/sw/source/core/para/paratr.cxx
index 52d5172b08ff..68dc9bd1c5df 100644
--- a/sw/source/core/para/paratr.cxx
+++ b/sw/source/core/para/paratr.cxx
@@ -179,8 +179,6 @@ bool SwFormatDrop::PutValue( const uno::Any& rVal, sal_uInt8 nMemberId )
                 nChars      = pDrop->Count;
                 nDistance   = convertMm100ToTwip(pDrop->Distance);
             }
-            else {
-            }
         }
         break;
         case MID_DROPCAP_WHOLE_WORD:
diff --git a/sw/source/filter/html/htmlflywriter.cxx b/sw/source/filter/html/htmlflywriter.cxx
index 757a08378df4..cece99430a9a 100644
--- a/sw/source/filter/html/htmlflywriter.cxx
+++ b/sw/source/filter/html/htmlflywriter.cxx
@@ -2008,10 +2008,6 @@ void SwHTMLWriter::AddLinkTarget( const OUString& rURL )
             m_aOutlineMarks.insert( m_aOutlineMarks.begin()+nIns, aURL );
         }
     }
-    else if( sCmp == "text" )
-    {
-
-    }
 }
 
 void SwHTMLWriter::CollectLinkTargets()
diff --git a/sw/source/ui/dbui/addresslistdialog.cxx b/sw/source/ui/dbui/addresslistdialog.cxx
index 3782b92bf1c1..77890e3b27fc 100644
--- a/sw/source/ui/dbui/addresslistdialog.cxx
+++ b/sw/source/ui/dbui/addresslistdialog.cxx
@@ -453,13 +453,10 @@ IMPL_LINK(SwAddressListDialog, EditHdl_Impl, Button*, pButton, void)
             // will automatically close if it was the las reference
         VclPtr<SwCreateAddressListDialog> pDlg(
                 VclPtr<SwCreateAddressListDialog>::Create(
-
                         pButton,
                         pUserData->sURL,
                         m_pAddressPage->GetWizard()->GetConfigItem()));
-        if(RET_OK == pDlg->Execute())
-        {
-        }
+        pDlg->Execute();
     }
 };
 
diff --git a/sw/source/ui/misc/insfnote.cxx b/sw/source/ui/misc/insfnote.cxx
index 0cd368d5eb98..cfd94f281ef1 100644
--- a/sw/source/ui/misc/insfnote.cxx
+++ b/sw/source/ui/misc/insfnote.cxx
@@ -72,10 +72,6 @@ void SwInsFootNoteDlg::Apply()
         rSh.EndUndo( SwUndoId::END );
         rSh.EndAction();
     }
-    else
-    {
-
-    }
 
     bFootnote = m_pFootnoteBtn->IsChecked();
 }
diff --git a/sw/source/uibase/ribbar/workctrl.cxx b/sw/source/uibase/ribbar/workctrl.cxx
index 6fee4959d27c..76d2a0eee08b 100644
--- a/sw/source/uibase/ribbar/workctrl.cxx
+++ b/sw/source/uibase/ribbar/workctrl.cxx
@@ -812,9 +812,6 @@ bool NavElementBox_Impl::EventNotify( NotifyEvent& rNEvt )
                 break;
         }
     }
-    else if( MouseNotifyEvent::LOSEFOCUS == rNEvt.GetType() )
-    {
-    }
 
     return bHandled || ListBox::EventNotify( rNEvt );
 }
diff --git a/sw/source/uibase/utlui/unotools.cxx b/sw/source/uibase/utlui/unotools.cxx
index 70cbb0994e6b..849511797d45 100644
--- a/sw/source/uibase/utlui/unotools.cxx
+++ b/sw/source/uibase/utlui/unotools.cxx
@@ -320,8 +320,6 @@ IMPL_LINK( SwOneExampleFrame, TimeoutHdl, Timer*, pTimer, void )
                   {
                     pSh->Overwrite(SwResId(STR_IDXEXAMPLE_IDXTXT_IMAGE1));
                   }
-                  else
-                  {}
                 }
                 while(pSh->Right(sal_uInt16(1), sal_uInt16(1), true));
             }