diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-14 09:58:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2014-05-14 08:10:22 +0000 |
| commit | 248145f99e95cc30bb6231a8e5ea4e294f147040 (patch) | |
| tree | c3b5c1e226cc631cde530f2cfb7df2d46f00b8c9 /sw | |
| parent | 671eb12dee290607ed66f3b325f28e7bd4695cba (diff) | |
Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/source/core/uibase/inc/mmconfigitem.hxx | 2 | ||||
| -rw-r--r-- | sw/source/core/uibase/inc/olmenu.hxx | 2 | ||||
| -rw-r--r-- | sw/source/core/uibase/lingu/olmenu.cxx | 2 | ||||
| -rw-r--r-- | sw/source/filter/ww8/docxsdrexport.cxx | 2 | ||||
| -rw-r--r-- | sw/source/filter/ww8/docxsdrexport.hxx | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/sw/source/core/uibase/inc/mmconfigitem.hxx b/sw/source/core/uibase/inc/mmconfigitem.hxx index 32a3b44dd0e2..b40e189b1c11 100644 --- a/sw/source/core/uibase/inc/mmconfigitem.hxx +++ b/sw/source/core/uibase/inc/mmconfigitem.hxx @@ -104,7 +104,7 @@ public: ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any> GetSelection()const; - void SetSelection(::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any > rSelection); + void SetSelection(const ::com::sun::star::uno::Sequence< ::com::sun::star::uno::Any >& rSelection); void SetCurrentDBData( const SwDBData& rDBData); const SwDBData& GetCurrentDBData() const; diff --git a/sw/source/core/uibase/inc/olmenu.hxx b/sw/source/core/uibase/inc/olmenu.hxx index f85b9febd0b3..084c4a50a407 100644 --- a/sw/source/core/uibase/inc/olmenu.hxx +++ b/sw/source/core/uibase/inc/olmenu.hxx @@ -61,7 +61,7 @@ class SW_DLLPUBLIC SwSpellPopup : public PopupMenu Image m_aInfo16; void fillLangPopupMenu( PopupMenu *pPopupMenu, sal_uInt16 nLangStart, - ::com::sun::star::uno::Sequence< OUString > aSeq, SwWrtShell* pWrtSh, + const ::com::sun::star::uno::Sequence< OUString >& aSeq, SwWrtShell* pWrtSh, std::map< sal_Int16, OUString > &rLangTable ); using PopupMenu::Execute; diff --git a/sw/source/core/uibase/lingu/olmenu.cxx b/sw/source/core/uibase/lingu/olmenu.cxx index 62bbf2deaad9..62731cfbf3fb 100644 --- a/sw/source/core/uibase/lingu/olmenu.cxx +++ b/sw/source/core/uibase/lingu/olmenu.cxx @@ -115,7 +115,7 @@ static inline bool lcl_checkScriptType( sal_Int16 nScriptType, LanguageType nLan void SwSpellPopup::fillLangPopupMenu( PopupMenu *pPopupMenu, sal_uInt16 nLangItemIdStart, - uno::Sequence< OUString > aSeq, + const uno::Sequence< OUString >& aSeq, SwWrtShell* pWrtSh, std::map< sal_Int16, OUString > &rLangTable ) { diff --git a/sw/source/filter/ww8/docxsdrexport.cxx b/sw/source/filter/ww8/docxsdrexport.cxx index 2181568681f4..4f9aa336abf2 100644 --- a/sw/source/filter/ww8/docxsdrexport.cxx +++ b/sw/source/filter/ww8/docxsdrexport.cxx @@ -791,7 +791,7 @@ void DocxSdrExport::writeDMLEffectLst(const SwFrmFmt& rFrmFmt) } void DocxSdrExport::writeDiagramRels(uno::Reference<xml::dom::XDocument> xDom, - uno::Sequence< uno::Sequence< uno::Any > > xRelSeq, + const uno::Sequence< uno::Sequence< uno::Any > >& xRelSeq, uno::Reference< io::XOutputStream > xOutStream, const OUString& sGrabBagProperyName, int nAnchorId) { diff --git a/sw/source/filter/ww8/docxsdrexport.hxx b/sw/source/filter/ww8/docxsdrexport.hxx index b54cad4660b5..5b0a21d91b9f 100644 --- a/sw/source/filter/ww8/docxsdrexport.hxx +++ b/sw/source/filter/ww8/docxsdrexport.hxx @@ -83,7 +83,7 @@ public: /// Writes a diagram (smartart). void writeDiagram(const SdrObject* sdrObject, const SwFrmFmt& rFrmFmt, int nAnchorId); void writeDiagramRels(com::sun::star::uno::Reference< com::sun::star::xml::dom::XDocument> xDom, - com::sun::star::uno::Sequence< com::sun::star::uno::Sequence< com::sun::star::uno::Any > > xRelSeq, + const com::sun::star::uno::Sequence< com::sun::star::uno::Sequence< com::sun::star::uno::Any > >& xRelSeq, com::sun::star::uno::Reference< com::sun::star::io::XOutputStream > xOutStream, const OUString& sGrabBagProperyName, int nAnchorId); /// Writes text frame in DML format. |