diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-15 11:27:44 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-05-16 08:45:17 +0200 |
commit | 98c4cd372bf0e9d4b5b129405f5af4562d8a0f64 (patch) | |
tree | f3aae749f01d0453a227b922a6ad3217171700d7 /sw | |
parent | 666901bc82fab69f9a80b564f97b5456d0ef684e (diff) |
loplugin:unusedfields improve write-only analysis
by whitelisting a couple of methods we know only write to their
parameters
Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c
Reviewed-on: https://gerrit.libreoffice.org/37647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw')
-rw-r--r-- | sw/source/uibase/inc/SwXFilterOptions.hxx | 1 | ||||
-rw-r--r-- | sw/source/uibase/uno/SwXFilterOptions.cxx | 4 |
2 files changed, 1 insertions, 4 deletions
diff --git a/sw/source/uibase/inc/SwXFilterOptions.hxx b/sw/source/uibase/inc/SwXFilterOptions.hxx index 4c32cc0b588b..1674285e5364 100644 --- a/sw/source/uibase/inc/SwXFilterOptions.hxx +++ b/sw/source/uibase/inc/SwXFilterOptions.hxx @@ -37,7 +37,6 @@ class SwXFilterOptions : public ::cppu::WeakImplHelper< css::document::XExporter, css::lang::XServiceInfo > { - OUString sFilterName; OUString sFilterOptions; css::uno::Reference< css::io::XInputStream > xInputStream; diff --git a/sw/source/uibase/uno/SwXFilterOptions.cxx b/sw/source/uibase/uno/SwXFilterOptions.cxx index 512163200986..b30874bd560b 100644 --- a/sw/source/uibase/uno/SwXFilterOptions.cxx +++ b/sw/source/uibase/uno/SwXFilterOptions.cxx @@ -70,9 +70,7 @@ void SwXFilterOptions::setPropertyValues( const uno::Sequence<beans::PropertyV const beans::PropertyValue& rProp = pPropArray[i]; OUString aPropName = rProp.Name; - if ( aPropName == UNO_NAME_FILTER_NAME ) - rProp.Value >>= sFilterName; - else if ( aPropName == FILTER_OPTIONS_NAME ) + if ( aPropName == FILTER_OPTIONS_NAME ) rProp.Value >>= sFilterOptions; else if ( aPropName == "InputStream" ) rProp.Value >>= xInputStream; |