summaryrefslogtreecommitdiff
path: root/sw
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2024-02-22 12:28:44 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2024-02-22 17:48:23 +0100
commitee118a5e6977343a03064a0a1a54aee919296a36 (patch)
tree2cfb12589f16a3f22190b961119d7ad2f3b7a9ce /sw
parentac1bb5eda15dd3033c549a3df9c2c7b4862a6bbc (diff)
fix dodgy unit test
Testing a field which is being modified inside a synchronized block, outside of such a block, is going to lead to weird ordering issues when running a highly parallel test like this, so test the flag inside a synchronized block. Failure manifested as: JUnit version 4.13.2 ........E........... Time: 17,27 There was 1 failure: 1) testStaticThreadExecutesAsyncs(com.sun.star.lib.uno.environments.remote.JobQueue_Test) java.lang.AssertionError: expected:<35> but was:<34> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at com.sun.star.lib.uno.environments.remote.TestWorkAt.passedAsyncTest(TestWorkAt.java:75) at com.sun.star.lib.uno.environments.remote.JobQueue_Test.testAsyncJobQueue(JobQueue_Test.java:180) at com.sun.star.lib.uno.environments.remote.JobQueue_Test.testStaticThreadExecutesAsyncs(JobQueue_Test.java:121) FAILURES!!! Tests run: 19, Failures: 1 Change-Id: Iad980aea1245bfd8ee89887b175eb9dc17643778 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163727 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw')
0 files changed, 0 insertions, 0 deletions