diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-03-19 15:07:09 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-03-19 21:19:21 +0100 |
| commit | cce17de6e7736341056604fc391c78295b097a7d (patch) | |
| tree | a8f52d5262cc191b615949a43a691ee0b89a4894 /sw | |
| parent | 864c129a7714085d371c2b127cbc8e5c862347e6 (diff) | |
coverity#1430077 add assert for 'Division or modulo by zero'
and
coverity#1430076 Division or modulo by zero
coverity#1430078 Division or modulo by float zero
coverity#1430082 Division or modulo by float zero
coverity#1430083 Division or modulo by zero
coverity#1430085 Division or modulo by zero
coverity#1430102 Division or modulo by zero
coverity#1430103 Division or modulo by zero
Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46
Reviewed-on: https://gerrit.libreoffice.org/51568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/source/ui/dbui/mmoutputtypepage.cxx | 5 | ||||
| -rw-r--r-- | sw/source/ui/misc/pggrid.cxx | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/sw/source/ui/dbui/mmoutputtypepage.cxx b/sw/source/ui/dbui/mmoutputtypepage.cxx index ed7fcba2d4df..0725959da127 100644 --- a/sw/source/ui/dbui/mmoutputtypepage.cxx +++ b/sw/source/ui/dbui/mmoutputtypepage.cxx @@ -573,8 +573,11 @@ void SwSendMailDialog::UpdateTransferStatus() sStatus = m_sErrorStatus.replaceFirst("%1", OUString::number(m_nErrorCount) ); m_pErrorStatus->SetText(sStatus); - if(m_pImpl->aDescriptors.size()) + if (m_pImpl->aDescriptors.size()) + { + assert(m_nExpectedCount && "div-by-zero"); m_pProgressBar->SetValue(static_cast<sal_uInt16>(m_nSendCount * 100 / m_nExpectedCount)); + } else m_pProgressBar->SetValue(0); } diff --git a/sw/source/ui/misc/pggrid.cxx b/sw/source/ui/misc/pggrid.cxx index 2ec697256232..df3717390434 100644 --- a/sw/source/ui/misc/pggrid.cxx +++ b/sw/source/ui/misc/pggrid.cxx @@ -417,7 +417,9 @@ IMPL_LINK(SwTextGridPage, CharorLineChangedHdl, SpinField&, rField, void) } else if (m_pCharsPerLineNF == &rField) { - long nWidth = static_cast< sal_Int32 >(m_aPageSize.Width() / m_pCharsPerLineNF->GetValue()); + auto nValue = m_pCharsPerLineNF->GetValue(); + assert(nValue && "div-by-zero"); + long nWidth = static_cast< sal_Int32 >(m_aPageSize.Width() / nValue); m_pCharWidthMF->SetValue(m_pCharWidthMF->Normalize(nWidth), FUNIT_TWIP); SetLinesOrCharsRanges( *m_pCharsRangeFT , m_pCharsPerLineNF->GetMax() ); } |