diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-12-29 19:27:43 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-12-29 19:46:23 +0000 |
commit | bea8a7ad63e6e00c757909702f0439b2ffd3b48a (patch) | |
tree | 423bc1b62e0aedcb308ec26214ece158ae3fe76a /sw | |
parent | 79a1ba61e4753758f66ba25b128aeff96ea716c9 (diff) |
cppcheck: noExplicitConstructor
Change-Id: Ib43e53d5b6c9c130adb765ac9b769f58060ac640
Diffstat (limited to 'sw')
-rw-r--r-- | sw/source/core/unocore/unosett.cxx | 6 | ||||
-rw-r--r-- | sw/source/core/unocore/unostyle.cxx | 4 | ||||
-rw-r--r-- | sw/source/core/unocore/unotbl.cxx | 6 | ||||
-rw-r--r-- | sw/source/uibase/sidebar/StylePresetsPanel.hxx | 2 |
4 files changed, 8 insertions, 10 deletions
diff --git a/sw/source/core/unocore/unosett.cxx b/sw/source/core/unocore/unosett.cxx index b3a55713c4e4..16c42bfa5ea7 100644 --- a/sw/source/core/unocore/unosett.cxx +++ b/sw/source/core/unocore/unosett.cxx @@ -1050,19 +1050,17 @@ OSL_FAIL("not implemented"); static const char aInvalidStyle[] = "__XXX___invalid"; - class SwXNumberingRules::Impl : public SwClient { private: SwXNumberingRules& m_rParent; public: - Impl(SwXNumberingRules& rParent) : m_rParent(rParent) {} + explicit Impl(SwXNumberingRules& rParent) : m_rParent(rParent) {} protected: //SwClient - virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; + virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; }; - bool SwXNumberingRules::isInvalidStyle(const OUString &rName) { return rName == aInvalidStyle; diff --git a/sw/source/core/unocore/unostyle.cxx b/sw/source/core/unocore/unostyle.cxx index 390352de5350..ffb0f0fa0944 100644 --- a/sw/source/core/unocore/unostyle.cxx +++ b/sw/source/core/unocore/unostyle.cxx @@ -376,7 +376,7 @@ public: SwDoc* pDoc, const OUString& rStyleName) : SwXStyle(&rPool, SFX_STYLE_FAMILY_FRAME, pDoc, rStyleName){} - SwXFrameStyle( SwDoc *pDoc ); + explicit SwXFrameStyle(SwDoc *pDoc); virtual ~SwXFrameStyle(); virtual void SAL_CALL acquire( ) throw() override {SwXStyle::acquire();} @@ -409,7 +409,7 @@ protected: public: SwXPageStyle(SfxStyleSheetBasePool& rPool, SwDocShell* pDocSh, SfxStyleFamily eFam, const OUString& rStyleName); - SwXPageStyle(SwDocShell* pDocSh); + explicit SwXPageStyle(SwDocShell* pDocSh); virtual ~SwXPageStyle(); virtual void SAL_CALL setPropertyValue( const OUString& aPropertyName, const css::uno::Any& aValue ) throw(css::beans::UnknownPropertyException, css::beans::PropertyVetoException, css::lang::IllegalArgumentException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override; diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx index bd7403fe4172..2bf55f160156 100644 --- a/sw/source/core/unocore/unotbl.cxx +++ b/sw/source/core/unocore/unotbl.cxx @@ -3777,7 +3777,7 @@ void SwXCellRange::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) class SwXTableRows::Impl : public SwClient { public: - Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} + explicit Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} protected: //SwClient virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; @@ -3944,10 +3944,10 @@ void SwXTableRows::Impl::Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNe class SwXTableColumns::Impl : public SwClient { public: - Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} + explicit Impl(SwFrameFormat& rFrameFormat) : SwClient(&rFrameFormat) {} protected: //SwClient - virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; + virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem *pNew) override; }; OUString SwXTableColumns::getImplementationName() throw( uno::RuntimeException, std::exception ) diff --git a/sw/source/uibase/sidebar/StylePresetsPanel.hxx b/sw/source/uibase/sidebar/StylePresetsPanel.hxx index d0ca77567c2e..552e96c6ae45 100644 --- a/sw/source/uibase/sidebar/StylePresetsPanel.hxx +++ b/sw/source/uibase/sidebar/StylePresetsPanel.hxx @@ -58,7 +58,7 @@ public: private: struct TemplateEntry { - TemplateEntry(OUString& rURL) + explicit TemplateEntry(const OUString& rURL) : maURL(rURL) {} |