diff options
author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-03-20 11:43:59 +0100 |
---|---|---|
committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-03-20 12:42:10 +0100 |
commit | 3837901ef422d432f709dd95352796a54b58aae6 (patch) | |
tree | ec02d1fd95f40dd8cef76843f00de5832bc5abe3 /sw | |
parent | 8567047218c2f6e01b6525e0996607ad7f928a57 (diff) |
tdf#116516: INTERNET_PROXY_INFO always contains char* data
Regression from e80aef4e032f08ef0c4cfbb028bf83b81002f112
The InternetQueryOption has two variants: ANSI (A) and Unicode (W)
(see https://msdn.microsoft.com/en-us/library/aa385101).
INTERNET_PROXY_INFO struct we are using is defined to contain two
LPCTSTR members (see https://msdn.microsoft.com/en-us/library/aa385148).
When UNICODE is defined, InternetQueryOption expands to W variant,
and at the same time, all MS-specific generic string types (like
TCHAR or LPCTSTR) are expanded to wchar_t-based types.
So, the expectation is that InternetQueryOptionW fills the struct
with pointers to widechar strings.
But actually this is not true: InternetQueryOptionW still returns
char-based strings in the struct; so just revert partially commit
above.
Change-Id: I0facb1baf2a191f7bafdf185e684bfe741ca677a
Reviewed-on: https://gerrit.libreoffice.org/51629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sw')
0 files changed, 0 insertions, 0 deletions