diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-18 14:15:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-19 11:42:47 +0200 |
| commit | 82572caae4a282cdf79456b977508ca71507c584 (patch) | |
| tree | befc8478f8cd9bf7e7c9a87a776b063a9ed4b718 /sw | |
| parent | 71ef762f21ada8c25aad2183065478171e985e8c (diff) | |
improve and enable loplugin:fragiledestructor
Where the problem was benign and the class was not extended, I marked
the class as final.
Where the problem was benign and the class was extended, I marked the
relevant callee methods as final.
Other cases were excluded in the plugin.
Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc
Reviewed-on: https://gerrit.libreoffice.org/79089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/inc/finalthreadmanager.hxx | 2 | ||||
| -rw-r--r-- | sw/inc/section.hxx | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/sw/inc/finalthreadmanager.hxx b/sw/inc/finalthreadmanager.hxx index 587afbeb83f1..dfdf5407efca 100644 --- a/sw/inc/finalthreadmanager.hxx +++ b/sw/inc/finalthreadmanager.hxx @@ -36,7 +36,7 @@ class CancelJobsThread; class TerminateOfficeThread; class SwPauseThreadStarting; -class FinalThreadManager : public ::cppu::WeakImplHelper< css::lang::XServiceInfo, +class FinalThreadManager final : public ::cppu::WeakImplHelper< css::lang::XServiceInfo, css::util::XJobManager, css::frame::XTerminateListener2 > { diff --git a/sw/inc/section.hxx b/sw/inc/section.hxx index bdaff9c102be..1fcbf5028474 100644 --- a/sw/inc/section.hxx +++ b/sw/inc/section.hxx @@ -267,7 +267,7 @@ class SwSectionFrameMoveAndDeleteHint : public SfxHint enum class SectionSort { Not, Pos }; -class SW_DLLPUBLIC SwSectionFormat +class SW_DLLPUBLIC SwSectionFormat final : public SwFrameFormat , public ::sfx2::Metadatable { @@ -281,7 +281,6 @@ class SW_DLLPUBLIC SwSectionFormat SAL_DLLPRIVATE void UpdateParent(); // Parent has been changed. -protected: SwSectionFormat( SwFrameFormat* pDrvdFrame, SwDoc *pDoc ); virtual void Modify( const SfxPoolItem* pOld, const SfxPoolItem* pNew ) override; |