diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2021-03-14 14:37:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-03-17 12:30:41 +0100 |
| commit | f1cc5d2229956e3698fd40a4d900fe45e7f8e160 (patch) | |
| tree | 91c6d4dcafd5932c60ff2b46f845053bc9dcdd00 /sw | |
| parent | 32a0b409282554df7d66b7212ddd0fe187f86690 (diff) | |
throw exception for errors in uitest actions
so we abort early when a uitest goes wrong,
instead of letting tests become fragile
because it looks like its passing, but the code
is just accidentally working
Remove code in python uitests that was not actually
doing anything (and now crashes because we throw an exception
for actions that don't mean anything)
Change-Id: I9c52f9fdc06f1c01e9b93b58a5200f9c3684db1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112471
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sw')
| -rw-r--r-- | sw/qa/uitest/findReplace/findReplace.py | 1 | ||||
| -rw-r--r-- | sw/qa/uitest/writer_tests2/deleteAllComments.py | 1 | ||||
| -rw-r--r-- | sw/qa/uitest/writer_tests2/formatParagraph.py | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/sw/qa/uitest/findReplace/findReplace.py b/sw/qa/uitest/findReplace/findReplace.py index 9ce377f38292..14c5cf2188ea 100644 --- a/sw/qa/uitest/findReplace/findReplace.py +++ b/sw/qa/uitest/findReplace/findReplace.py @@ -79,7 +79,6 @@ class findReplace(UITestCase): select_pos(xTabs, "0") xSizeFont = dialog.getChild("westsizelb-cjk") xSizeFont.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+A"})) - xSizeFont.executeAction("BACKSPACE", tuple()) xSizeFont.executeAction("TYPE", mkPropertyValues({"TEXT":"16"})) #set font size 16 xOkBtn = dialog.getChild("ok") self.ui_test.close_dialog_through_button(xOkBtn) diff --git a/sw/qa/uitest/writer_tests2/deleteAllComments.py b/sw/qa/uitest/writer_tests2/deleteAllComments.py index ad9e0c823e6f..8633e77d49eb 100644 --- a/sw/qa/uitest/writer_tests2/deleteAllComments.py +++ b/sw/qa/uitest/writer_tests2/deleteAllComments.py @@ -25,7 +25,6 @@ class DeleteAllComments(UITestCase): selection = self.xUITest.executeCommand(".uno:SelectAll") self.xUITest.executeCommand(".uno:InsertAnnotation") cursor = document.getCurrentController().getViewCursor() - xWriterDoc.executeAction("LEFT", tuple()) type_text(xWriterEdit, "EEEEE") self.xUITest.executeCommand(".uno:InsertAnnotation") self.xUITest.executeCommand(".uno:DeleteAllNotes") diff --git a/sw/qa/uitest/writer_tests2/formatParagraph.py b/sw/qa/uitest/writer_tests2/formatParagraph.py index 7d2120f10320..b5f8df306226 100644 --- a/sw/qa/uitest/writer_tests2/formatParagraph.py +++ b/sw/qa/uitest/writer_tests2/formatParagraph.py @@ -516,7 +516,6 @@ class formatParagraph(UITestCase): xBottom = xDialog.getChild("bottommf") xMerge = xDialog.getChild("mergewithnext") - select_pos(xStyle, "1") xwidth.executeAction("UP", tuple()) xSync.executeAction("CLICK", tuple()) xLeft.executeAction("UP", tuple()) |