diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-07 13:03:58 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-06-08 01:29:32 +0200 |
| commit | 5708534b942c1d0ce384f6a8473da6bb569410e7 (patch) | |
| tree | 2ec4fe87624541c15bf89c8b839e8f8dba8a89f4 /test/source/container | |
| parent | 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b (diff) | |
look for unnecessary calls to Reference::is() after an UNO_QUERY_THROW
Since the previous call would throw if there was nothing to be assigned
to the value.
Idea from tml.
Used the following script to find places:
git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()'
Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969
Reviewed-on: https://gerrit.libreoffice.org/55417
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'test/source/container')
| -rw-r--r-- | test/source/container/xindexaccess.cxx | 2 | ||||
| -rw-r--r-- | test/source/container/xnamereplace.cxx | 1 |
2 files changed, 0 insertions, 3 deletions
diff --git a/test/source/container/xindexaccess.cxx b/test/source/container/xindexaccess.cxx index c17942507fe5..3791e2b76393 100644 --- a/test/source/container/xindexaccess.cxx +++ b/test/source/container/xindexaccess.cxx @@ -48,8 +48,6 @@ void XIndexAccess::testGetByIndex() void XIndexAccess::testGetByIndexException() { uno::Reference< container::XIndexAccess > xIndexAccess(init(), UNO_QUERY_THROW); - CPPUNIT_ASSERT(xIndexAccess.is()); - xIndexAccess->getByIndex(mnItems); } diff --git a/test/source/container/xnamereplace.cxx b/test/source/container/xnamereplace.cxx index 77badb46a0c2..cd2a05ae8f9a 100644 --- a/test/source/container/xnamereplace.cxx +++ b/test/source/container/xnamereplace.cxx @@ -22,7 +22,6 @@ void XNameReplace::testReplaceByName() xNameReplace->replaceByName(maTestReplacementName, getAnyElementForNameReplace()); Any aAny = xNameReplace->getByName( maTestReplacementName ); uno::Reference< uno::XInterface > xElement(aAny, UNO_QUERY_THROW); - CPPUNIT_ASSERT(xElement.is()); } } |