diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-14 09:58:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2014-05-14 08:10:22 +0000 |
| commit | 248145f99e95cc30bb6231a8e5ea4e294f147040 (patch) | |
| tree | c3b5c1e226cc631cde530f2cfb7df2d46f00b8c9 /test | |
| parent | 671eb12dee290607ed66f3b325f28e7bd4695cba (diff) | |
Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/source/sheet/xdatapilottable2.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/source/sheet/xdatapilottable2.cxx b/test/source/sheet/xdatapilottable2.cxx index a309e2479e76..fad98fd63036 100644 --- a/test/source/sheet/xdatapilottable2.cxx +++ b/test/source/sheet/xdatapilottable2.cxx @@ -250,7 +250,7 @@ table::CellAddress getLastUsedCellAddress( uno::Reference< sheet::XSpreadsheet > } -bool XDataPilotTable2::checkDrillDownSheetContent(uno::Reference< sheet::XSpreadsheet > xSheet, uno::Sequence< uno::Sequence< Any > > aData) +bool XDataPilotTable2::checkDrillDownSheetContent(uno::Reference< sheet::XSpreadsheet > xSheet, const uno::Sequence< uno::Sequence< Any > >& aData) { table::CellAddress aLastCell = getLastUsedCellAddress(xSheet, 0, 0); CPPUNIT_ASSERT(aData.getLength() > 0); @@ -269,7 +269,7 @@ bool XDataPilotTable2::checkDrillDownSheetContent(uno::Reference< sheet::XSpread for(sal_Int32 y = 0; y < aSheetData[x].getLength(); ++y) { Any& aCell1 = aSheetData[x][y]; - Any& aCell2 = aData[x][y]; + const Any& aCell2 = aData[x][y]; CPPUNIT_ASSERT(aCell1 == aCell2); } } |