summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorNoel <noel.grandin@collabora.co.uk>2021-02-16 15:47:06 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2021-02-17 07:44:18 +0100
commit1c9f0d9d8ee1a13d30be924cddaa94343fd8c840 (patch)
tree60348a9a4784cf2e5cb963045b7f796e4694f909 /test
parent27078ce8cb03f6ba61be5ce75c5231bc8798d6fe (diff)
loplugin:referencecasting in test..toolkit
Change-Id: Ia290ff4849f4d7eda978c7b1e2c7f36de744056f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'test')
-rw-r--r--test/source/beans/xpropertyset.cxx8
-rw-r--r--test/source/chart/xchartdata.cxx6
-rw-r--r--test/source/sheet/xactivationbroadcaster.cxx6
-rw-r--r--test/source/util/xrefreshable.cxx4
4 files changed, 11 insertions, 13 deletions
diff --git a/test/source/beans/xpropertyset.cxx b/test/source/beans/xpropertyset.cxx
index d42bc836ca88..33c0398650db 100644
--- a/test/source/beans/xpropertyset.cxx
+++ b/test/source/beans/xpropertyset.cxx
@@ -86,7 +86,7 @@ void XPropertySet::testPropertyChangeListener()
{
rtl::Reference<MockedPropertyChangeListener> xListener = new MockedPropertyChangeListener();
xPropSet->addPropertyChangeListener(
- aName, uno::Reference<beans::XPropertyChangeListener>(xListener.get()));
+ aName, uno::Reference<beans::XPropertyChangeListener>(xListener));
if (!isPropertyValueChangeable(aName))
continue;
@@ -94,7 +94,7 @@ void XPropertySet::testPropertyChangeListener()
xListener->m_bListenerCalled = false;
xPropSet->removePropertyChangeListener(
- aName, uno::Reference<beans::XPropertyChangeListener>(xListener.get()));
+ aName, uno::Reference<beans::XPropertyChangeListener>(xListener));
isPropertyValueChangeable(aName);
CPPUNIT_ASSERT(!xListener->m_bListenerCalled);
}
@@ -110,7 +110,7 @@ void XPropertySet::testVetoableChangeListener()
{
rtl::Reference<MockedVetoableChangeListener> xListener = new MockedVetoableChangeListener();
xPropSet->addVetoableChangeListener(
- aName, uno::Reference<beans::XVetoableChangeListener>(xListener.get()));
+ aName, uno::Reference<beans::XVetoableChangeListener>(xListener));
if (!isPropertyValueChangeable(aName))
continue;
@@ -118,7 +118,7 @@ void XPropertySet::testVetoableChangeListener()
xListener->m_bListenerCalled = false;
xPropSet->removeVetoableChangeListener(
- aName, uno::Reference<beans::XVetoableChangeListener>(xListener.get()));
+ aName, uno::Reference<beans::XVetoableChangeListener>(xListener));
isPropertyValueChangeable(aName);
CPPUNIT_ASSERT(!xListener->m_bListenerCalled);
}
diff --git a/test/source/chart/xchartdata.cxx b/test/source/chart/xchartdata.cxx
index dcecf33a0c3d..68a9b82f191e 100644
--- a/test/source/chart/xchartdata.cxx
+++ b/test/source/chart/xchartdata.cxx
@@ -67,11 +67,11 @@ void XChartData::testChartDataChangeEventListener()
rtl::Reference<MockedChartDataChangeEventListener> pListener0
= new MockedChartDataChangeEventListener();
xCD->addChartDataChangeEventListener(
- uno::Reference<chart::XChartDataChangeEventListener>(pListener0.get()));
+ uno::Reference<chart::XChartDataChangeEventListener>(pListener0));
rtl::Reference<MockedChartDataChangeEventListener> pListener1
= new MockedChartDataChangeEventListener();
xCD->addChartDataChangeEventListener(
- uno::Reference<chart::XChartDataChangeEventListener>(pListener1.get()));
+ uno::Reference<chart::XChartDataChangeEventListener>(pListener1));
uno::Reference<chart::XChartDataArray> xCDD(xCD, uno::UNO_QUERY_THROW);
uno::Sequence<uno::Sequence<double>> aData = xCDD->getData();
@@ -84,7 +84,7 @@ void XChartData::testChartDataChangeEventListener()
pListener1->m_bListenerCalled = false;
xCD->removeChartDataChangeEventListener(
- uno::Reference<chart::XChartDataChangeEventListener>(pListener1.get()));
+ uno::Reference<chart::XChartDataChangeEventListener>(pListener1));
aData[0][0] += 1.0;
xCDD->setData(aData);
CPPUNIT_ASSERT(pListener0->m_bListenerCalled);
diff --git a/test/source/sheet/xactivationbroadcaster.cxx b/test/source/sheet/xactivationbroadcaster.cxx
index 93fa5ab93689..6c7769db5a38 100644
--- a/test/source/sheet/xactivationbroadcaster.cxx
+++ b/test/source/sheet/xactivationbroadcaster.cxx
@@ -51,8 +51,7 @@ void XActivationBroadcaster::testAddRemoveActivationEventListener()
xAB->addActivationEventListener(nullptr);
rtl::Reference<MockedActivationEventListener> xListener = new MockedActivationEventListener();
- xAB->addActivationEventListener(
- uno::Reference<sheet::XActivationEventListener>(xListener.get()));
+ xAB->addActivationEventListener(uno::Reference<sheet::XActivationEventListener>(xListener));
uno::Reference<sheet::XSpreadsheetView> xView(xAB, UNO_QUERY_THROW);
uno::Reference<sheet::XSpreadsheet> xSheet1(xView->getActiveSheet(), UNO_SET_THROW);
@@ -62,8 +61,7 @@ void XActivationBroadcaster::testAddRemoveActivationEventListener()
CPPUNIT_ASSERT_MESSAGE("Listener wasn't called", xListener->mbListenerCalled);
- xAB->removeActivationEventListener(
- uno::Reference<sheet::XActivationEventListener>(xListener.get()));
+ xAB->removeActivationEventListener(uno::Reference<sheet::XActivationEventListener>(xListener));
xView->setActiveSheet(xSheet1);
CPPUNIT_ASSERT_MESSAGE("Listener still called after removal", xListener->mbListenerCalled);
}
diff --git a/test/source/util/xrefreshable.cxx b/test/source/util/xrefreshable.cxx
index f448d93e5008..5d145e5b2fbe 100644
--- a/test/source/util/xrefreshable.cxx
+++ b/test/source/util/xrefreshable.cxx
@@ -49,13 +49,13 @@ void XRefreshable::testRefreshListener()
uno::Reference<util::XRefreshable> xRefreshable(init(), uno::UNO_QUERY_THROW);
rtl::Reference<MockedRefreshListener> xListener = new MockedRefreshListener();
- xRefreshable->addRefreshListener(uno::Reference<util::XRefreshListener>(xListener.get()));
+ xRefreshable->addRefreshListener(uno::Reference<util::XRefreshListener>(xListener));
xRefreshable->refresh();
CPPUNIT_ASSERT(xListener->m_bListenerCalled);
xListener->m_bListenerCalled = false;
- xRefreshable->removeRefreshListener(uno::Reference<util::XRefreshListener>(xListener.get()));
+ xRefreshable->removeRefreshListener(uno::Reference<util::XRefreshListener>(xListener));
xRefreshable->refresh();
CPPUNIT_ASSERT(!xListener->m_bListenerCalled);
}