diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-06 15:29:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-18 08:32:26 +0200 |
| commit | 86a32589e90ee983159fb5b2c6a594428ab7d422 (patch) | |
| tree | 6de946fe2b9b25614f0d197af95e9d3aadcd1bd9 /test | |
| parent | bb17844099ba98a77c8e5d7a25c0c416a4b0641e (diff) | |
Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
Diffstat (limited to 'test')
| -rw-r--r-- | test/source/sheet/xsheetoutline.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/source/sheet/xsheetoutline.cxx b/test/source/sheet/xsheetoutline.cxx index 32754481a8ff..6c734ef2c13a 100644 --- a/test/source/sheet/xsheetoutline.cxx +++ b/test/source/sheet/xsheetoutline.cxx @@ -39,7 +39,7 @@ const OUString rowLevel4 = "OutlineSheet.A7:A21"; uno::Reference< sheet::XSpreadsheet > aSheetGlobal; -OUString getVisibleAdress(OUString aLevelRangeString) +OUString getVisibleAdress(const OUString& aLevelRangeString) { uno::Reference<table::XCellRange> aSheetRangeAccess(aSheetGlobal, UNO_QUERY_THROW); @@ -53,7 +53,7 @@ OUString getVisibleAdress(OUString aLevelRangeString) } -table::CellRangeAddress getAddressFromRangeString(OUString aStringAddress) +table::CellRangeAddress getAddressFromRangeString(const OUString& aStringAddress) { uno::Reference< table::XCellRange > aSheetRangeAccess(aSheetGlobal, UNO_QUERY_THROW); |