diff options
| author | Gabor Kelemen <kelemen.gabor2@nisz.hu> | 2019-10-04 00:03:09 +0200 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2019-10-04 09:08:49 +0200 |
| commit | b3c072a4ee94c5f86723cdcc98ea08f46f981b4a (patch) | |
| tree | dbbcc924f1aa83d37d0a7a03a048b9a0818faa49 /toolkit | |
| parent | 5d89d64846cd9fa56ffae47aae7c8c52a2a5feea (diff) | |
find-unneeded-includes: ignore extra recommendations
When IWYU is used to check cxx files it also checks associated
hxx (but for .hxx -> .h too) files too and gives addition/removal recommendations
There is no documented way of disabling this.
Currently f-u-i does not differentiate between recommendations for the
checked file and its header and prints everything.
Which means sometimes I need to update .hxx files or blacklist warnings
that interestingly are not shown when the same .hxx is checked with IWYU.
The worst example is ucb/source/ucp/ftp/curl.hxx where IWYU gives recommendations
for /usr/include/x86_64-linux-gnu/curl/curl.h
Remedy this with considering the full
filename + should add these lines: / should remove these lines:
string as beginning of interesting recommendations
Also remove some now obsolete blacklist entries from yaml files
Change-Id: I1d139536992e4b56c699c31a4cc6491d373c2002
Reviewed-on: https://gerrit.libreoffice.org/80172
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'toolkit')
| -rw-r--r-- | toolkit/IwyuFilter_toolkit.yaml | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/toolkit/IwyuFilter_toolkit.yaml b/toolkit/IwyuFilter_toolkit.yaml index 4d2ab3248bec..b29efcf83049 100644 --- a/toolkit/IwyuFilter_toolkit.yaml +++ b/toolkit/IwyuFilter_toolkit.yaml @@ -4,9 +4,6 @@ blacklist: toolkit/source/awt/vclxmenu.cxx: # Needed for direct member access - vcl/window.hxx - include/toolkit/controls/geometrycontrolmodel.hxx: - # Silence warning while checking geometrycontrolmodel.cxx - - toolkit/controls/geometrycontrolmodel_impl.hxx toolkit/source/helper/servicenames.cxx: # Needed for extern array declarations - toolkit/helper/servicenames.hxx |